ICEfaces
  1. ICEfaces
  2. ICE-4490

compat component-showcase navigation

          Details

          • Type: Bug Bug
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 2.0-Alpha1
          • Fix Version/s: 2.0-Alpha1, 2.0.0
          • Component/s: Sample Apps
          • Labels:
            None
          • Environment:
            ICEfaces 2.0

            Description

            Navigation required two clicks to succeed in compat/samples/component-showcase.

            This is due to the fact that the detail panels are displayed via <ui:include> which must be evaluated to create the component tree prior to input values being decoded. This caused the selected detail view to lag behind by one step.

            The solution is to use the <f:param> directly from the request map in the NavigationBean getter:

                public String getSelectedIncludePath() {
                    //check for a currently selected path to be ready for ui:include
                    FacesContext context = FacesContext.getCurrentInstance();
                    Map map = context.getExternalContext().getRequestParameterMap();
                    String requestedPath = (String) map.get("includePath");
                    if (null != requestedPath) {
                        selectedIncludePath = requestedPath;
                    }
                    return selectedIncludePath;
                }

              Activity

              Ascending order - Click to sort in descending order
              Ted Goddard created issue -
              Ted Goddard made changes -
              Field Original Value New Value
              Status Open [ 1 ] Resolved [ 5 ]
              Fix Version/s 2.0 [ 10032 ]
              Resolution Fixed [ 1 ]
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #18898 Tue May 19 16:35:35 MDT 2009 ted.goddard f:ajax based ajax configuration for navigation links (ICE-4490)
              Files Changed
              Commit graph MODIFY /icefaces/scratchpads/glimmer/compat/samples/component-showcase/web/WEB-INF/includes/content/navigation2.xhtml
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #18900 Tue May 19 17:03:18 MDT 2009 ted.goddard cosmetic cleanup and h:head and h:body to avoid error messages (ICE-4490)
              Files Changed
              Commit graph MODIFY /icefaces/scratchpads/glimmer/compat/samples/component-showcase/web/WEB-INF/includes/templates/page-template.xhtml
              Commit graph MODIFY /icefaces/scratchpads/glimmer/compat/samples/component-showcase/web/WEB-INF/includes/content/navigation2.xhtml
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #19045 Wed Jul 08 14:50:38 MDT 2009 ted.goddard restored panelCollapsable navigation (ICE-4490)
              Files Changed
              Commit graph MODIFY /icefaces/scratchpads/glimmer/compat/samples/component-showcase/web/WEB-INF/includes/templates/page-template.xhtml
              Commit graph MODIFY /icefaces/scratchpads/glimmer/compat/samples/component-showcase/src/org/icefaces/application/showcase/facelets/navigation/NavigationBean.java
              Hide
              Permalink
              Ted Goddard added a comment -

              Occasionally the parameter would be "" and not null – perhaps it was created as a hidden field in the browser and is now being serialized with no value. The following change to NavigationBean addresses this:

              • if (null != requestedPath) {
                + if ((null != requestedPath) && (requestedPath.length() > 0)) {
              Show
              Ted Goddard added a comment - Occasionally the parameter would be "" and not null – perhaps it was created as a hidden field in the browser and is now being serialized with no value. The following change to NavigationBean addresses this: if (null != requestedPath) { + if ((null != requestedPath) && (requestedPath.length() > 0)) {
              Ken Fyten made changes -
              Fix Version/s 2.0-Alpha1 [ 10213 ]
              Fix Version/s 2.0-Beta [ 10032 ]
              Affects Version/s 2.0-Alpha1 [ 10213 ]
              Affects Version/s 2.0-Beta [ 10032 ]
              Ken Fyten made changes -
              Fix Version/s 2.0.0 [ 10230 ]
              Ken Fyten made changes -
              Status Resolved [ 5 ] Closed [ 6 ]

                People

                • Assignee:
                  Unassigned
                  Reporter:
                  Ted Goddard
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  0 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: