ICEfaces
  1. ICEfaces
  2. ICE-4428

REGRESSION - navigation rule: redirect from forwarded page doesn't work

          Details

          • Type: Bug Bug
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 1.7.2-SP2, 1.8
          • Fix Version/s: 1.8.1
          • Component/s: Framework
          • Labels:
            None
          • Environment:
            ICEfaces 1.7.2-SP1 - 1.8. Also doesn't work at all on Glassfish v2.1.

            Description

            The regression test case for ICE-3502 is failing with latest trunk, ICEfaces 1.7.2-SP1 release (since 1.7.2-SP1). This was fixed in 1.7.2 originally.

            -----------

            if navigate from page A to page B using forward and then redirect from page B back to page A, it stays on the same page. see attached test case

              Activity

              Ascending order - Click to sort in descending order
              Sam Xiao created issue -
              Ken Fyten made changes -
              Field Original Value New Value
              Summary CLONE -navigation rule: redirect from forwarded page doesn't work REGRESSION - navigation rule: redirect from forwarded page doesn't work
              Salesforce Case []
              Fix Version/s 1.8.1 [ 10170 ]
              Fix Version/s 1.7.2 [ 10130 ]
              Assignee Priority P2
              Affects Version/s 1.8 [ 10161 ]
              Affects Version/s 1.7.2-SP2 [ 10162 ]
              Affects Version/s 1.7.1 [ 10122 ]
              Description if navigate from page A to page B using forward and then redirect from page B back to page A, it stays on the same page. see attached test case The regression test case for ICE-3502 is failing with latest trunk, ICEfaces 1.7.2-SP1 release (since 1.7.2-SP1). This was fixed in 1.7.2 originally.

              -----------

              if navigate from page A to page B using forward and then redirect from page B back to page A, it stays on the same page. see attached test case
              Assignee Deryk Sinotte [ deryk.sinotte ]
              Ken Fyten made changes -
              Environment ANY ICEfaces 1.7.2-SP1 - 1.8. Also doesn't work at all on Glassfish v2.1.
              Salesforce Case []
              Hide
              Permalink
              Deryk Sinotte added a comment -

              Please review test case to ensure it's testing the correct behaviour. If so, proceed to investigate the issue.

              Show
              Deryk Sinotte added a comment - Please review test case to ensure it's testing the correct behaviour. If so, proceed to investigate the issue.
              Deryk Sinotte made changes -
              Assignee Deryk Sinotte [ deryk.sinotte ] Mircea Toma [ mircea.toma ]
              Hide
              Permalink
              Mircea Toma added a comment -

              The test case for ICE-3502 is executing in effect a forward and then a page reload because the forward won't change the URL of the rendered page. Issues ICE-3886, ICE-3691, and ICE-3886 covered exactly this use case.

              Show
              Mircea Toma added a comment - The test case for ICE-3502 is executing in effect a forward and then a page reload because the forward won't change the URL of the rendered page. Issues ICE-3886 , ICE-3691 , and ICE-3886 covered exactly this use case.
              Hide
              Permalink
              Mircea Toma added a comment -

              In ICE-3691 is mentioned that the fixes are to be back-ported to 1.7 branch thus explaining why 1.7.2 has the same behavior as 1.8.

              Show
              Mircea Toma added a comment - In ICE-3691 is mentioned that the fixes are to be back-ported to 1.7 branch thus explaining why 1.7.2 has the same behavior as 1.8.
              Hide
              Permalink
              Mircea Toma added a comment - - edited

              The fixes for ICE-3886, ICE-3691, and ICE-3886 changed somewhat the behavior of page reload we had in 1.7. But as it was explained also in ICE-3907 the behavior of page reload is different if concurrentDOMViews=true, the views are not re-used on page reload. By enabling concurrentDOMViews in ICE-3502 test case it will make it run successfully.

              Show
              Mircea Toma added a comment - - edited The fixes for ICE-3886 , ICE-3691 , and ICE-3886 changed somewhat the behavior of page reload we had in 1.7. But as it was explained also in ICE-3907 the behavior of page reload is different if concurrentDOMViews=true, the views are not re-used on page reload. By enabling concurrentDOMViews in ICE-3502 test case it will make it run successfully.
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #18833 Sat May 02 09:02:23 MDT 2009 mircea.toma ICE-4428 Reset the last viewId on redirect.
              Files Changed
              Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/context/BridgeExternalContext.java
              Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/webapp/http/servlet/ServletExternalContext.java
              Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/context/BridgeFacesContext.java
              Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/webapp/http/portlet/PortletExternalContext.java
              Hide
              Permalink
              Mircea Toma added a comment -

              Reset the last viewId on redirect. The fix makes ICEfaces in single-view mode behave like SUN-RI now.

              Show
              Mircea Toma added a comment - Reset the last viewId on redirect. The fix makes ICEfaces in single-view mode behave like SUN-RI now.
              Mircea Toma made changes -
              Status Open [ 1 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Hide
              Permalink
              Joanne Bai added a comment -

              Fix verified on ICEfaces trunk revision 18832

              Show
              Joanne Bai added a comment - Fix verified on ICEfaces trunk revision 18832
              Hide
              Permalink
              Ken Fyten added a comment -

              QA is reporting that this test is passing as expected for JSF 1.2, but is failing on Tomcat 5.5 with JSF 1.1. Please investigate.

              Show
              Ken Fyten added a comment - QA is reporting that this test is passing as expected for JSF 1.2, but is failing on Tomcat 5.5 with JSF 1.1. Please investigate.
              Ken Fyten made changes -
              Resolution Fixed [ 1 ]
              Status Resolved [ 5 ] Reopened [ 4 ]
              Assignee Priority P2 P1
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #18907 Wed May 20 15:43:44 MDT 2009 mircea.toma ICE-4428 Reset viewRoot on redirect.
              Files Changed
              Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/context/BridgeFacesContext.java
              Hide
              Permalink
              Mircea Toma added a comment -

              In JSF 1.2 the ViewRoot is reset at the end of lifecycle and restored if necessary with the help of state management. When we introduced our own state management implementation it was decided keep around the ViewRoot in JSF 1.1 because there wasn't any state management available. The decision to not reset the ViewRoot in JSF 1.1 was introduced in ICE-3980.

              So now the ViewRoot is reset only on redirect so that RestoreViewPhase will create a new view based on the GET request path.

              Show
              Mircea Toma added a comment - In JSF 1.2 the ViewRoot is reset at the end of lifecycle and restored if necessary with the help of state management. When we introduced our own state management implementation it was decided keep around the ViewRoot in JSF 1.1 because there wasn't any state management available. The decision to not reset the ViewRoot in JSF 1.1 was introduced in ICE-3980 . So now the ViewRoot is reset only on redirect so that RestoreViewPhase will create a new view based on the GET request path.
              Mircea Toma made changes -
              Status Reopened [ 4 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #18925 Tue May 26 07:30:08 MDT 2009 mircea.toma ICE-4428 Reset viewRoot only when running with JSF1.1.
              Files Changed
              Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/context/BridgeFacesContext.java
              Hide
              Permalink
              Mircea Toma added a comment -

              ICE-4428 Reset viewRoot only when running with JSF1.1.

              Show
              Mircea Toma added a comment - ICE-4428 Reset viewRoot only when running with JSF1.1.
              Ken Fyten made changes -
              Status Resolved [ 5 ] Closed [ 6 ]
              Assignee Priority P1

                People

                • Assignee:
                  Mircea Toma
                  Reporter:
                  Sam Xiao
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  0 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: