ICEfaces
  1. ICEfaces
  2. ICE-4405

selectInputDate loses focus after closing calendar.

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.8
    • Fix Version/s: 1.8.1
    • Component/s: None
    • Labels:
      None
    • Environment:
      tomcat 6. icefaces 1.8, jsf 1.2,

      Description

      In version 1.70 and prior of the selectinputdate closing the calendar would put focus on the calendarbutton image, now the focus seems to go to the address bar or top of form.

      This can be seen in component showcase, click on calendar button , select a date , focus leaves the component all together.

        Issue Links

          Activity

          Michelle Cannon created issue -
          Hide
          Michelle Cannon added a comment -

          We found a workaround, but it only works for us, there were significant changes between icefaces 1.8dr2 and 1.8rc1 for the selectinputdate, we don't really need that new functionality , at least we can live without it for now. We retrofitted the selectinputdateRenderer for 1.8dr2 to 1.80 ga. We did some regression test and it seems to function as the 1.70 component did. The fix in ice-4401 is necessary to make this work.

          Show
          Michelle Cannon added a comment - We found a workaround, but it only works for us, there were significant changes between icefaces 1.8dr2 and 1.8rc1 for the selectinputdate, we don't really need that new functionality , at least we can live without it for now. We retrofitted the selectinputdateRenderer for 1.8dr2 to 1.80 ga. We did some regression test and it seems to function as the 1.70 component did. The fix in ice-4401 is necessary to make this work.
          Michelle Cannon made changes -
          Field Original Value New Value
          Link This issue depends on ICE-4401 [ ICE-4401 ]
          Ken Fyten made changes -
          Summary selectinputdate , loses focus after closing calendar. selectInputDate loses focus after closing calendar.
          Salesforce Case []
          Fix Version/s 1.8.1 [ 10170 ]
          Assignee Priority P2
          Affects Version/s 1.8DR#1 [ 10141 ]
          Affects Version/s 1.8DR#2 [ 10142 ]
          Affects Version/s 1.8RC1 [ 10143 ]
          Affects Version/s 1.7.2 SP1 [ 10144 ]
          Affects Version/s  1.7.2 SP1a [ 10150 ]
          Affects Version/s 1.7.2 SP1b [ 10160 ]
          Affects Version/s 1.7.2-SP2 [ 10162 ]
          Affects Version/s 1.8RC2 [ 10163 ]
          Description In version 1.70 and prior of the selectinputdate closing the calendar would put focus on the calendarbutton image, now the focus seems to go to the address bar or top of form.
          This can be seen in component showcase, click on calendar button , select a date , focus leaves the component all together
          In version 1.70 and prior of the selectinputdate closing the calendar would put focus on the calendarbutton image, now the focus seems to go to the address bar or top of form.

          This can be seen in component showcase, click on calendar button , select a date , focus leaves the component all together.

          Assignee Adnan Durrani [ adnan.durrani ]
          Hide
          Ken Fyten added a comment -

          This affects the default use-case (date, but no time entry) only. We made a late change to have the component retain the original behavior in terms of automatically closing when a date is selected in date-entry mode, which must be what introduced this issue.

          Focus should be returned to the popup calendar button when a date is selected in this way. Note that no changes should be made to the focus mgmt. behavior if a date+time entry is occurring.

          Show
          Ken Fyten added a comment - This affects the default use-case (date, but no time entry) only. We made a late change to have the component retain the original behavior in terms of automatically closing when a date is selected in date-entry mode, which must be what introduced this issue. Focus should be returned to the popup calendar button when a date is selected in this way. Note that no changes should be made to the focus mgmt. behavior if a date+time entry is occurring.
          Repository Revision Date User Message
          ICEsoft Public SVN Repository #18812 Tue Apr 28 15:03:48 MDT 2009 adnan.durrani Fix for ICE-4405 (selectInputDate loses focus after closing calendar)
          Changes made so the calendar button will get the focus after date selection in Date-only selection mode.
          Files Changed
          Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/selectinputdate/SelectInputDateRenderer.java
          Adnan Durrani made changes -
          Status Open [ 1 ] In Progress [ 3 ]
          Hide
          Adnan Durrani added a comment -

          Fixed:
          Changes made so the calendar button will get the focus after date selection in Date-only selection mode.

          Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\selectinputdate\SelectInputDateRenderer.java
          Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\selectinputdate\SelectInputDateRenderer.java
          Completed: At revision: 18812

          Show
          Adnan Durrani added a comment - Fixed: Changes made so the calendar button will get the focus after date selection in Date-only selection mode. Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\selectinputdate\SelectInputDateRenderer.java Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\selectinputdate\SelectInputDateRenderer.java Completed: At revision: 18812
          Adnan Durrani made changes -
          Status In Progress [ 3 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Hide
          Joanne Bai added a comment -

          Verified with success on ICEfaces 1.8.1 build 1 + Glassfish v2.1 using component showcase facelets-enh

          Browsers tested:
          FF3 - can actually see focus on calendar button after the popup is closed

          IE7 - cannot see where the focus is after the popup calendar gets closed, but the popup calendar will be brought up once the Enter key is hit. It means the calendar button really has the focus.

          Opera 9.64 - the same behavior as in IE7

          Show
          Joanne Bai added a comment - Verified with success on ICEfaces 1.8.1 build 1 + Glassfish v2.1 using component showcase facelets-enh Browsers tested: FF3 - can actually see focus on calendar button after the popup is closed IE7 - cannot see where the focus is after the popup calendar gets closed, but the popup calendar will be brought up once the Enter key is hit. It means the calendar button really has the focus. Opera 9.64 - the same behavior as in IE7
          Ken Fyten made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Assignee Priority P2

            People

            • Assignee:
              Adnan Durrani
              Reporter:
              Michelle Cannon
            • Votes:
              1 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: