ICEfaces
  1. ICEfaces
  2. ICE-4395

JSF2.0: Have to ensure that all our components encodeBegin(-) methods call super.encodeBegin(-) before doing anything, so that BeforeRenderEvent is before anything

          Details

          • Type: Task Task
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: None
          • Fix Version/s: 1.8.1
          • Component/s: None
          • Labels:
            None
          • Environment:
            JSF2.0 encodeBegin(-) + super.encodeBegin(-)

            Description

            Have to ensure that all our components encodeBegin(-) methods call super.encodeBegin(-) before doing anything, so that BeforeRenderEvent is before anything

              Activity

              Descending order - Click to sort in ascending order
              Hide
              Permalink
              Adnan Durrani added a comment -

              All overridden encodeBegin(..) and encodeEnd(..) of the components now calls its super.

              Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\ext\RowSelector.java
              Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\gmap\GMapControl.java
              Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\gmap\GMapDirection.java
              Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\gmap\GMapGeoXml.java
              Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\gmap\GMapLatLng.java
              Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\gmap\GMapLatLngs.java
              Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\gmap\GMapMarker.java
              Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\loadbundle\LoadBundle.java
              Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\outputchart\OutputChart.java
              Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\outputchart\OutputChartRenderer.java
              Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\paneltooltip\PanelTooltip.java
              Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\paneltooltip\PanelTooltipRenderer.java
              Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\loadbundle\LoadBundle.java
              Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\gmap\GMapGeoXml.java
              Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\outputchart\OutputChart.java
              Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\paneltooltip\PanelTooltip.java
              Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\ext\RowSelector.java
              Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\gmap\GMapControl.java
              Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\gmap\GMapDirection.java
              Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\gmap\GMapLatLng.java
              Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\gmap\GMapMarker.java
              Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\outputchart\OutputChartRenderer.java
              Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\paneltooltip\PanelTooltipRenderer.java
              Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\gmap\GMapLatLngs.java
              Completed: At revision: 18799

              Show
              Adnan Durrani added a comment - All overridden encodeBegin(..) and encodeEnd(..) of the components now calls its super. Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\ext\RowSelector.java Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\gmap\GMapControl.java Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\gmap\GMapDirection.java Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\gmap\GMapGeoXml.java Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\gmap\GMapLatLng.java Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\gmap\GMapLatLngs.java Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\gmap\GMapMarker.java Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\loadbundle\LoadBundle.java Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\outputchart\OutputChart.java Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\outputchart\OutputChartRenderer.java Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\paneltooltip\PanelTooltip.java Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\paneltooltip\PanelTooltipRenderer.java Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\loadbundle\LoadBundle.java Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\gmap\GMapGeoXml.java Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\outputchart\OutputChart.java Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\paneltooltip\PanelTooltip.java Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\ext\RowSelector.java Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\gmap\GMapControl.java Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\gmap\GMapDirection.java Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\gmap\GMapLatLng.java Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\gmap\GMapMarker.java Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\outputchart\OutputChartRenderer.java Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\paneltooltip\PanelTooltipRenderer.java Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\gmap\GMapLatLngs.java Completed: At revision: 18799
              Hide
              Permalink
              Adnan Durrani added a comment - - edited

              In JSF2.0 the UIComponent.encodeBegin(..) and UIComponent.encodeEnd(..) are doing two new things.

              • encodeBegin
              • publishEvent(..)
              • pushComponentToEL(..)
              • encodeEnd
              • popComponentFromEL(..)

              So if any of our component is overriding any of the above method they should be calling its super.

              Here are the findings:

              The following components override UIComponent.encodeBegin(..)

              • calls super.encodeBegin
                -HtmlDataTable
                -Gmap
                -InputRichText
                -PanelCollapsible
                -PanelDivider
                -UISeries
                -PanelTabSet
                -SelectInputDate
                -SelectInputText
                -OutputChart (Executes some code before super call)
                -PanelTooltip (Executes some code before super call)
              • doesn't call super.encodeBegin
                -GMapControl
                -GMapDirection
                -GMapGeoXml
                -GMapLatLng
                -GMapLatLngs
                -GMapMarker
                -LoadBundle
                -RowSelector

              The following components override UIComponent.encodeEnd(..)

              • calls super.encodeEnd
                -OutputBody
              • doesn't call super.encodeEnd
                -RowSelector:
              Show
              Adnan Durrani added a comment - - edited In JSF2.0 the UIComponent.encodeBegin(..) and UIComponent.encodeEnd(..) are doing two new things. encodeBegin publishEvent(..) pushComponentToEL(..) encodeEnd popComponentFromEL(..) So if any of our component is overriding any of the above method they should be calling its super. Here are the findings: The following components override UIComponent.encodeBegin(..) calls super.encodeBegin -HtmlDataTable -Gmap -InputRichText -PanelCollapsible -PanelDivider -UISeries -PanelTabSet -SelectInputDate -SelectInputText -OutputChart (Executes some code before super call) -PanelTooltip (Executes some code before super call) doesn't call super.encodeBegin -GMapControl -GMapDirection -GMapGeoXml -GMapLatLng -GMapLatLngs -GMapMarker -LoadBundle -RowSelector The following components override UIComponent.encodeEnd(..) calls super.encodeEnd -OutputBody doesn't call super.encodeEnd -RowSelector:

                People

                • Assignee:
                  Adnan Durrani
                  Reporter:
                  Adnan Durrani
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  0 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: