ICEfaces
  1. ICEfaces
  2. ICE-4372

ice:dataExporter component does not work with ice:dataTable which uses ice:columns for dynamic column definition

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.8
    • Fix Version/s: 1.8.3, 1.8.2-EE-GA_P02, 2.0.0
    • Component/s: ICE-Components
    • Labels:
      None
    • Environment:
      IE7, Firefox 3, Windows Vista

      Description

      ice:dataExporter component does not work with ice:dataTable which uses ice:columns for dynamic column definition

      Reason: method renderToHandler in class DataExporterRenderer does only supports ice:column and not ice:columns

        Activity

        Stefan Rempfer created issue -
        Hide
        Raphael Bertrand added a comment -

        Other possible reason: getRenderedChildColumnsList in class DataExporterRenderer does only supports ice:column and not ice:columns. Maybe a check with TableRenderer can be usefull

        Show
        Raphael Bertrand added a comment - Other possible reason: getRenderedChildColumnsList in class DataExporterRenderer does only supports ice:column and not ice:columns. Maybe a check with TableRenderer can be usefull
        Hide
        Vsb Vsb added a comment -

        This issue is still unassigned. Are there any plans for future releases?

        Show
        Vsb Vsb added a comment - This issue is still unassigned. Are there any plans for future releases?
        Hide
        J D added a comment -

        I've posted a on this issue comment in the forum
        http://www.icefaces.org/JForum/posts/list/15232.page

        Show
        J D added a comment - I've posted a on this issue comment in the forum http://www.icefaces.org/JForum/posts/list/15232.page
        Tyler Johnson made changes -
        Field Original Value New Value
        Salesforce Case [5007000000C2czs]
        Ken Fyten made changes -
        Fix Version/s 1.8.2-EE-GA_P02 [ 10226 ]
        Ken Fyten made changes -
        Assignee Priority P2
        Assignee Adnan Durrani [ adnan.durrani ]
        Ken Fyten made changes -
        Fix Version/s 2.0.0 [ 10230 ]
        Fix Version/s 1.8.3 [ 10211 ]
        Assignee Adnan Durrani [ adnan.durrani ] Mark Collette [ mark.collette ]
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #23073 Tue Nov 09 20:49:51 MST 2010 mark.collette ICE-4372 : ice:dataExporter component does not work with ice:dataTable which uses ice:columns for dynamic column definition
        Files Changed
        Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/dataexporter/DataExporter.java
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #23074 Tue Nov 09 20:59:03 MST 2010 mark.collette ICE-4372 : ice:dataExporter component does not work with ice:dataTable which uses ice:columns for dynamic column definition
        Files Changed
        Commit graph MODIFY /icefaces2/trunk/icefaces/compat/components/src/main/java/com/icesoft/faces/component/dataexporter/DataExporter.java
        Hide
        Mark Collette added a comment -

        Made extensive modifications to the outputting code to handle iterating over UIColumns, which was exacerbated by the UIColumns having an unspecified number rows, requiring actual iteration to determine where the includeColumns indexes would end up being.

        Testing should involve having a mix of several ice:columns interspersed with several ice:column objects. There should be two main scenarios: one with includeColumns specified, using out of sequence columns indexes which correspond to both ice:column and ice:columns, and the other scenario without includeColumns specified. That should cover most of the code paths. Testing with Excel is easier than CSV, since CSV intentionally omits outputting the column headers.

        icefaces trunk
        Subversion 23073

        icefaces 2 trunk
        Subversion 23074

        Show
        Mark Collette added a comment - Made extensive modifications to the outputting code to handle iterating over UIColumns, which was exacerbated by the UIColumns having an unspecified number rows, requiring actual iteration to determine where the includeColumns indexes would end up being. Testing should involve having a mix of several ice:columns interspersed with several ice:column objects. There should be two main scenarios: one with includeColumns specified, using out of sequence columns indexes which correspond to both ice:column and ice:columns, and the other scenario without includeColumns specified. That should cover most of the code paths. Testing with Excel is easier than CSV, since CSV intentionally omits outputting the column headers. icefaces trunk Subversion 23073 icefaces 2 trunk Subversion 23074
        Mark Collette made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Ken Fyten made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Assignee Priority P2

          People

          • Assignee:
            Mark Collette
            Reporter:
            Stefan Rempfer
          • Votes:
            6 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: