ICEfaces
  1. ICEfaces
  2. ICE-4271

To get the DOMContext after initialization components should call getDOMContext instead of attachDOMContext

          Details

          • Type: Improvement Improvement
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 1.8.1
          • Fix Version/s: 1.8.2-RC1, 1.8.2
          • Component/s: ICE-Components
          • Labels:
            None
          • Environment:
            ICEfaces

            Description

            DOMContext.attach() sometimes creates a malformed subtree that is discarded by DOM error checking. This is the case with the popup menu component. In general the attach() mechanism is inefficient and should be removed. At this time, however, the CommandLinkRenderer makes use of the attach() functionality, possibly through its use of two different root nodes ("a" and "span" depending on whether the component is disabled.

            The recommended fix is to remove the attach() functionality and update the CommandLinkRenderer to a pure ResponseWriter implementation.

              Activity

              Repository Revision Date User Message
              ICEsoft Public SVN Repository #19889 Tue Dec 08 14:23:06 MST 2009 adnan.durrani Applying fix of ICE-4271 of 1.8.2EE, towards ICE-4481
              Files Changed
              Commit graph MODIFY /icefaces/scratchpads/glimmer/compat/core/src/main/java/com/icesoft/faces/renderkit/dom_html_basic/MenuRenderer.java
              Commit graph MODIFY /icefaces/scratchpads/glimmer/compat/components/src/main/java/com/icesoft/faces/component/panelpositioned/PanelPositionedRenderer.java
              Commit graph MODIFY /icefaces/scratchpads/glimmer/compat/core/src/main/java/com/icesoft/faces/renderkit/dom_html_basic/LabelRenderer.java
              Commit graph MODIFY /icefaces/scratchpads/glimmer/compat/components/src/main/java/com/icesoft/faces/component/panelseries/PanelSeriesRenderer.java
              Commit graph MODIFY /icefaces/scratchpads/glimmer/compat/components/src/main/java/com/icesoft/faces/component/menupopup/MenuPopupRenderer.java
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #19064 Wed Jul 15 13:44:45 MDT 2009 adnan.durrani Fix for ICE-4271 (To get the DOMContext after initialization components should call getDOMContext instead of attachDOMContext)
              Files Changed
              Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/panelseries/PanelSeriesRenderer.java
              Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/renderkit/dom_html_basic/LabelRenderer.java
              Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/panelpositioned/PanelPositionedRenderer.java
              Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/menupopup/MenuPopupRenderer.java
              Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/renderkit/dom_html_basic/MenuRenderer.java
              Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/renderkit/dom_html_basic/DomBasicRenderer.java

                People

                • Assignee:
                  Adnan Durrani
                  Reporter:
                  Ted Goddard
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  0 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: