ICEfaces
  1. ICEfaces
  2. ICE-4257

ICEfaces + Woodstock Compatibility: Error Handling Issue

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.8RC2
    • Fix Version/s: 1.8.1
    • Component/s: Framework
    • Labels:
      None
    • Environment:
      with any Woodstock Project

      Description

      In RC2, one of situation failed is related to Error Handling failed.
      ie,
      #1. if go a a wrong url or servlet mapping
      #2. go to a faces/Page1.jsp

      failed.

        Issue Links

          Activity

          Frank Ye created issue -
          Frank Ye made changes -
          Field Original Value New Value
          ICEfaces Forum Reference http://www.icefaces.org/JForum/posts/list/12068.page
          Salesforce Case []
          Frank Ye made changes -
          Link This issue blocks ICE-3581 [ ICE-3581 ]
          Ken Fyten made changes -
          Summary Error Handling ICEfaces + Woodstock Compatibility: Error Handling Issue
          Salesforce Case []
          Assignee Ted Goddard [ ted.goddard ]
          Ken Fyten made changes -
          Salesforce Case []
          Affects Version/s 1.8RC2 [ 10163 ]
          Hide
          Ted Goddard added a comment -

          Stack excerpt from the forum post.

          com.icesoft.faces.application.ViewRootStateManagerImpl.saveView(ViewRootStateManagerImpl.java:145)
          com.sun.faces.extensions.avatar.application.DeferredStateManager.saveView(DeferredStateManager.java:69)
          com.sun.faces.application.ViewHandlerImpl$WriteBehindStateWriter.flushToWriter(ViewHandlerImpl.java:930)
          com.sun.faces.application.ViewHandlerImpl.renderView(ViewHandlerImpl.java:205)
          com.icesoft.faces.application.D2DViewHandler.renderView(D2DViewHandler.java:145)
          org.icefaces.netbeans.rave.web.ui.appbase.faces.ViewHandlerImpl.renderView(ViewHandlerImpl.java:296)
          com.sun.faces.lifecycle.RenderResponsePhase.execute(RenderResponsePhase.java:110)
          com.sun.faces.lifecycle.Phase.doPhase(Phase.java:100)
          com.sun.faces.lifecycle.LifecycleImpl.render(LifecycleImpl.java:139)
          com.sun.faces.extensions.avatar.lifecycle.PartialTraversalLifecycle.render(PartialTraversalLifecycle.java:106)
          javax.faces.webapp.FacesServlet.service(FacesServlet.java:266)

          Show
          Ted Goddard added a comment - Stack excerpt from the forum post. com.icesoft.faces.application.ViewRootStateManagerImpl.saveView(ViewRootStateManagerImpl.java:145) com.sun.faces.extensions.avatar.application.DeferredStateManager.saveView(DeferredStateManager.java:69) com.sun.faces.application.ViewHandlerImpl$WriteBehindStateWriter.flushToWriter(ViewHandlerImpl.java:930) com.sun.faces.application.ViewHandlerImpl.renderView(ViewHandlerImpl.java:205) com.icesoft.faces.application.D2DViewHandler.renderView(D2DViewHandler.java:145) org.icefaces.netbeans.rave.web.ui.appbase.faces.ViewHandlerImpl.renderView(ViewHandlerImpl.java:296) com.sun.faces.lifecycle.RenderResponsePhase.execute(RenderResponsePhase.java:110) com.sun.faces.lifecycle.Phase.doPhase(Phase.java:100) com.sun.faces.lifecycle.LifecycleImpl.render(LifecycleImpl.java:139) com.sun.faces.extensions.avatar.lifecycle.PartialTraversalLifecycle.render(PartialTraversalLifecycle.java:106) javax.faces.webapp.FacesServlet.service(FacesServlet.java:266)
          Hide
          Ted Goddard added a comment -

          Greg, it looks like our statemanager should not be invoked on that particular view. How do we configure this case?

          Show
          Ted Goddard added a comment - Greg, it looks like our statemanager should not be invoked on that particular view. How do we configure this case?
          Ted Goddard made changes -
          Assignee Ted Goddard [ ted.goddard ] Greg Dick [ greg.dick ]
          Repository Revision Date User Message
          ICEsoft Public SVN Repository #18658 Wed Mar 25 16:54:37 MDT 2009 greg.dick ICE-4257 In the event that the FacesContext isn't one of ours, instead of throwing an exception, delegate.
          Files Changed
          Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/application/SingleCopyStateManagerImpl.java
          Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/application/ViewRootStateManagerImpl.java
          Hide
          Greg Dick added a comment -

          The original implementation didn't handle doing delegation. One problem encountered was that the default faces-config file included in ICEFaces contains an ICEFaces implementation definition. If the user defines a state saving implementation in the project specific faces-config.xml file the question is how to get it used, since the instance is always constructed with a delegate (our defined by default instance). The code now checks to see if the delegate is a non-icefaces implementation and only delegates if this is true.

          Show
          Greg Dick added a comment - The original implementation didn't handle doing delegation. One problem encountered was that the default faces-config file included in ICEFaces contains an ICEFaces implementation definition. If the user defines a state saving implementation in the project specific faces-config.xml file the question is how to get it used, since the instance is always constructed with a delegate (our defined by default instance). The code now checks to see if the delegate is a non-icefaces implementation and only delegates if this is true.
          Greg Dick made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Fix Version/s 1.8.1 [ 10170 ]
          Resolution Fixed [ 1 ]
          Ken Fyten made changes -
          Status Resolved [ 5 ] Closed [ 6 ]

            People

            • Assignee:
              Greg Dick
              Reporter:
              Frank Ye
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: