ICEfaces
  1. ICEfaces
  2. ICE-3732

Optimise BridgeFacesContext.applyBrowserDOMChanges()

          Details

          • Type: Improvement Improvement
          • Status: Closed
          • Priority: Major Major
          • Resolution: Invalid
          • Affects Version/s: 1.8DR#1
          • Fix Version/s: None
          • Component/s: Framework
          • Labels:
            None
          • Environment:
            All

            Description

            BridgeFacesContext.applyBrowserDOMChanges() does three iterations through the whole DOM tree, first looking for "input", then "textarea", then "select" elements. This should be changed to be a single iteration. This would entail inlining getElementsByTagName(-), which is good, because it makes a DeepNodeListImpl, which employs a lot of checks to see if the document has changed, which is pointless, since we're not changing it.

              Issue Links

              blocks

              Improvement - An improvement or enhancement to an existing feature or task. ICE-3082 CPU performance/efficiency

              • Major - Major loss of function.
              • Closed

                Activity

                Ascending order - Click to sort in descending order
                Mark Collette created issue -
                Mark Collette made changes -
                Field Original Value New Value
                Link This issue blocks ICE-3082 [ ICE-3082 ]
                Hide
                Permalink
                Ken Fyten added a comment -

                Marking as Closed / Invalid as part of legacy ICEfaces 1.x, 2.x JIRA cleanup.

                Note: This issue may be resolved in a newer ICEfaces release, available here: http://www.icesoft.org/java/downloads/icefaces-downloads.jsf

                If the issue persists with the current ICEfaces release, please create a new JIRA for it.

                Show
                Ken Fyten added a comment - Marking as Closed / Invalid as part of legacy ICEfaces 1.x, 2.x JIRA cleanup. Note: This issue may be resolved in a newer ICEfaces release, available here: http://www.icesoft.org/java/downloads/icefaces-downloads.jsf If the issue persists with the current ICEfaces release, please create a new JIRA for it.
                Ken Fyten made changes -
                Status Open [ 1 ] Closed [ 6 ]
                Resolution Invalid [ 6 ]

                  People

                  • Assignee:
                    Unassigned
                    Reporter:
                    Mark Collette
                  • Votes:
                    0 Vote for this issue
                    Watchers:
                    1 Start watching this issue

                    Dates

                    • Created:
                      Updated:
                      Resolved: