Details
-
Type:
New Feature
-
Status: Closed
-
Priority:
Major
-
Resolution: Duplicate
-
Affects Version/s: 1.8DR#1
-
Fix Version/s: None
-
Component/s: ICE-Components
-
Labels:None
-
Environment:JSF 1.2
Description
In JSF 1.2_05+ there's a feature where components keep track of which attributes have been set, either from the setter method being called, or a ValueExpression having been set. This is used to limit which pass-through attributes are attempted to be rendered. It would be nice if we could make use of this feature, or if not, implement an equivalent solution.
Issue Links
Activity
We'll have to augment ICEfaces to take advantage of the functionality in ICE-3757. This will probably involve profiling the cost of using attributesThatAreSet, to see what we can avoid doing in our code, given access to the list of set attributes.
So that we continue to work with other JSF implementations, and pre-patched versions of JSF Mojarra, we'll need a strategy of detecting if this new feature is enabled. We might just instantiate a component, set an attribute, and then get its attributesThatAreSet, and see if the list is non-null, and contains that attribute name.
Show
Mark Collette
added a comment - We'll have to augment ICEfaces to take advantage of the functionality in ICE-3757. This will probably involve profiling the cost of using attributesThatAreSet, to see what we can avoid doing in our code, given access to the list of set attributes.
So that we continue to work with other JSF implementations, and pre-patched versions of JSF Mojarra, we'll need a strategy of detecting if this new feature is enabled. We might just instantiate a component, set an attribute, and then get its attributesThatAreSet, and see if the list is non-null, and contains that attribute name.
| Field | Original Value | New Value |
|---|---|---|
| Link | This issue depends on ICE-3757 [ ICE-3757 ] |
| Assignee | Mark Collette [ mark.collette ] |
Ran across a note to try using this feature for isRendered(), and potentially all getters, to avoid accessing the ValueBindings.
Show
Mark Collette
added a comment - Ran across a note to try using this feature for isRendered(), and potentially all getters, to avoid accessing the ValueBindings.
| Link | This issue is duplicated by ICE-6945 [ ICE-6945 ] |
| Status | Open [ 1 ] | Closed [ 6 ] |
| Resolution | Duplicate [ 3 ] |
It would be nice if the implementation was optimised enough, that we could avoid, or speed up the accessing of ValueBindings that haven't be set, in getter methods.