ICEfaces
  1. ICEfaces
  2. ICE-3713

CLONE -Component attribute state not retained (even without webflow being active)

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Duplicate
    • Affects Version/s: 1.7.2
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None
    • Environment:
      ICEFaces 1.7.2 (comps; core;facelets)
      JSF RI 1.2_09 (problem exists with older version as well)

      Description

      There is also a problem with the components state when working without weblow.

      Test page setup:
      [code]
      <ice:outputText value="test"/>
      <ice:commandButton actionListener="#{bean.toggle}"/>
      [/code]

      ActionListener setup:
      [code]
      public void action(ActionEvent actionEvent) {
      for (UIComponent child : actionEvent.getComponent().getParent()
      .getChildren()) {
      if (child instanceof HtmlOutputText) {
      HtmlOutputText output = ((HtmlOutputText) child);
      if (output.isRendered()) {
      output.setRendered(false);
      } else {
      output.setRendered(true);
      }
      }
      }
      }
      [/code]

      The action listener will lookup the 'outputText' and toggle its rendered attribute.
      The rendered attribute is by default 'true'.

      Failing test:

      1. Open the page (output text is rendered = OK)
      2. Click the button (output text gets hidden = OK -> implemented toggle behavior in action listener)
      3. Click the button again (output text gets shown = OK -> implemented toggle behavior in action listener)
      4. Click the button once more (output text gets hidden = OK ...........)
      5. Now, hit F5 in browser
      6. Output text gets shown (NOT OK !)

      The problem here, is once again, related to setting the viewroot to NULL.
      This is what happens:

      1. I hit F5, browser sends GET
      2. ICEFaces discovers this is a GET and sets viewroot to null
      3. A clean viewroot is created by JSF
      4. Components are getting bound by facelets, but there is nowhere state injected

      NOTE: it works when BINDING the component to the action instead of looking it up via the component tree; when doing this the component instance is retained on the action.
      The facelets componentHandler will (instead of creating a new instance) execute the binding VE pointing to the action containing the component instance.
      This way the state is reatained and it appears to be working.

        Issue Links

          Activity

          Errorken Errorken created issue -
          Errorken Errorken made changes -
          Field Original Value New Value
          Link This issue depends on ICE-3664 [ ICE-3664 ]
          Hide
          Errorken Errorken added a comment -

          >Mark Collette [29/Oct/08 05:58 PM]
          >A much simpler solution is to use a ValueBinding for the rendered attribute, and just toggle the boolean in your bean.
          >I don't believe that stock JSF would persist the component state through an F5 refresh, so it's not something ICEfaces should do either.

          Value binding would break the entire goal of JSF component binding.

          Fact is that at the moment, JSF retains state whenever the request is marked as a 'postback'.
          Webflows 'get' (in the post/redirect/get) must be treated as a postback (its not a 'post' but it serves the same goal - as state must be retained)

          Therefore webflow adds the 'javax.viewstate' request parameter which serves, according to the JSF spec, to indicate if a request is a postback.
          I feel that ICEFaces should at least respect this and see if the request is a postback BEFORE setting the viewroot to NULL
          Just assuming a GET is by default not a postback is just wrong.

          This could easily be fixed in ICEFaces just by checking if its a postback:

          if(!postback)
          viewroot = null;

          Would this be possible?

          Show
          Errorken Errorken added a comment - >Mark Collette [29/Oct/08 05:58 PM] >A much simpler solution is to use a ValueBinding for the rendered attribute, and just toggle the boolean in your bean. >I don't believe that stock JSF would persist the component state through an F5 refresh, so it's not something ICEfaces should do either. Value binding would break the entire goal of JSF component binding. Fact is that at the moment, JSF retains state whenever the request is marked as a 'postback'. Webflows 'get' (in the post/redirect/get) must be treated as a postback (its not a 'post' but it serves the same goal - as state must be retained) Therefore webflow adds the 'javax.viewstate' request parameter which serves, according to the JSF spec, to indicate if a request is a postback. I feel that ICEFaces should at least respect this and see if the request is a postback BEFORE setting the viewroot to NULL Just assuming a GET is by default not a postback is just wrong. This could easily be fixed in ICEFaces just by checking if its a postback: if(!postback) viewroot = null; Would this be possible?
          Hide
          Deryk Sinotte added a comment -

          Assigning to Mircea for initial analysis.

          Show
          Deryk Sinotte added a comment - Assigning to Mircea for initial analysis.
          Deryk Sinotte made changes -
          Assignee Mircea Toma [ mircea.toma ]
          Hide
          Mircea Toma added a comment -

          Preserving the ViewRoot on page reload was fixed in ICE-3691

          Show
          Mircea Toma added a comment - Preserving the ViewRoot on page reload was fixed in ICE-3691
          Mircea Toma made changes -
          Link This issue duplicates ICE-3691 [ ICE-3691 ]
          Mircea Toma made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Resolution Duplicate [ 3 ]
          Hide
          Errorken Errorken added a comment -

          Can you explain how you fixed this ?
          I looked at the changes you made in ICE-3691 but I cannot conduct that this issue here would be fixed...
          Thanks.

          Show
          Errorken Errorken added a comment - Can you explain how you fixed this ? I looked at the changes you made in ICE-3691 but I cannot conduct that this issue here would be fixed... Thanks.
          Ken Fyten made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Assignee Mircea Toma [ mircea.toma ]

            People

            • Assignee:
              Unassigned
              Reporter:
              Errorken Errorken
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: