ICEfaces
  1. ICEfaces
  2. ICE-3527

handle outcomes of Spring Web Flow 2 flows

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.7.1
    • Fix Version/s: 1.8.1
    • Component/s: None
    • Labels:
      None
    • Environment:
      ICEfaces, Spring Web Flow

      Description


      The result of Spring Web Flow flows was not implemented. In the case of the swf-booking-icefaces demo, this caused the booking confirmation to fail.

        Activity

        Repository Revision Date User Message
        ICEsoft Public SVN Repository #17567 Fri Sep 12 15:01:03 MDT 2008 ted.goddard perform redirection depending on flow result (ICE-3527)
        Files Changed
        Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/webapp/http/core/SwfLifecycleExecutor.java
        Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/webapp/http/core/LifecycleExecutor.java
        Commit graph DEL /icefaces/trunk/icefaces/lib/org.springframework.webflow-2.0.1.RELEASE.jar
        Commit graph ADD /icefaces/trunk/icefaces/lib/org.springframework.web-2.5.4.A.jar
        Commit graph DEL /icefaces/trunk/icefaces/lib/spring-webflow.jar
        Commit graph ADD /icefaces/trunk/icefaces/lib/org.springframework.binding-2.0.3.RELEASE.jar
        Commit graph ADD /icefaces/trunk/icefaces/lib/org.springframework.core-2.5.4.A.jar
        Commit graph DEL /icefaces/trunk/icefaces/lib/spring-context.jar
        Commit graph ADD /icefaces/trunk/icefaces/lib/org.springframework.context-2.5.4.A.jar
        Commit graph ADD /icefaces/trunk/icefaces/lib/org.springframework.beans-2.5.4.A.jar
        Commit graph MODIFY /icefaces/trunk/icefaces/lib/versions-licenses.html
        Commit graph DEL /icefaces/trunk/icefaces/lib/spring-core.jar
        Commit graph DEL /icefaces/trunk/icefaces/lib/spring-web.jar
        Commit graph DEL /icefaces/trunk/icefaces/lib/spring-beans.jar
        Commit graph ADD /icefaces/trunk/icefaces/lib/org.springframework.webflow-2.0.3.RELEASE.jar
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #17568 Fri Sep 12 15:04:19 MDT 2008 ted.goddard perform redirection depending on flow result (ICE-3527)
        Files Changed
        Commit graph DEL /icefaces/branches/icefaces-1.7/icefaces/lib/spring-webflow.jar
        Commit graph DEL /icefaces/branches/icefaces-1.7/icefaces/lib/spring-web.jar
        Commit graph DEL /icefaces/branches/icefaces-1.7/icefaces/lib/spring-core.jar
        Commit graph DEL /icefaces/branches/icefaces-1.7/icefaces/lib/spring-context.jar
        Commit graph MODIFY /icefaces/branches/icefaces-1.7/icefaces/core/src/com/icesoft/faces/webapp/http/core/LifecycleExecutor.java
        Commit graph MODIFY /icefaces/branches/icefaces-1.7/icefaces/core/src/com/icesoft/faces/webapp/http/core/SwfLifecycleExecutor.java
        Commit graph MODIFY /icefaces/branches/icefaces-1.7/icefaces/lib/versions-licenses.html
        Commit graph DEL /icefaces/branches/icefaces-1.7/icefaces/lib/spring-beans.jar
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #17569 Fri Sep 12 15:06:06 MDT 2008 ted.goddard updating to spring web flow 2.0.3 jars (ICE-3527)
        Files Changed
        Commit graph ADD /icefaces/branches/icefaces-1.7/icefaces/lib/org.springframework.webflow-2.0.3.RELEASE.jar
        Commit graph ADD /icefaces/branches/icefaces-1.7/icefaces/lib/org.springframework.core-2.5.4.A.jar
        Commit graph DEL /icefaces/branches/icefaces-1.7/icefaces/lib/org.springframework.webflow-2.0.1.RELEASE.jar
        Commit graph ADD /icefaces/branches/icefaces-1.7/icefaces/lib/org.springframework.context-2.5.4.A.jar
        Commit graph ADD /icefaces/branches/icefaces-1.7/icefaces/lib/org.springframework.beans-2.5.4.A.jar
        Commit graph ADD /icefaces/branches/icefaces-1.7/icefaces/lib/org.springframework.web-2.5.4.A.jar
        Commit graph ADD /icefaces/branches/icefaces-1.7/icefaces/lib/org.springframework.binding-2.0.3.RELEASE.jar
        Ted Goddard created issue -
        Hide
        Greg Dick added a comment -

        I believe this is fixed in 1.8.1. As a part of fixing ICE-4186, I fixed a large number of navigation outcome paths in SwfLifecycleExecutor.java. There were several issues with this class including the improper use of response.sendRedirect(location) (which does not work with the ICEFaces bridge) as well as simply commented out sections of code to handle various cases.

        At this time the swf-booking-faces sample application works identically to the Spring booking-faces application (assuming the always-redirect settings are the same)

        Show
        Greg Dick added a comment - I believe this is fixed in 1.8.1. As a part of fixing ICE-4186 , I fixed a large number of navigation outcome paths in SwfLifecycleExecutor.java. There were several issues with this class including the improper use of response.sendRedirect(location) (which does not work with the ICEFaces bridge) as well as simply commented out sections of code to handle various cases. At this time the swf-booking-faces sample application works identically to the Spring booking-faces application (assuming the always-redirect settings are the same)
        Greg Dick made changes -
        Field Original Value New Value
        Status Open [ 1 ] Resolved [ 5 ]
        Fix Version/s 1.8.1 [ 10170 ]
        Resolution Fixed [ 1 ]
        Ken Fyten made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Unassigned
            Reporter:
            Ted Goddard
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: