Details
-
Type: Bug
-
Status: Closed
-
Priority: Minor
-
Resolution: Fixed
-
Affects Version/s: 1.7.1
-
Fix Version/s: 1.7.2
-
Component/s: Documentation, Framework
-
Labels:None
-
Environment:all
-
Affects:Documentation (User Guide, Ref. Guide, etc.)
-
Workaround Exists:Yes
-
Workaround Description:Include or remove the context parameter entirely to activate/deactivate it.
Description
We use this as a marker to include the openajax.js library as one of the scripts on the page. The code looks like this:
if (context.getExternalContext().getInitParameter(D2DViewHandler.INCLUDE_OPEN_AJAX_HUB) != null) {
libs.add("/xmlhttp/openajax.js");
}
This might be slightly problematic since the code simply looks for the value to be non-null. Which means that setting to true/false makes no difference. The only way to turn it off is to remove the entry. I think we should change the behaviour and then document it as a true/false setting.
if (context.getExternalContext().getInitParameter(D2DViewHandler.INCLUDE_OPEN_AJAX_HUB) != null) {
libs.add("/xmlhttp/openajax.js");
}
This might be slightly problematic since the code simply looks for the value to be non-null. Which means that setting to true/false makes no difference. The only way to turn it off is to remove the entry. I think we should change the behaviour and then document it as a true/false setting.
Activity
Deryk Sinotte
created issue -
Deryk Sinotte
made changes -
Field | Original Value | New Value |
---|---|---|
Fix Version/s | 1.7.2RC1 [ 10140 ] | |
Affects | [Documentation (User Guide, Ref. Guide, etc.)] | |
Assignee Priority | P1 | |
Affects Version/s | 1.7.1 [ 10122 ] | |
Assignee | Mircea Toma [ mircea.toma ] | |
Priority | Major [ 3 ] | Minor [ 4 ] |
Repository | Revision | Date | User | Message |
ICEsoft Public SVN Repository | #17522 | Tue Sep 09 04:03:38 MDT 2008 | mircea.toma | |
Files Changed | ||||
MODIFY
/icefaces/trunk/icefaces/core/src/com/icesoft/faces/context/DOMResponseWriter.java
MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/application/D2DViewHandler.java |
Repository | Revision | Date | User | Message |
ICEsoft Public SVN Repository | #17523 | Tue Sep 09 04:04:22 MDT 2008 | mircea.toma | |
Files Changed | ||||
MODIFY
/icefaces/branches/icefaces-1.7/icefaces/core/src/com/icesoft/faces/context/DOMResponseWriter.java
MODIFY /icefaces/branches/icefaces-1.7/icefaces/core/src/com/icesoft/faces/application/D2DViewHandler.java |
Mircea Toma
made changes -
Status | Open [ 1 ] | Resolved [ 5 ] |
Resolution | Fixed [ 1 ] |
Ken Fyten
made changes -
Fix Version/s | 1.7.2 [ 10130 ] | |
Fix Version/s | 1.7.2RC1 [ 10140 ] |
Ken Fyten
made changes -
Status | Resolved [ 5 ] | Closed [ 6 ] |
Assignee Priority | P1 | |
Assignee | Mircea Toma [ mircea.toma ] |
Enable OpenAJAX integration only when context parameter is specifically set to 'true'.