ICEfaces
  1. ICEfaces
  2. ICE-3488

Possible null value in group set of GroupAsyncRenderer

          Details

          • Type: Bug Bug
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 1.7.1
          • Fix Version/s: 1.7.2
          • Component/s: Framework
          • Labels:
            None
          • Environment:
            ICEfaces 1.7.1

            Description

            When adding a session using the SessionRenderer.addCurrentSession(String) method, it's possible that a WeakReference containing null is added to the GroupAsyncRenderer's group set due to an HttpSession not being there yet. When requesting a render the null value is not an instance of Renderable nor HttpSession ending up at the final check to see if it's a PortletSession causing the ClassNotFoundException to be thrown in a non-portal environment as mentioned in the forum.

              Activity

              Repository Revision Date User Message
              ICEsoft Public SVN Repository #17528 Tue Sep 09 10:48:30 MDT 2008 jack.van.ooststroom Fixed JIRA ICE-3488 : Possible null value in group set of GroupAsyncRenderer; WeakReference objects can point to null when sessions are cleaned up, these WeakReference objects are now removed from the Set.
              Files Changed
              Commit graph MODIFY /icefaces/branches/icefaces-1.7/icefaces/core/src/com/icesoft/faces/async/render/GroupAsyncRenderer.java
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #17527 Tue Sep 09 10:48:03 MDT 2008 jack.van.ooststroom Fixed JIRA ICE-3488 : Possible null value in group set of GroupAsyncRenderer; WeakReference objects can point to null when sessions are cleaned up, these WeakReference objects are now removed from the Set.
              Files Changed
              Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/async/render/GroupAsyncRenderer.java
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #17512 Mon Sep 08 13:33:38 MDT 2008 jack.van.ooststroom Fixed JIRA ICE-3488 : Possible null value in group set of GroupAsyncRenderer; Changed the strategy: no session is created if there was no session, instead an IllegalStateException is thrown as addCurrentSession should always be called from threads executing the JSF lifecycle.
              Files Changed
              Commit graph MODIFY /icefaces/branches/icefaces-1.7/icefaces/core/src/org/icefaces/x/core/push/SessionRenderer.java
              Commit graph MODIFY /icefaces/branches/icefaces-1.7/icefaces/core/src/com/icesoft/faces/async/render/GroupAsyncRenderer.java
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #17511 Mon Sep 08 13:32:45 MDT 2008 jack.van.ooststroom Fixed JIRA ICE-3488 : Possible null value in group set of GroupAsyncRenderer; Changed the strategy: no session is created if there was no session, instead an IllegalStateException is thrown as addCurrentSession should always be called from threads executing the JSF lifecycle.
              Files Changed
              Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/async/render/GroupAsyncRenderer.java
              Commit graph MODIFY /icefaces/trunk/icefaces/core/src/org/icefaces/x/core/push/SessionRenderer.java
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #17508 Fri Sep 05 16:16:27 MDT 2008 jack.van.ooststroom Fixed JIRA ICE-3488 : Possible null value in group set of GroupAsyncRenderer
              Files Changed
              Commit graph MODIFY /icefaces/branches/icefaces-1.7/icefaces/core/src/com/icesoft/faces/async/render/GroupAsyncRenderer.java
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #17507 Fri Sep 05 16:15:32 MDT 2008 jack.van.ooststroom Fixed JIRA ICE-3488 : Possible null value in group set of GroupAsyncRenderer
              Files Changed
              Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/async/render/GroupAsyncRenderer.java

                People

                • Assignee:
                  Unassigned
                  Reporter:
                  Jack Van Ooststroom
                • Votes:
                  1 Vote for this issue
                  Watchers:
                  1 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: