Details
Bug
Major
Description
When adding a session using the SessionRenderer.addCurrentSession(String) method, it's possible that a WeakReference containing null is added to the GroupAsyncRenderer's group set due to an HttpSession not being there yet. When requesting a render the null value is not an instance of Renderable nor HttpSession ending up at the final check to see if it's a PortletSession causing the ClassNotFoundException to be thrown in a non-portal environment as mentioned in the forum.
Activity
| Repository | Revision | Date | User | Message |
| ICEsoft Public SVN Repository | #17507 | Fri Sep 05 16:15:32 MDT 2008 | jack.van.ooststroom | Fixed JIRA |
| Files Changed | ||||
MODIFY
/icefaces/trunk/icefaces/core/src/com/icesoft/faces/async/render/GroupAsyncRenderer.java
|
| Repository | Revision | Date | User | Message |
| ICEsoft Public SVN Repository | #17508 | Fri Sep 05 16:16:27 MDT 2008 | jack.van.ooststroom | Fixed JIRA |
| Files Changed | ||||
|
MODIFY
/icefaces/branches/icefaces-1.7/icefaces/core/src/com/icesoft/faces/async/render/GroupAsyncRenderer.java
|
| Field | Original Value | New Value |
|---|---|---|
| Assignee | Jack Van Ooststroom [ jack.van.ooststroom ] |
| Status | Open [ 1 ] | In Progress [ 3 ] |
| Fix Version/s | 1.7.2 [ 10130 ] |
Now when invoking addCurrentSession(String) a new session is created if there is no current session yet. Marking this one as FIXED.
Show
Jack Van Ooststroom
added a comment - Now when invoking addCurrentSession(String) a new session is created if there is no current session yet. Marking this one as FIXED.
| Status | In Progress [ 3 ] | Resolved [ 5 ] |
| Resolution | Fixed [ 1 ] |
| Fix Version/s | 1.7.2RC1 [ 10140 ] | |
| Fix Version/s | 1.7.2 [ 10130 ] |
| Resolution | Fixed [ 1 ] | |
| Status | Resolved [ 5 ] | Reopened [ 4 ] |
| Assignee Priority | P1 |
| Repository | Revision | Date | User | Message |
| ICEsoft Public SVN Repository | #17511 | Mon Sep 08 13:32:45 MDT 2008 | jack.van.ooststroom | Fixed JIRA |
| Files Changed | ||||
|
MODIFY
/icefaces/trunk/icefaces/core/src/com/icesoft/faces/async/render/GroupAsyncRenderer.java
MODIFY
/icefaces/trunk/icefaces/core/src/org/icefaces/x/core/push/SessionRenderer.java
|
| Repository | Revision | Date | User | Message |
| ICEsoft Public SVN Repository | #17512 | Mon Sep 08 13:33:38 MDT 2008 | jack.van.ooststroom | Fixed JIRA |
| Files Changed | ||||
|
MODIFY
/icefaces/branches/icefaces-1.7/icefaces/core/src/org/icefaces/x/core/push/SessionRenderer.java
MODIFY
/icefaces/branches/icefaces-1.7/icefaces/core/src/com/icesoft/faces/async/render/GroupAsyncRenderer.java
|
Changed the strategy a bit. A new session is not created anymore when a session does not exist during the addCurrentSession invocation. Instead an IllegalStateException is thrown as the addCurrentSession method should always be called from threads executing the JSF lifecycle. Additionally, warn level messages are logged when either addCurrentSession or removeCurrentSession is invoked and no session exists. Marking this one as FIXED again.
Show
Jack Van Ooststroom
added a comment - Changed the strategy a bit. A new session is not created anymore when a session does not exist during the addCurrentSession invocation. Instead an IllegalStateException is thrown as the addCurrentSession method should always be called from threads executing the JSF lifecycle. Additionally, warn level messages are logged when either addCurrentSession or removeCurrentSession is invoked and no session exists. Marking this one as FIXED again.
| Status | Reopened [ 4 ] | Resolved [ 5 ] |
| Resolution | Fixed [ 1 ] |
| Repository | Revision | Date | User | Message |
| ICEsoft Public SVN Repository | #17527 | Tue Sep 09 10:48:03 MDT 2008 | jack.van.ooststroom | Fixed JIRA |
| Files Changed | ||||
|
MODIFY
/icefaces/trunk/icefaces/core/src/com/icesoft/faces/async/render/GroupAsyncRenderer.java
|
| Repository | Revision | Date | User | Message |
| ICEsoft Public SVN Repository | #17528 | Tue Sep 09 10:48:30 MDT 2008 | jack.van.ooststroom | Fixed JIRA |
| Files Changed | ||||
|
MODIFY
/icefaces/branches/icefaces-1.7/icefaces/core/src/com/icesoft/faces/async/render/GroupAsyncRenderer.java
|
Reopening once again as the combination of CopyOnWriteArraySet and WeakReferences does not result in the WeakReferences being cleaned up automatically.
Show
Jack Van Ooststroom
added a comment - Reopening once again as the combination of CopyOnWriteArraySet and WeakReferences does not result in the WeakReferences being cleaned up automatically.
| Resolution | Fixed [ 1 ] | |
| Status | Resolved [ 5 ] | Reopened [ 4 ] |
It was still possible getting null-values as after session clean-up the contained WeakReferences will point to null. They are not automatically removed from the CopyOnWriteArraySet. Therefore, on each render call whenever a WeakReference is encountered that points to null, it is removed from the Set. Later on we could consider a more pro-active solution to clean the Set of these kind of WeakReferences. Marking this one as FIXED once again.
Show
Jack Van Ooststroom
added a comment - It was still possible getting null-values as after session clean-up the contained WeakReferences will point to null. They are not automatically removed from the CopyOnWriteArraySet. Therefore, on each render call whenever a WeakReference is encountered that points to null, it is removed from the Set. Later on we could consider a more pro-active solution to clean the Set of these kind of WeakReferences. Marking this one as FIXED once again.
| Status | Reopened [ 4 ] | Resolved [ 5 ] |
| Resolution | Fixed [ 1 ] |
| Fix Version/s | 1.7.2 [ 10130 ] | |
| Fix Version/s | 1.7.2RC1 [ 10140 ] |
| Status | Resolved [ 5 ] | Closed [ 6 ] |
| Assignee Priority | P1 | |
| Assignee | Jack Van Ooststroom [ jack.van.ooststroom ] |
Changed Fix Version(s) to 1.7.2