ICEfaces
  1. ICEfaces
  2. ICE-3440

RowSelector deselection needlessly accessing all rows

          Details

          • Type: Bug Bug
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 1.7.1
          • Fix Version/s: 1.7.2
          • Component/s: ICE-Components
          • Labels:
            None
          • Environment:
            All

            Description

            Back in ICE-2024, we made it so that for single selection mode, we'd deselect every other row of a dataTable, when a new row had been selected. This breaks paged data models which lazily load the current page of row data. There's some example code in ICE-3380 to demonstrate this.

              Activity

              Ascending order - Click to sort in descending order
              Mark Collette created issue -
              Mark Collette made changes -
              Field Original Value New Value
              Fix Version/s 1.7.2 [ 10130 ]
              Assignee Mark Collette [ mark.collette ]
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #17404 Fri Aug 22 10:59:50 MDT 2008 mark.collette ICE-3440 : RowSelector deselection needlessly accessing all rows
              Files Changed
              Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/ext/RowSelector.java
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #17405 Fri Aug 22 11:00:54 MDT 2008 mark.collette ICE-3440 : RowSelector deselection needlessly accessing all rows
              Files Changed
              Commit graph MODIFY /icefaces/branches/icefaces-1.7/icefaces/component/src/com/icesoft/faces/component/ext/RowSelector.java
              Hide
              Permalink
              Mark Collette added a comment -

              Now, for single selection, we just deselect the last clicked row, if it was a different row than the current one.

              It should be noted, that the previous behaviour was partially to cover one case of the application switching the RowSelector from multiple selection to single selection. Since it didn't cover all of the cases for that scenario anyway, it's best for the application to take responsibility for any necessary deselection in that transition.

              TRUNK
              Subversion 17404
              ICEfaces 1.7 branch
              Subversion 17405
              icefaces\component\src\com\icesoft\faces\component\ext\RowSelector.java

              Show
              Mark Collette added a comment - Now, for single selection, we just deselect the last clicked row, if it was a different row than the current one. It should be noted, that the previous behaviour was partially to cover one case of the application switching the RowSelector from multiple selection to single selection. Since it didn't cover all of the cases for that scenario anyway, it's best for the application to take responsibility for any necessary deselection in that transition. TRUNK Subversion 17404 ICEfaces 1.7 branch Subversion 17405 icefaces\component\src\com\icesoft\faces\component\ext\RowSelector.java
              Mark Collette made changes -
              Status Open [ 1 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Mark Collette made changes -
              Link This issue blocks ICE-2179 [ ICE-2179 ]
              Mark Collette made changes -
              Link This issue blocks ICE-2179 [ ICE-2179 ]
              Mark Collette made changes -
              Link This issue is duplicated by ICE-2179 [ ICE-2179 ]
              Ken Fyten made changes -
              Fix Version/s 1.7.2RC1 [ 10140 ]
              Fix Version/s 1.7.2 [ 10130 ]
              Ken Fyten made changes -
              Fix Version/s 1.7.2 [ 10130 ]
              Fix Version/s 1.7.2RC1 [ 10140 ]
              Ken Fyten made changes -
              Status Resolved [ 5 ] Closed [ 6 ]
              Assignee Mark Collette [ mark.collette ]

                People

                • Assignee:
                  Unassigned
                  Reporter:
                  Mark Collette
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  0 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: