ICEfaces
  1. ICEfaces
  2. ICE-3366

ice:columns does not implement the resizable feature

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.7.1
    • Fix Version/s: 1.8.2-EE-GA_P01, 1.8.3
    • Component/s: ICE-Components
    • Labels:
      None
    • Environment:
      Windows XP SP2
      Java(TM) SE Runtime Environment (build 1.6.0_04-b12)
      ICEfaces 1.7.1
      Build number: 6
      Revision: 16923

      Description

      The resizable attribute of the ice:datatable does not render resizable columns generated by the ice:columns tag.
      Reason: The processUIColumnsHeader method of com.icesoft.faces.component.ext.renderkit.TableRenderer does not implement the adding of resizehandlers.

      For an example see the forum-reference.

        Activity

        Hide
        Joanne Bai added a comment -

        Verified with success on ICEfaces-ee-1.8.2 revision 20900
        (Tested on Tomcat 6 + FF3.5, Opera 10.1, and IE6,7,8)

        Test app is available at \repo\qa\trunk\Regression\ICE-3366

        Show
        Joanne Bai added a comment - Verified with success on ICEfaces-ee-1.8.2 revision 20900 (Tested on Tomcat 6 + FF3.5, Opera 10.1, and IE6,7,8) Test app is available at \repo\qa\trunk\Regression\ ICE-3366
        Hide
        Adnan Durrani added a comment -

        Fix for requirement 2.

        There already is an attribute which submits modified widths on resize event, which is called "clientOnly", so I have just changed the renderer to make a use of it for columns component. So when <ice:dataTable clientOnly="true"> the columns widths will be persisted.

        Trunk:
        Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\ext\renderkit\TableRenderer.java
        Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\ext\renderkit\TableRenderer.java
        Completed: At revision: 20892

        EE:
        Modified: D:\work\development\head\svn\ossrepo\icefaces-ee\branches\icefaces-ee-1.8.2\icefaces\component\src\com\icesoft\faces\component\ext\renderkit\TableRenderer.java
        Sending content: D:\work\development\head\svn\ossrepo\icefaces-ee\branches\icefaces-ee-1.8.2\icefaces\component\src\com\icesoft\faces\component\ext\renderkit\TableRenderer.java
        Completed: At revision: 20893

        Show
        Adnan Durrani added a comment - Fix for requirement 2. There already is an attribute which submits modified widths on resize event, which is called "clientOnly", so I have just changed the renderer to make a use of it for columns component. So when <ice:dataTable clientOnly="true"> the columns widths will be persisted. Trunk: Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\ext\renderkit\TableRenderer.java Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\ext\renderkit\TableRenderer.java Completed: At revision: 20892 EE: Modified: D:\work\development\head\svn\ossrepo\icefaces-ee\branches\icefaces-ee-1.8.2\icefaces\component\src\com\icesoft\faces\component\ext\renderkit\TableRenderer.java Sending content: D:\work\development\head\svn\ossrepo\icefaces-ee\branches\icefaces-ee-1.8.2\icefaces\component\src\com\icesoft\faces\component\ext\renderkit\TableRenderer.java Completed: At revision: 20893
        Hide
        Adnan Durrani added a comment - - edited

        EE
        Modified: D:\work\development\head\svn\ossrepo\icefaces-ee\branches\icefaces-ee-1.8.2\icefaces\component\src\com\icesoft\faces\component\ext\renderkit\TableRenderer.java
        Sending content: D:\work\development\head\svn\ossrepo\icefaces-ee\branches\icefaces-ee-1.8.2\icefaces\component\src\com\icesoft\faces\component\ext\renderkit\TableRenderer.java
        Completed: At revision: 20890

        Show
        Adnan Durrani added a comment - - edited EE Modified: D:\work\development\head\svn\ossrepo\icefaces-ee\branches\icefaces-ee-1.8.2\icefaces\component\src\com\icesoft\faces\component\ext\renderkit\TableRenderer.java Sending content: D:\work\development\head\svn\ossrepo\icefaces-ee\branches\icefaces-ee-1.8.2\icefaces\component\src\com\icesoft\faces\component\ext\renderkit\TableRenderer.java Completed: At revision: 20890
        Hide
        Adnan Durrani added a comment -

        Changes made so columns can be resized.

        Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\ext\renderkit\TableRenderer.java
        Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\ext\renderkit\TableRenderer.java
        Completed: At revision: 20889

        Show
        Adnan Durrani added a comment - Changes made so columns can be resized. Modified: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\ext\renderkit\TableRenderer.java Sending content: D:\work\development\head\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\ext\renderkit\TableRenderer.java Completed: At revision: 20889
        Hide
        Ken Fyten added a comment -

        Optional requirement 2) It would be nice if the size of the actual column width could be read somehow and as well written by the program logic in order to store the size configured by the user and present it in the same way the next time he enters the corresponding view.

        Show
        Ken Fyten added a comment - Optional requirement 2) It would be nice if the size of the actual column width could be read somehow and as well written by the program logic in order to store the size configured by the user and present it in the same way the next time he enters the corresponding view.

          People

          • Assignee:
            Joanne Bai
            Reporter:
            Daniel Kuschny
          • Votes:
            11 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: