Details
-
Type: Improvement
-
Status: Closed
-
Priority: Major
-
Resolution: Fixed
-
Affects Version/s: 1.7.1
-
Fix Version/s: 1.7.2
-
Component/s: Framework, ICE-Components
-
Labels:None
-
Environment:ICEfaces
-
ICEsoft Forum Reference:
Description
Rendering performance in applications is always a concern, but a clients Facelets application illustrated particularly poor rendering performance.
https://www.icesoft.ca:4443/supportilla/show_bug.cgi?id=4903
First notably were two methods on top of the profiling time lists. The serialize method of the DOMSerilizer class, and the renderNonBooleanAttributes method of the PassThroughAtrributeRenderer both have some questionable code. It might be justifiable but it seems very expensive.
This bug should be used to track any changes made to the framework and components with respect to this application.
https://www.icesoft.ca:4443/supportilla/show_bug.cgi?id=4903
First notably were two methods on top of the profiling time lists. The serialize method of the DOMSerilizer class, and the renderNonBooleanAttributes method of the PassThroughAtrributeRenderer both have some questionable code. It might be justifiable but it seems very expensive.
This bug should be used to track any changes made to the framework and components with respect to this application.
Issue Links
- blocks
-
ICE-3082 CPU performance/efficiency
- Closed
Activity
Ken Fyten
made changes -
Status | Resolved [ 5 ] | Closed [ 6 ] |
Assignee | Greg Dick [ greg.dick ] |
Ken Fyten
made changes -
Fix Version/s | 1.7.2 [ 10130 ] | |
Fix Version/s | 1.7.2RC1 [ 10140 ] |
Ken Fyten
made changes -
Fix Version/s | 1.7.2RC1 [ 10140 ] | |
Fix Version/s | 1.7.2 [ 10130 ] |
Greg Dick
made changes -
Status | Reopened [ 4 ] | Resolved [ 5 ] |
Resolution | Fixed [ 1 ] |
Deryk Sinotte
made changes -
Assignee | Ted Goddard [ ted.goddard ] | Greg Dick [ greg.dick ] |
Ken Fyten
made changes -
Summary | Framework alorithm improvements in passThroughAttribute and DOMSerialization areas | Framework algorithm improvements in passThroughAttribute and DOMSerialization areas |
Ken Fyten
made changes -
Resolution | Fixed [ 1 ] | |
Status | Closed [ 6 ] | Reopened [ 4 ] |
Assignee Priority | P1 |
Greg Dick
made changes -
Status | Resolved [ 5 ] | Closed [ 6 ] |
Greg Dick
made changes -
Status | Open [ 1 ] | Resolved [ 5 ] |
Resolution | Fixed [ 1 ] |
Greg Dick
made changes -
Summary | Rendering performance improvements | Framework alorithm improvements in passThroughAttribute and DOMSerialization areas |
Ken Fyten
made changes -
Link | This issue depends on ICE-3322 [ ICE-3322 ] |
Ken Fyten
made changes -
Summary | Optimize rendering performance | Rendering performance improvements |
Issue Type | Bug [ 1 ] | Improvement [ 4 ] |
Ken Fyten
made changes -
Summary | Rendering performance in ICEfaces framework is poor | Optimize rendering performance |
Fix Version/s | 1.7.2 [ 10130 ] | |
Security | Private [ 10001 ] | |
Assignee | Adnan Durrani [ adnan.durrani ] | Ted Goddard [ ted.goddard ] |
Repository | Revision | Date | User | Message |
ICEsoft Public SVN Repository | #17169 | Tue Jul 15 17:18:16 MDT 2008 | ted.goddard | alternate implementation of renderNonBooleanAttributes ( |
Files Changed | ||||
MODIFY
/icefaces/branches/icefaces-1.7.1/icefaces/core/src/com/icesoft/faces/renderkit/dom_html_basic/PassThruAttributeRenderer.java
|
Repository | Revision | Date | User | Message |
ICEsoft Public SVN Repository | #17168 | Tue Jul 15 17:18:06 MDT 2008 | ted.goddard | keep track of duplicates in pruned ancestors ( |
Files Changed | ||||
MODIFY
/icefaces/branches/icefaces-1.7.1/icefaces/core/src/com/icesoft/faces/context/PushModeSerializer.java
|
Repository | Revision | Date | User | Message |
ICEsoft Public SVN Repository | #17166 | Tue Jul 15 14:12:13 MDT 2008 | ted.goddard | alternate implementation of renderNonBooleanAttributes ( |
Files Changed | ||||
MODIFY
/icefaces/branches/icefaces-1.7/icefaces/core/src/com/icesoft/faces/renderkit/dom_html_basic/PassThruAttributeRenderer.java
|
Repository | Revision | Date | User | Message |
ICEsoft Public SVN Repository | #17165 | Tue Jul 15 14:11:35 MDT 2008 | ted.goddard | keep track of duplicates in pruned ancestors ( |
Files Changed | ||||
MODIFY
/icefaces/branches/icefaces-1.7/icefaces/core/src/com/icesoft/faces/context/PushModeSerializer.java
|
Repository | Revision | Date | User | Message |
ICEsoft Public SVN Repository | #17153 | Mon Jul 14 12:15:50 MDT 2008 | ted.goddard | keep track of duplicates in pruned ancestors ( |
Files Changed | ||||
MODIFY
/icefaces/trunk/icefaces/core/src/com/icesoft/faces/context/PushModeSerializer.java
|
Ken Fyten
made changes -
Assignee | Greg Dick [ greg.dick ] | Adnan Durrani [ adnan.durrani ] |
Greg Dick
made changes -
Attachment | PushModeSerializer.java [ 11119 ] |
Greg Dick
made changes -
Attachment | PassThruAttributeRenderer.java [ 11118 ] |
Ken Fyten
made changes -
Field | Original Value | New Value |
---|---|---|
Assignee Priority | P1 | |
Assignee | Greg Dick [ greg.dick ] |
Repository | Revision | Date | User | Message |
ICEsoft Public SVN Repository | #17129 | Fri Jul 11 09:53:43 MDT 2008 | greg.dick | |
Files Changed | ||||
MODIFY
/icefaces/branches/icefaces-1.7/icefaces/core/src/com/icesoft/faces/context/PushModeSerializer.java
|
Repository | Revision | Date | User | Message |
ICEsoft Public SVN Repository | #17128 | Fri Jul 11 09:50:03 MDT 2008 | greg.dick | |
Files Changed | ||||
MODIFY
/icefaces/branches/icefaces-1.7/icefaces/core/src/com/icesoft/faces/renderkit/dom_html_basic/PassThruAttributeRenderer.java
|
Repository | Revision | Date | User | Message |
ICEsoft Public SVN Repository | #17126 | Thu Jul 10 14:51:24 MDT 2008 | greg.dick | |
Files Changed | ||||
MODIFY
/icefaces/branches/icefaces-1.7/icefaces/core/src/com/icesoft/faces/renderkit/dom_html_basic/PassThruAttributeRenderer.java
|
Repository | Revision | Date | User | Message |
ICEsoft Public SVN Repository | #17125 | Thu Jul 10 14:50:58 MDT 2008 | greg.dick | |
Files Changed | ||||
MODIFY
/icefaces/branches/icefaces-1.7/icefaces/core/src/com/icesoft/faces/context/PushModeSerializer.java
|
Repository | Revision | Date | User | Message |
ICEsoft Public SVN Repository | #17122 | Thu Jul 10 14:41:23 MDT 2008 | greg.dick | |
Files Changed | ||||
MODIFY
/icefaces/trunk/icefaces/core/src/com/icesoft/faces/renderkit/dom_html_basic/PassThruAttributeRenderer.java
|
Repository | Revision | Date | User | Message |
ICEsoft Public SVN Repository | #17121 | Thu Jul 10 14:40:22 MDT 2008 | greg.dick | |
Files Changed | ||||
MODIFY
/icefaces/trunk/icefaces/core/src/com/icesoft/faces/context/PushModeSerializer.java
|
Greg Dick
created issue -
The serialize method no longer show up on the top of the profiling lists, and for the clients application in question, this results in a large reduction in the number of method calls. This doesn't necessarily result in a large realtime improvement (roughly 10% in the app in question, eg. 1/10's of seconds on my development machine) but the change will definitely effect scalability in this type of application with large, changing, data sets.
Much more improvement in rendering speed occurs with changes to the pass through attribute rendering http://jira.icefaces.org/browse/ICE-3346