ICEfaces
  1. ICEfaces
  2. ICE-3235

inputFile missing final render

          Details

          • Type: Bug Bug
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 1.7.1
          • Fix Version/s: 1.7.2
          • Component/s: ICE-Components
          • Labels:
            None
          • Environment:
            All

            Description

            Under certain conditions, including when you don't have a progressListener, the inputFile will not do the final render, after the file has uploaded, allowing you to see your UI updates that reflect the completion of the upload.

            It looks like something got missed in the many steps of changing the inputFile for 1.7.0 -> 1.7.1. There used to be a call to PersistentFacesState.renderLater() after the file uploaded. That was removed, because o Spring integration issues, and replaced with functionality for ICE-2860. But ICE-2860 needed to be made conditional, for backwards compatibility, so ICE-3122 opened up this problem. Furthermore, for ICE-2275's aims to be realised, we need to fix this.

              Activity

              Ascending order - Click to sort in descending order
              Mark Collette created issue -
              Mark Collette made changes -
              Field Original Value New Value
              Assignee Mark Collette [ mark.collette ]
              Ken Fyten made changes -
              Fix Version/s 1.7.2 [ 10130 ]
              Assignee Priority P3
              Ken Fyten made changes -
              Assignee Priority P3 P1
              Ken Fyten made changes -
              Fix Version/s 1.7.2RC1 [ 10140 ]
              Fix Version/s 1.7.2 [ 10130 ]
              Ken Fyten made changes -
              Fix Version/s 1.7.2 [ 10130 ]
              Fix Version/s 1.7.2RC1 [ 10140 ]
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #17608 Thu Sep 18 13:46:37 MDT 2008 mark.collette ICE-3187
              ICE-3235 : inputFile missing final render
              Files Changed
              Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/webapp/xmlhttp/PersistentFacesState.java
              Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/inputfile/InputFile.java
              Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/component/FileUploadComponent.java
              Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/webapp/http/core/UploadServer.java
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #17609 Thu Sep 18 13:51:38 MDT 2008 mark.collette ICE-3187 : File upload fails randomly
              ICE-3235 : inputFile missing final render
              Files Changed
              Commit graph MODIFY /icefaces/branches/icefaces-1.7/icefaces/component/src/com/icesoft/faces/component/inputfile/InputFile.java
              Commit graph MODIFY /icefaces/branches/icefaces-1.7/icefaces/core/src/com/icesoft/faces/component/FileUploadComponent.java
              Commit graph MODIFY /icefaces/branches/icefaces-1.7/icefaces/core/src/com/icesoft/faces/webapp/http/core/UploadServer.java
              Commit graph MODIFY /icefaces/branches/icefaces-1.7/icefaces/core/src/com/icesoft/faces/webapp/xmlhttp/PersistentFacesState.java
              Hide
              Permalink
              Mark Collette added a comment -

              I committed the fixes for ICE-3187 and ICE-3235 together.

              The relationship between the UploadServer (servlet) and the InputFile (component) was reworked, so that the InputFile would contain the code for rendering, to facilitate including the final render.

              TRUNK
              Subversion 17608
              ICEfaces 1.7 branch
              Subversion 17609
              icefaces\component\src\com\icesoft\faces\component\inputfile\InputFile.java
              icefaces\core\src\com\icesoft\faces\component\FileUploadComponent.java
              icefaces\core\src\com\icesoft\faces\webapp\http\core\UploadServer.java
              icefaces\core\src\com\icesoft\faces\webapp\xmlhttp\PersistentFacesState.java

              Show
              Mark Collette added a comment - I committed the fixes for ICE-3187 and ICE-3235 together. The relationship between the UploadServer (servlet) and the InputFile (component) was reworked, so that the InputFile would contain the code for rendering, to facilitate including the final render. TRUNK Subversion 17608 ICEfaces 1.7 branch Subversion 17609 icefaces\component\src\com\icesoft\faces\component\inputfile\InputFile.java icefaces\core\src\com\icesoft\faces\component\FileUploadComponent.java icefaces\core\src\com\icesoft\faces\webapp\http\core\UploadServer.java icefaces\core\src\com\icesoft\faces\webapp\xmlhttp\PersistentFacesState.java
              Mark Collette made changes -
              Status Open [ 1 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Ken Fyten made changes -
              Status Resolved [ 5 ] Closed [ 6 ]
              Assignee Priority P1
              Assignee Mark Collette [ mark.collette ]

                People

                • Assignee:
                  Unassigned
                  Reporter:
                  Mark Collette
                • Votes:
                  1 Vote for this issue
                  Watchers:
                  2 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: