Details
Bug
Minor
Description
Related to ICE-3197.
Activity
| Field | Original Value | New Value |
|---|---|---|
| Assignee | Yip Ng [ yip.ng ] |
| Fix Version/s | 1.7.2 [ 10130 ] |
| Summary | Wrong jars included in war file by certain build targets in build-common. | Using command-line switches with sample app. ant build scripts doesn't remove libraries when it should. |
| Description |
Some build targets in build-common include wrong jars in the war file, e.g. the tomcat6.0 build target with the myfaces switch set includes both the myfaces and JSF1.2 jars in the war file. See ICE-3197. |
When using the sample app ant build scripts, specifying both a target (e.g. "tomcat6.0') and a command-line switch (e.g. '-Dmyfaces=""') will result in all the libraries specified by both the target and the switch being added to the resulting .war file. The problem is that for certain switches, such as '-Dmyfaces=""', the default JSF runtime libs defined by the build targets should not be included and the MyFaces runtime libs should be used instead. Related to ICE-3197. |
| Priority | Major [ 3 ] | Minor [ 4 ] |
| Fix Version/s | 1.8DR#2 [ 10142 ] | |
| Fix Version/s | 1.7.2 [ 10130 ] | |
| Assignee | Yip Ng [ yip.ng ] | Jim Zhang [ jim.zhang ] |
| Fix Version/s | 1.8DR#3 [ 10143 ] | |
| Fix Version/s | 1.8DR#2 [ 10142 ] |
| Fix Version/s | 1.8DR#2 [ 10142 ] | |
| Fix Version/s | 1.8DR#3 [ 10143 ] | |
| Affects | [Sample App./Tutorial] |
| Repository | Revision | Date | User | Message |
| ICEsoft Public SVN Repository | #17902 | Mon Nov 17 02:53:50 MST 2008 | jim.zhang | add myfaces target |
| Files Changed | ||||
MODIFY
/icefaces/trunk/icefaces/samples/etc/build-common.xml
|
The target "myfaces" was dedicated for war files built for myfaces applications.
I guess we have two options then:
1. Add new targets for MyFaces (1.1 and App. Server combinations
2. Make the build smart enough to adapt properly when the -Dmyfaces="" switch is used in conjunction with the existing build targets (basically substitute the sun JSF RI jars with the MyFaces ones).
Thoughts?
Markup switches with targets maybe a better option. As we discussed a year ago, building targets to markup switches was one of goals to improve build functionality and feasibility.
For myfaces, myfaces applications have no conjunction to JSF RI jars in compiling time and deploying time. A new target, "myface", may be good to use to build all myfaces war files.
| Repository | Revision | Date | User | Message |
| ICEsoft Public SVN Repository | #17909 | Tue Nov 18 03:51:05 MST 2008 | jim.zhang | ice-3199 enable switch, -Dmyfaces="", for jsf1.2 servers, like tomcat 6.x |
| Files Changed | ||||
|
MODIFY
/icefaces/trunk/icefaces/samples/etc/build-common.xml
|
A new target was created with the name "myfaces" in build-common.
For developers, the build script became a bit smarter to adapt switch -Dmyfaces="" so that "tomcat" server targets and switch -Dmyfaces="" could be combined together.
| Status | Open [ 1 ] | Closed [ 6 ] |
| Resolution | Fixed [ 1 ] |
We know that the resulting build should either have jsf-api.jar and jsf-impl.jar (1.2 version) in the case of JSF testing, or myfaces-api.jar and myfaces-impl.jar in the case of MyFaces testing.
My question is if the JSF-1.2 libs are removed, should MyFaces still suppose to work on tomcat 6, or we expect MyFaces to only work on Tomcat 5?
The target "build.myfaces.war" in build-common provides the function to build war file for myfaces version. It is available for use at any level in Samples. As I remember, there was a discussion about myfaces issue. We do not support jsf1.2 with myfaces yet. So the default server for the war file is Tomcat 5.x. The war file for myfaces version from the most current trunk works fine with Tomcat 5.5