ICEfaces
  1. ICEfaces
  2. ICE-3182

DOMResponseWriter.writeText() escaping

          Details

          • Type: Bug Bug
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 1.7
          • Fix Version/s: 2.0-Alpha3, 2.0.0
          • Component/s: Framework
          • Labels:
            None
          • Environment:
            ICEfaces

            Description

            As the API says, text has to be written "after performing any escaping
            appropriate for the markup language being rendered".
            The SUN RI HtmlResponseWriter implements the escaping.
            In ICEFaces text render, escaping is implemented by converting
            text with DOMUtils.escapeAnsi().

            The implementation currently does not escape text inserted in the DOM. Note that it can be argued that the DOM should not contain escaped text and that any escaping should be performed during DOM serialization.

              Issue Links

              blocks

              Bug - A problem which impairs or prevents the functions of the product. ICE-5551 ICEfaces 2.0 DOM output attribute escaping

              • Major - Major loss of function.
              • Closed

              Task - A task that needs to be done. ICE-4950 Configure existing JSF 2.0 test cases to run with ICEfaces 2.0

              • Major - Major loss of function.
              • Closed

              Improvement - An improvement or enhancement to an existing feature or task. ICE-5582 Ensure ResponseWriter based compat components do escaping properly

              • Major - Major loss of function.
              • Closed

                Activity

                Repository Revision Date User Message
                ICEsoft Public SVN Repository #21463 Mon May 24 16:09:53 MDT 2010 mircea.toma ICE-3182 Change dynamically added component to use ResponseWriter for generating HTML content instead of writing HTML content as escaped text.
                Files Changed
                Commit graph MODIFY /icefaces/scratchpads/glimmer/core/src/main/java/org/icefaces/event/BridgeSetup.java
                Commit graph MODIFY /icefaces/scratchpads/glimmer/compat/core/src/main/java/com/icesoft/faces/application/ExtrasSetup.java
                Commit graph MODIFY /icefaces/scratchpads/glimmer/compat/core/src/main/java/com/icesoft/faces/component/JavaScriptContextSetup.java
                Repository Revision Date User Message
                ICEsoft Public SVN Repository #21379 Fri May 07 14:38:49 MDT 2010 deryk.sinotte ICE-3182: fixed copy/paste type and optimize imports
                Files Changed
                Commit graph MODIFY /icefaces/scratchpads/glimmer/core/src/main/java/org/icefaces/event/EnterKeySubmit.java
                Commit graph MODIFY /icefaces/scratchpads/glimmer/core/src/main/java/org/icefaces/event/RedirectSubmit.java
                Repository Revision Date User Message
                ICEsoft Public SVN Repository #21378 Fri May 07 14:32:38 MDT 2010 greg.dick ICE-3182 Added encodeEnd method to avoid adding span artifacts
                Files Changed
                Commit graph MODIFY /icefaces/scratchpads/glimmer/core/src/main/java/org/icefaces/event/ScriptWriter.java
                Repository Revision Date User Message
                ICEsoft Public SVN Repository #21375 Fri May 07 11:17:53 MDT 2010 greg.dick ICE-3182 updated use of ScriptWriter
                Files Changed
                Commit graph MODIFY /icefaces/scratchpads/glimmer/core/src/main/java/org/icefaces/event/EnterKeySubmit.java
                Commit graph MODIFY /icefaces/scratchpads/glimmer/core/src/main/java/org/icefaces/event/ScriptWriter.java
                Commit graph MODIFY /icefaces/scratchpads/glimmer/core/src/main/java/org/icefaces/event/RedirectSubmit.java
                Repository Revision Date User Message
                ICEsoft Public SVN Repository #21345 Thu Apr 29 10:18:34 MDT 2010 greg.dick ICE-3182 check for presence of script or style
                Files Changed
                Commit graph MODIFY /icefaces/scratchpads/glimmer/core/src/main/java/org/icefaces/context/DOMResponseWriter.java
                Repository Revision Date User Message
                ICEsoft Public SVN Repository #21334 Wed Apr 28 07:39:04 MDT 2010 greg.dick ICE-3182 changed the location of escaping code to be done at responseWriting time rather than during serialization
                Files Changed
                Commit graph MODIFY /icefaces/scratchpads/glimmer/core/src/main/java/org/icefaces/util/DOMUtils.java
                Commit graph MODIFY /icefaces/scratchpads/glimmer/core/src/main/java/org/icefaces/context/DOMResponseWriter.java
                Repository Revision Date User Message
                ICEsoft Public SVN Repository #21299 Fri Apr 23 09:42:13 MDT 2010 greg.dick ICE-3182 removed some stylesheet includes to simplify
                Files Changed
                Commit graph MODIFY /icefaces/scratchpads/glimmer/samples/test/ICE-3182/src/main/webapp/icefaces.xhtml
                Repository Revision Date User Message
                ICEsoft Public SVN Repository #21291 Thu Apr 22 09:33:20 MDT 2010 greg.dick ICE-3182 escape XML chars in rendered text, and more cases checked in attribute rendering
                Files Changed
                Commit graph MODIFY /icefaces/scratchpads/glimmer/core/src/main/java/org/icefaces/util/DOMUtils.java

                  People

                  • Assignee:
                    Greg Dick
                    Reporter:
                    Ted Goddard
                  • Votes:
                    1 Vote for this issue
                    Watchers:
                    0 Start watching this issue

                    Dates

                    • Created:
                      Updated:
                      Resolved: