ICEfaces
  1. ICEfaces
  2. ICE-3154

Clean up improper 'encodeChildren' implementations in a few components

          Details

          • Type: Bug Bug
          • Status: Closed
          • Priority: Minor Minor
          • Resolution: Fixed
          • Affects Version/s: 1.7
          • Fix Version/s: 1.7.1
          • Component/s: ICE-Components
          • Labels:
            None
          • Environment:
            All

            Description

            Because of ICE-3147, I did a little impromptu audit of encodeChildren() methods in our components. The following classes use non-standard implementations of encodeChildren(-), which may cause problems:

            com.icesoft.faces.component.gmap.GMapLatLngs
            com.icesoft.faces.component.gmap.GMapMarker
            com.icesoft.faces.component.gmap.GMapRenderer
            com.icesoft.faces.component.menubar.MenuItemRenderer
               Lines 658, 704 :: Link rendering. The way we hard-code the links, it
            should be ok
            com.icesoft.faces.component.menubar.MenuItemRendererBase
               Omits check for rendered that MenuItemsRenderer does
            com.icesoft.faces.component.panellayout.PanelLayoutRenderer

              Activity

              Repository Revision Date User Message
              ICEsoft Public SVN Repository #16850 Tue Jun 10 16:35:38 MDT 2008 mark.collette ICE-3154 : Clean up improper 'encodeChildren' implementations in a few components
              Files Changed
              Commit graph MODIFY /icefaces/branches/icefaces-1.7/icefaces/component/src/com/icesoft/faces/component/datapaginator/DataPaginatorRenderer.java
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #16849 Tue Jun 10 16:35:09 MDT 2008 mark.collette ICE-3154 : Clean up improper 'encodeChildren' implementations in a few components
              Files Changed
              Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/datapaginator/DataPaginatorRenderer.java
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #16844 Mon Jun 09 18:15:23 MDT 2008 adnan.durrani changes made to fix ICE-3154, has been reverted. Don't apply on it
              Files Changed
              Commit graph MODIFY /icefaces/branches/icefaces-1.7/icefaces/component/src/com/icesoft/faces/component/gmap/GMapMarker.java
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #16842 Mon Jun 09 17:53:39 MDT 2008 yip.ng ICE-3154
              Fixed potential logic flaws in encodeChildren() method.
              Files Changed
              Commit graph MODIFY /icefaces/branches/icefaces-1.7/icefaces/component/src/com/icesoft/faces/component/panellayout/PanelLayoutRenderer.java
              Commit graph MODIFY /icefaces/branches/icefaces-1.7/icefaces/component/src/com/icesoft/faces/component/menubar/MenuItemRenderer.java
              Commit graph MODIFY /icefaces/branches/icefaces-1.7/icefaces/component/src/com/icesoft/faces/component/menubar/MenuItemRendererBase.java
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #16841 Mon Jun 09 17:51:41 MDT 2008 yip.ng ICE-3154
              Fixed potential logic flaws in encodeChildren() method.
              Files Changed
              Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/menubar/MenuItemRenderer.java
              Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/panellayout/PanelLayoutRenderer.java
              Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/menubar/MenuItemRendererBase.java
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #16838 Mon Jun 09 16:31:52 MDT 2008 adnan.durrani Fix for ICE-3154 (Clean up improper 'encodeChildren' implementations in a few components)
              Files Changed
              Commit graph MODIFY /icefaces/branches/icefaces-1.7/icefaces/component/src/com/icesoft/faces/component/gmap/GMapMarker.java
              Commit graph MODIFY /icefaces/branches/icefaces-1.7/icefaces/component/src/com/icesoft/faces/component/gmap/GMapLatLngs.java
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #16837 Mon Jun 09 16:31:07 MDT 2008 adnan.durrani Fix for ICE-3154 (Clean up improper 'encodeChildren' implementations in a few components)
              Files Changed
              Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/gmap/GMapMarker.java
              Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/gmap/GMapLatLngs.java

                People

                • Assignee:
                  Unassigned
                  Reporter:
                  Mark Collette
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  0 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: