ICEfaces
  1. ICEfaces
  2. ICE-3147

CommandLink children doesn't get fully recursively rendered

          Details

          • Type: Bug Bug
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 1.7
          • Fix Version/s: 1.7.1
          • Component/s: ICE-Components
          • Labels:
            None
          • Environment:
            ICEfaces + Facelets

            Description

            This is exactly like ICE-1710, except this bug is with commandLink, not outputLink. I've also made a Bug entry with Mojarra, since they exhibit the bug too. It's just that it's not expressed with them, because stock Facelets handles html tags differently than our Facelets.

            https://javaserverfaces.dev.java.net/issues/show_bug.cgi?id=741

              Activity

              Ascending order - Click to sort in descending order
              Mark Collette created issue -
              Mark Collette made changes -
              Field Original Value New Value
              Fix Version/s 1.7.1 [ 10122 ]
              Assignee Mark Collette [ mark.collette ]
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #16826 Fri Jun 06 16:47:32 MDT 2008 mark.collette ICE-3147 : CommandLink children doesn't get fully recursively rendered
              Files Changed
              Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/renderkit/dom_html_basic/CommandLinkRenderer.java
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #16827 Fri Jun 06 16:48:09 MDT 2008 mark.collette ICE-3147 : CommandLink children doesn't get fully recursively rendered
              Files Changed
              Commit graph MODIFY /icefaces/branches/icefaces-1.7/icefaces/core/src/com/icesoft/faces/renderkit/dom_html_basic/CommandLinkRenderer.java
              Hide
              Permalink
              Mark Collette added a comment -

              I changed the commandLink renderer to behave like the outputLink renderer, in that they now do not render their own children, instead of rendering them incorrectly. Components should really only render their own children if they have to do it in a special way. They shouldn't opt in to do it otherwise.

              TRUNK
              Subversion 16826
              icefaces\core\src\com\icesoft\faces\renderkit\dom_html_basic\CommandLinkRenderer.java

              ICEfaces 1.7 branch
              Subversion 16827
              icefaces\core\src\com\icesoft\faces\renderkit\dom_html_basic\CommandLinkRenderer.java

              Show
              Mark Collette added a comment - I changed the commandLink renderer to behave like the outputLink renderer, in that they now do not render their own children, instead of rendering them incorrectly. Components should really only render their own children if they have to do it in a special way. They shouldn't opt in to do it otherwise. TRUNK Subversion 16826 icefaces\core\src\com\icesoft\faces\renderkit\dom_html_basic\CommandLinkRenderer.java ICEfaces 1.7 branch Subversion 16827 icefaces\core\src\com\icesoft\faces\renderkit\dom_html_basic\CommandLinkRenderer.java
              Mark Collette made changes -
              Status Open [ 1 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Hide
              Permalink
              Mark Collette added a comment -

              You can test this by changing the markup in:
              icefaces\samples\component-showcase\common-web\WEB-INF\includes\examples\standard\buttonsAndLinks.jspx

              From:

              <ice:commandLink id="BLCmdLnk"
              value="Submit"
              actionListener="#

              {buttonsAndLinks.commandLinkListener}"/>

              To:

              <ice:commandLink id="BLCmdLnk" actionListener="#{buttonsAndLinks.commandLinkListener}

              ">
              <em>Submit</em>
              </ice:commandLink>

              In both cases you should have a link wit the word "Submit" in it. The font should vary though.

              Show
              Mark Collette added a comment - You can test this by changing the markup in: icefaces\samples\component-showcase\common-web\WEB-INF\includes\examples\standard\buttonsAndLinks.jspx From: <ice:commandLink id="BLCmdLnk" value="Submit" actionListener="# {buttonsAndLinks.commandLinkListener}"/> To: <ice:commandLink id="BLCmdLnk" actionListener="#{buttonsAndLinks.commandLinkListener} "> <em>Submit</em> </ice:commandLink> In both cases you should have a link wit the word "Submit" in it. The font should vary though.
              Ken Fyten made changes -
              Status Resolved [ 5 ] Closed [ 6 ]
              Assignee Mark Collette [ mark.collette ]

                People

                • Assignee:
                  Unassigned
                  Reporter:
                  Mark Collette
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  0 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: