ICEfaces
  1. ICEfaces
  2. ICE-3145

using the ice:dataPaginator component in a Liferay portlet crashes IE6

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.7
    • Fix Version/s: 1.7.2
    • Component/s: ICE-Components
    • Labels:
      None
    • Environment:
      any

      Description

      Attached is a simple ICEfaces portlet which contains a dataTable with a dataPaginator. Adding the portlet and clicking the "Toggle Table Display" button causes IE6 to crash. The browser remains unresponsive until shut down with the task manager. When setting the dataPaginator to rendered="false" the portlet is shown without problems. This only occurs on IE6.

        Activity

        Michael Thiem created issue -
        Hide
        Michael Thiem added a comment -

        Tested on Liferay 5 with Tomcat 6

        Show
        Michael Thiem added a comment - Tested on Liferay 5 with Tomcat 6
        Michael Thiem made changes -
        Field Original Value New Value
        Attachment TableProblem.war [ 11048 ]
        Michael Thiem made changes -
        Ken Fyten made changes -
        Fix Version/s 1.7.2 [ 10130 ]
        Assignee Priority P1
        Assignee Adnan Durrani [ adnan.durrani ]
        Priority Major [ 3 ] Critical [ 2 ]
        Hide
        Adnan Durrani added a comment -

        After doing all debugging and comparing the DOMDiff, It came across that its related to the image loading. The paginator is using couple of images to show the navigation buttons, and it causing browser to get hang, its not even hanging its trying to download the images but for some reason it doesn't get it.

        The "graphicImage" can be replaced with "outputText" to fix this app.

        <f:facet name="first">
        <!-- <ice:graphicImage
        url="/xmlhttp/css/xp/css-images/arrow-first.gif"
        style="border:none;" title="first page" />
        -->
        <ice:outputText value="First"/>
        </f:facet>

        Show
        Adnan Durrani added a comment - After doing all debugging and comparing the DOMDiff, It came across that its related to the image loading. The paginator is using couple of images to show the navigation buttons, and it causing browser to get hang, its not even hanging its trying to download the images but for some reason it doesn't get it. The "graphicImage" can be replaced with "outputText" to fix this app. <f:facet name="first"> <!-- <ice:graphicImage url="/xmlhttp/css/xp/css-images/arrow-first.gif" style="border:none;" title="first page" /> --> <ice:outputText value="First"/> </f:facet>
        Ken Fyten made changes -
        Priority Critical [ 2 ] Major [ 3 ]
        Hide
        Adnan Durrani added a comment -

        I have used different images, but it didn't help. It means there isn't any problem with the paginator images.

        I have deleted the dataPaginator and used the commandButtons only but still sees the same problem, which means there is nothing wrong with the dataPaginator component.

        I copied the same images into the web application, and it did help. It seems like its related to the JAR bundled resources.

        Show
        Adnan Durrani added a comment - I have used different images, but it didn't help. It means there isn't any problem with the paginator images. I have deleted the dataPaginator and used the commandButtons only but still sees the same problem, which means there is nothing wrong with the dataPaginator component. I copied the same images into the web application, and it did help. It seems like its related to the JAR bundled resources.
        Hide
        Ken Fyten added a comment -

        Need to identify why .jar resource loading these images makes IE6 stall.

        Show
        Ken Fyten added a comment - Need to identify why .jar resource loading these images makes IE6 stall.
        Ken Fyten made changes -
        Assignee Adnan Durrani [ adnan.durrani ] Mircea Toma [ mircea.toma ]
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #17478 Mon Sep 01 08:27:42 MDT 2008 mircea.toma ICE-3145 Avoid compression for content that is already compressed, such as images, videos, or archives. Avoid triggering IE bug, as well.
        Files Changed
        Commit graph MODIFY /icefaces/branches/icefaces-1.7/icefaces/core/src/com/icesoft/faces/webapp/http/servlet/MainSessionBoundServlet.java
        Commit graph MODIFY /icefaces/branches/icefaces-1.7/icefaces/core/src/com/icesoft/faces/webapp/http/common/standard/CacheControlledServer.java
        Commit graph MODIFY /icefaces/branches/icefaces-1.7/icefaces/core/src/com/icesoft/faces/webapp/http/core/ResourceServer.java
        Commit graph MODIFY /icefaces/branches/icefaces-1.7/icefaces/core/src/com/icesoft/faces/webapp/http/common/standard/NotModifiedHandler.java
        Commit graph MODIFY /icefaces/branches/icefaces-1.7/icefaces/core/src/com/icesoft/faces/webapp/http/common/standard/CompressingServer.java
        Commit graph MODIFY /icefaces/branches/icefaces-1.7/icefaces/core/src/com/icesoft/faces/webapp/http/core/ResourceDispatcher.java
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #17479 Mon Sep 01 08:28:04 MDT 2008 mircea.toma ICE-3145 Avoid compression for content that is already compressed, such as images, videos, or archives. Avoid triggering IE bug as well.
        Files Changed
        Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/webapp/http/servlet/MainSessionBoundServlet.java
        Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/webapp/http/common/standard/NotModifiedHandler.java
        Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/webapp/http/core/ResourceDispatcher.java
        Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/webapp/http/common/standard/CacheControlledServer.java
        Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/webapp/http/common/standard/CompressingServer.java
        Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/webapp/http/core/ResourceServer.java
        Hide
        Mircea Toma added a comment -

        This link contains some more details about the possible source of this issue: https://bugs.launchpad.net/ubuntu/+source/apache/+bug/220171

        Show
        Mircea Toma added a comment - This link contains some more details about the possible source of this issue: https://bugs.launchpad.net/ubuntu/+source/apache/+bug/220171
        Hide
        Mircea Toma added a comment -

        Cancel compression for content that is already compressed, such as images, videos, or archives. Avoid triggering IE bug as well.

        Show
        Mircea Toma added a comment - Cancel compression for content that is already compressed, such as images, videos, or archives. Avoid triggering IE bug as well.
        Mircea Toma made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Mircea Toma added a comment -

        Introduce context parameter "com.icesoft.faces.noCompress" used to list (space separated) the mime-types of the resources that should not be compressed.

        Show
        Mircea Toma added a comment - Introduce context parameter "com.icesoft.faces.noCompress" used to list (space separated) the mime-types of the resources that should not be compressed.
        Mircea Toma made changes -
        Affects [Documentation (User Guide, Ref. Guide, etc.)]
        Hide
        Ken Fyten added a comment -

        Need to update doc. for new config. param.

        Show
        Ken Fyten added a comment - Need to update doc. for new config. param.
        Ken Fyten made changes -
        Assignee Mircea Toma [ mircea.toma ] Ken Fyten [ ken.fyten ]
        Ken Fyten made changes -
        Fix Version/s 1.7.2RC1 [ 10140 ]
        Fix Version/s 1.7.2 [ 10130 ]
        Hide
        Deryk Sinotte added a comment -

        Please change noCompress to compressResourcesExclusions so that the relationship between the two parameters is clear and so that they will appear together in the documentation.

        Show
        Deryk Sinotte added a comment - Please change noCompress to compressResourcesExclusions so that the relationship between the two parameters is clear and so that they will appear together in the documentation.
        Deryk Sinotte made changes -
        Resolution Fixed [ 1 ]
        Status Resolved [ 5 ] Reopened [ 4 ]
        Assignee Ken Fyten [ ken.fyten ] Mircea Toma [ mircea.toma ]
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #17532 Tue Sep 09 15:29:34 MDT 2008 mircea.toma ICE-3145 Rename parameter name.
        Files Changed
        Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/webapp/http/common/standard/CompressingServer.java
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #17533 Tue Sep 09 15:31:25 MDT 2008 mircea.toma ICE-3145 Rename parameter name.
        Files Changed
        Commit graph MODIFY /icefaces/branches/icefaces-1.7/icefaces/core/src/com/icesoft/faces/webapp/http/common/standard/CompressingServer.java
        Hide
        Mircea Toma added a comment -

        Rename parameter name.

        Show
        Mircea Toma added a comment - Rename parameter name.
        Mircea Toma made changes -
        Status Reopened [ 4 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Joanne Bai added a comment -

        Tested successfully on IE 6 + Liferay 5.1 Tomcat 6 with the new parameter name compressResourcesExclusions on branch revision #17546

        Show
        Joanne Bai added a comment - Tested successfully on IE 6 + Liferay 5.1 Tomcat 6 with the new parameter name compressResourcesExclusions on branch revision #17546
        Ken Fyten made changes -
        Fix Version/s 1.7.2 [ 10130 ]
        Fix Version/s 1.7.2RC1 [ 10140 ]
        Ken Fyten made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Assignee Priority P1
        Assignee Mircea Toma [ mircea.toma ]

          People

          • Assignee:
            Unassigned
            Reporter:
            Michael Thiem
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: