ICEfaces
  1. ICEfaces
  2. ICE-3080

<html> lang attribute incorrect

          Details

          • Type: Bug Bug
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 1.7
          • Fix Version/s: 1.7.1
          • Component/s: Framework
          • Labels:
            None
          • Environment:
            All

            Description

            In com.icesoft.faces.context.DOMResponseWriter.enhanceHtml(Element), we're using:
                Locale locale = context.getApplication().getViewHandler().calculateLocale(context);
            when we should instead be using:
                Locale locale = context.getViewRoot().getLocale();
            since that will respect any set Locale, and otherwise invoke ViewHandler.calculateLocale(FacesContext)

              Activity

              Ascending order - Click to sort in descending order
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #16654 Fri May 16 16:33:42 MDT 2008 mark.collette ICE-3080 : <html> lang attribute incorrect
              Files Changed
              Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/context/DOMResponseWriter.java
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #16655 Fri May 16 17:26:54 MDT 2008 mark.collette ICE-3080 : <html> lang attribute incorrect
              Files Changed
              Commit graph MODIFY /icefaces/branches/icefaces-1.7/icefaces/core/src/com/icesoft/faces/context/DOMResponseWriter.java
              Mark Collette created issue -
              Mark Collette made changes -
              Field Original Value New Value
              Assignee Mark Collette [ mark.collette ]
              Mark Collette made changes -
              Status Open [ 1 ] In Progress [ 3 ]
              Hide
              Permalink
              Mark Collette added a comment -

              TRUNK
              Subversion 16654
              icefaces\core\src\com\icesoft\faces\context\DOMResponseWriter.java

              ICEfaces 1.7 branch
              Subversion 16655
              icefaces\core\src\com\icesoft\faces\context\DOMResponseWriter.java

              Show
              Mark Collette added a comment - TRUNK Subversion 16654 icefaces\core\src\com\icesoft\faces\context\DOMResponseWriter.java ICEfaces 1.7 branch Subversion 16655 icefaces\core\src\com\icesoft\faces\context\DOMResponseWriter.java
              Mark Collette made changes -
              Status In Progress [ 3 ] Resolved [ 5 ]
              Fix Version/s 1.7.1 [ 10122 ]
              Resolution Fixed [ 1 ]
              Ken Fyten made changes -
              Status Resolved [ 5 ] Closed [ 6 ]
              Assignee Mark Collette [ mark.collette ]

                People

                • Assignee:
                  Unassigned
                  Reporter:
                  Mark Collette
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  0 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: