Details
-
Type:
Bug
-
Status: Closed
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: 1.7RC1
-
Fix Version/s: 1.7.1
-
Component/s: ICE-Components
-
Labels:None
-
Environment:deployed as portlet in liferay
Description
I have an ice:tree component with hideRootNode="true", and a backing bean that populates the model the value attribute is bound to.
When the tree renders it always shows a plus icon next to the perceived root node (actually the child of the root node, since the hideRootNode is set to true).
i.e.,
<invisible root node>
+ <perceived root>
The plus icon on the perceived root never changes to minus, whether the node is expanded or collapsed.
If I change the hideRootNode to false, then I see the true tree root node and all the +/- expand/contract icons work correctly.
Image attached.
When the tree renders it always shows a plus icon next to the perceived root node (actually the child of the root node, since the hideRootNode is set to true).
i.e.,
<invisible root node>
+ <perceived root>
The plus icon on the perceived root never changes to minus, whether the node is expanded or collapsed.
If I change the hideRootNode to false, then I see the true tree root node and all the +/- expand/contract icons work correctly.
Image attached.
Activity
| Field | Original Value | New Value |
|---|---|---|
| Attachment | icetreebug.JPG [ 10951 ] |
| Fix Version/s | 1.7.1 [ 10122 ] | |
| Assignee Priority | P3 | |
| Assignee | Yip Ng [ yip.ng ] |
Hi ICEfaces team,
I think that the bug may be fixed by replacing the following the code snippet 1 in TreeRenderer.java with the code snippet2:
<!-- snippet1 -->
if (currentNode.isRoot() && !isExpanded ||
hideRootNode
&& currentNode.getNextSibling() == null
&& currentNode == treeComponentRootNode.getFirstChild()
)
<!-- snippet 2 -->
if (currentNode.isRoot() || hideRootNode
&& currentNode.getNextSibling() == null
&& currentNode == rootTreeNode.getFirstChild()) {
if (isExpanded)
else
{ iconImage.setAttribute(HTML.SRC_ATTR, treeComponent.getNavOpenTopNoSiblingsImage()); }}
Show
Sheng Gu
added a comment - Hi ICEfaces team,
I think that the bug may be fixed by replacing the following the code snippet 1 in TreeRenderer.java with the code snippet2:
<!-- snippet1 -->
if (currentNode.isRoot() && !isExpanded ||
hideRootNode
&& currentNode.getNextSibling() == null
&& currentNode == treeComponentRootNode.getFirstChild()
)
{
iconImage.setAttribute(HTML.SRC_ATTR,
treeComponent.getNavOpenTopNoSiblingsImage());
}
<!-- snippet 2 -->
if (currentNode.isRoot() || hideRootNode
&& currentNode.getNextSibling() == null
&& currentNode == rootTreeNode.getFirstChild()) {
if (isExpanded)
{
iconImage.setAttribute(HTML.SRC_ATTR,
treeComponent.getNavCloseTopNoSiblingsImage());
}
else
{
iconImage.setAttribute(HTML.SRC_ATTR,
treeComponent.getNavOpenTopNoSiblingsImage());
}
}
There is another problem when there are more than one top level node: the line connecting the first and second icons is broken. See screenshot-1.
| Attachment | screenshot-1.jpg [ 11012 ] |
Also, when there are more than one top level node, the first icon is not aligned properly. See screenshot-2.
| Attachment | screenshot-2.jpg [ 11016 ] |
| Repository | Revision | Date | User | Message |
| ICEsoft Public SVN Repository | #16742 | Wed May 28 16:12:32 MDT 2008 | yip.ng | Fixed wrong/misaligned expand/collapse icon for first node of tree when hideRootNode = "true". |
| Files Changed | ||||
MODIFY
/icefaces/trunk/icefaces/core/src/com/icesoft/faces/resources/css/rime/css-images/tree_nav_top_close.gif
MODIFY
/icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/tree/TreeRenderer.java
|
| Repository | Revision | Date | User | Message |
| ICEsoft Public SVN Repository | #16743 | Wed May 28 16:13:28 MDT 2008 | yip.ng | Fixed wrong/misaligned expand/collapse icon for first node of tree when hideRootNode = "true". |
| Files Changed | ||||
MODIFY
/icefaces/branches/icefaces-1.7/icefaces/core/src/com/icesoft/faces/resources/css/rime/css-images/tree_nav_top_close.gif
MODIFY
/icefaces/branches/icefaces-1.7/icefaces/component/src/com/icesoft/faces/component/tree/TreeRenderer.java
|
| Attachment | screenshot-3.jpg [ 11017 ] |
| Attachment | screenshot-4.jpg [ 11018 ] |
| Attachment | screenshot-5.jpg [ 11019 ] |
| Attachment | screenshot-6.jpg [ 11020 ] |
Changes made based on Sheng Gu's suggestion, plus additional changes to fix the additional problems.
| Status | Open [ 1 ] | Resolved [ 5 ] |
| Resolution | Fixed [ 1 ] |
| Status | Resolved [ 5 ] | Closed [ 6 ] |
| Assignee Priority | P3 | |
| Assignee | Yip Ng [ yip.ng ] |
one additional note: it seems to only be an issue when there is a single perceived root node of the hidden root node. If there are two perceived root nodes of the hidden root node, the problem goes away, i.e.,
<invisible root node>
+ child 1