ICEfaces
  1. ICEfaces
  2. ICE-3012

Not all sample build targets are valid for all samples

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.7
    • Fix Version/s: 1.7.1
    • Component/s: Release
    • Labels:
      None
    • Environment:
      sample applications

      Description

      Some of the common build targets that we provide do not apply to all the sample applications and portlets. For example, the chat portlet example does not have a Facelets version so the target build.facelet.war does not apply. We need to ratify the targets in each sample so that we only provide working targets.

        Activity

        Ken Fyten made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Assignee Sam Xiao [ sam.xiao ]
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #16510 Thu Apr 24 15:34:20 MDT 2008 sam.xiao ICE-3012: backport changes to 1.7 branch
        Files Changed
        Commit graph MODIFY /icefaces/branches/icefaces-1.7/icefaces/samples/component-showcase/portlets/build.xml
        Commit graph MODIFY /icefaces/branches/icefaces-1.7/icefaces/samples/component-showcase/jsp/build.xml
        Commit graph MODIFY /icefaces/branches/icefaces-1.7/icefaces/samples/component-showcase/facelets-enh/build.xml
        Commit graph MODIFY /icefaces/branches/icefaces-1.7/icefaces/samples/component-showcase/facelets/build.xml
        Commit graph MODIFY /icefaces/branches/icefaces-1.7/icefaces/samples/etc/lib/icebuildext.jar
        Commit graph MODIFY /icefaces/branches/icefaces-1.7/icefaces/samples/etc/build-common.xml
        Sam Xiao made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Sam Xiao added a comment -

        fix checked in -r 16507

        Show
        Sam Xiao added a comment - fix checked in -r 16507
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #16507 Thu Apr 24 14:07:05 MDT 2008 sam.xiao ICE-3012: update ant help utility so that it shows only the applicable build targets
        Files Changed
        Commit graph MODIFY /icefaces/trunk/icefaces/samples/component-showcase/portlets/build.xml
        Commit graph MODIFY /icefaces/trunk/icefaces/samples/component-showcase/facelets/build.xml
        Commit graph MODIFY /icefaces/trunk/icefaces/samples/component-showcase/jsp/build.xml
        Commit graph MODIFY /icefaces/trunk/icefaces/samples/etc/lib/icebuildext.jar
        Commit graph MODIFY /icefaces/trunk/icefaces/samples/etc/build-common.xml
        Commit graph MODIFY /icefaces/trunk/icefaces/samples/component-showcase/facelets-enh/build.xml
        Ken Fyten made changes -
        Field Original Value New Value
        Fix Version/s 1.7.1 [ 10122 ]
        Assignee Sam Xiao [ sam.xiao ]
        Hide
        Ken Fyten added a comment -

        The "ant help" command is incorrectly stating "(NOT for facelets or portlet applications)" for app. server specific targets. This is incorrect and this text should be removed from ant help feature.

        In addition, the following samples have invalid build targets as specified which should be removed:

        address-demo

        • build.facelet.war (no facelet version is provided)

        auctionMonitor

        • build.facelet.war (no facelet version is provided)

        component-showcase/jsp

        • build.facelet.war (no facelet version is provided)

        component-showcase/portlets

        • build.facelet.war (no facelet version is provided)
        • glassfishv2, jboss4.0, etc. (only the "build.portlet.xxx" targets at the bottom are valid, the rest shouldn't show up)

        portlet/chat

        • build.facelet.war (no facelet version is provided)
        • glassfishv2, jboss4.0, etc. (only the "build.portlet.xxx" targets at the bottom are valid, the rest shouldn't show up)

        tutorial (all but timezone6 and timezone7)

        • build.facelet.war (no facelet version is provided)
        Show
        Ken Fyten added a comment - The "ant help" command is incorrectly stating "(NOT for facelets or portlet applications)" for app. server specific targets. This is incorrect and this text should be removed from ant help feature. In addition, the following samples have invalid build targets as specified which should be removed: address-demo build.facelet.war (no facelet version is provided) auctionMonitor build.facelet.war (no facelet version is provided) component-showcase/jsp build.facelet.war (no facelet version is provided) component-showcase/portlets build.facelet.war (no facelet version is provided) glassfishv2, jboss4.0, etc. (only the "build.portlet.xxx" targets at the bottom are valid, the rest shouldn't show up) portlet/chat build.facelet.war (no facelet version is provided) glassfishv2, jboss4.0, etc. (only the "build.portlet.xxx" targets at the bottom are valid, the rest shouldn't show up) tutorial (all but timezone6 and timezone7) build.facelet.war (no facelet version is provided)
        Deryk Sinotte created issue -

          People

          • Assignee:
            Unassigned
            Reporter:
            Deryk Sinotte
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: