ICEfaces
  1. ICEfaces
  2. ICE-2927

selectInputDate "required" attribute not working

          Details

          • Type: Bug Bug
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 1.7
          • Fix Version/s: 1.7.2
          • Component/s: ICE-Components
          • Labels:
            None
          • Environment:
            All

            Description

            The "required" attribute is not working correctly with the selectInputDate component. There was an earlier issue where no validators were working at all that was resolved (ICE-1748), however, no the required attribute is non-functional.

              Issue Links

              is duplicated by

              Bug - A problem which impairs or prevents the functions of the product. ICE-3305 selectInputDate with required="true" not triggering error

              • Major - Major loss of function.
              • Closed

              Bug - A problem which impairs or prevents the functions of the product. ICE-3650 Tabbing out of selectInputDate text box does not throw validation error when required=true

              • Major - Major loss of function.
              • Closed

                Activity

                Ascending order - Click to sort in descending order
                Ken Fyten created issue -
                Ken Fyten made changes -
                Field Original Value New Value
                Workaround Description Use a custom validator to check that a value is entered.
                Workaround Exists [Yes]
                Fix Version/s 1.7.1 [ 10122 ]
                Priority Major [ 3 ] Minor [ 4 ]
                Ken Fyten made changes -
                Fix Version/s 1.7.1 [ 10122 ]
                Michael Thiem made changes -
                Support Case References https://www.icesoft.ca:4443/supportilla/show_bug.cgi?id=4930
                Michael Thiem made changes -
                Affects Version/s 1.7 [ 10080 ]
                Hide
                Permalink
                Ken Fyten added a comment -

                This is a somewhat complex requirement in that the selectInputDate component is comprised of two components itself, the inputText and the button. It's complex/difficult to manage the state to know when a user leaves the inputText that he's just going to the button, so maybe don't enforce the required attribute for that, but if he is going to another element on the page then do enforce it.

                The simplest thing is probably to have the required attribute enforced all the time, so if the user just tabs through the inputText on their way to the button, the required test will fail and the msg associated with it will be displayed. This might be acceptable, if a little annoying if you're just trying to use the popup to enter the value and it's already complaining / warning that you need to enter the value.

                Show
                Ken Fyten added a comment - This is a somewhat complex requirement in that the selectInputDate component is comprised of two components itself, the inputText and the button. It's complex/difficult to manage the state to know when a user leaves the inputText that he's just going to the button, so maybe don't enforce the required attribute for that, but if he is going to another element on the page then do enforce it. The simplest thing is probably to have the required attribute enforced all the time, so if the user just tabs through the inputText on their way to the button, the required test will fail and the msg associated with it will be displayed. This might be acceptable, if a little annoying if you're just trying to use the popup to enter the value and it's already complaining / warning that you need to enter the value.
                Ken Fyten made changes -
                Fix Version/s 1.7.2 [ 10130 ]
                Assignee Priority P2
                Affects Version/s 1.7RC1 [ 10123 ]
                Assignee Mark Collette [ mark.collette ]
                Ken Fyten made changes -
                Assignee Priority P2 P1
                Priority Minor [ 4 ] Major [ 3 ]
                Repository Revision Date User Message
                ICEsoft Public SVN Repository #17151 Fri Jul 11 18:39:48 MDT 2008 mark.collette ICE-2927 : selectInputDate "required" attribute not working
                Files Changed
                Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/selectinputdate/SelectInputDate.java
                Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/util/CustomComponentUtils.java
                Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/selectinputdate/SelectInputDateRenderer.java
                Repository Revision Date User Message
                ICEsoft Public SVN Repository #17152 Fri Jul 11 18:49:33 MDT 2008 mark.collette ICE-2927 : selectInputDate "required" attribute not working
                Files Changed
                Commit graph MODIFY /icefaces/branches/icefaces-1.7/icefaces/component/src/com/icesoft/faces/component/selectinputdate/SelectInputDateRenderer.java
                Commit graph MODIFY /icefaces/branches/icefaces-1.7/icefaces/component/src/com/icesoft/faces/component/selectinputdate/SelectInputDate.java
                Commit graph MODIFY /icefaces/branches/icefaces-1.7/icefaces/component/src/com/icesoft/faces/component/util/CustomComponentUtils.java
                Hide
                Permalink
                Mark Collette added a comment -

                Now, with required="true", if you clear the text field and TAB out of it, or press ENTER, it will fail validation. Also, if you do a full form submit, it will now fail validation. But, clicking on the button to popup or hide the calendar, or changing the month or year with the arrow buttons or the menus, will not cause validation to occur.

                TRUNK
                Subversion 17151
                ICEfaces 1.7 branch
                Subversion 17152
                icefaces\component\src\com\icesoft\faces\component\selectinputdate\SelectInputDate.java
                icefaces\component\src\com\icesoft\faces\component\selectinputdate\SelectInputDateRenderer.java
                icefaces\component\src\com\icesoft\faces\component\util\CustomComponentUtils.java

                Show
                Mark Collette added a comment - Now, with required="true", if you clear the text field and TAB out of it, or press ENTER, it will fail validation. Also, if you do a full form submit, it will now fail validation. But, clicking on the button to popup or hide the calendar, or changing the month or year with the arrow buttons or the menus, will not cause validation to occur. TRUNK Subversion 17151 ICEfaces 1.7 branch Subversion 17152 icefaces\component\src\com\icesoft\faces\component\selectinputdate\SelectInputDate.java icefaces\component\src\com\icesoft\faces\component\selectinputdate\SelectInputDateRenderer.java icefaces\component\src\com\icesoft\faces\component\util\CustomComponentUtils.java
                Mark Collette made changes -
                Status Open [ 1 ] Resolved [ 5 ]
                Resolution Fixed [ 1 ]
                Repository Revision Date User Message
                ICEsoft Public SVN Repository #17170 Tue Jul 15 17:45:27 MDT 2008 mark.collette ICE-2927 : selectInputDate "required" attribute not working
                Files Changed
                Commit graph MODIFY /icefaces/branches/icefaces-1.7.1/icefaces/component/src/com/icesoft/faces/component/selectinputdate/SelectInputDate.java
                Commit graph MODIFY /icefaces/branches/icefaces-1.7.1/icefaces/component/src/com/icesoft/faces/component/selectinputdate/SelectInputDateRenderer.java
                Commit graph MODIFY /icefaces/branches/icefaces-1.7.1/icefaces/component/src/com/icesoft/faces/component/util/CustomComponentUtils.java
                Ken Fyten made changes -
                Link This issue is duplicated by ICE-3305 [ ICE-3305 ]
                Hide
                Permalink
                Mark Collette added a comment -

                ICEfaces 1.7.1 branch
                Subversion 17170
                icefaces\component\src\com\icesoft\faces\component\selectinputdate\SelectInputDate.java
                icefaces\component\src\com\icesoft\faces\component\selectinputdate\SelectInputDateRenderer.java
                icefaces\component\src\com\icesoft\faces\component\util\CustomComponentUtils.java

                Show
                Mark Collette added a comment - ICEfaces 1.7.1 branch Subversion 17170 icefaces\component\src\com\icesoft\faces\component\selectinputdate\SelectInputDate.java icefaces\component\src\com\icesoft\faces\component\selectinputdate\SelectInputDateRenderer.java icefaces\component\src\com\icesoft\faces\component\util\CustomComponentUtils.java
                Repository Revision Date User Message
                ICEsoft Public SVN Repository #17182 Wed Jul 16 12:27:32 MDT 2008 mark.collette ICE-2927 : selectInputDate "required" attribute not working
                Files Changed
                Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/selectinputdate/SelectInputDateRenderer.java
                Repository Revision Date User Message
                ICEsoft Public SVN Repository #17183 Wed Jul 16 12:28:48 MDT 2008 mark.collette ICE-2927 : selectInputDate "required" attribute not working
                Files Changed
                Commit graph MODIFY /icefaces/branches/icefaces-1.7.1/icefaces/component/src/com/icesoft/faces/component/selectinputdate/SelectInputDateRenderer.java
                Repository Revision Date User Message
                ICEsoft Public SVN Repository #17184 Wed Jul 16 12:29:13 MDT 2008 mark.collette ICE-2927 : selectInputDate "required" attribute not working
                Files Changed
                Commit graph MODIFY /icefaces/branches/icefaces-1.7/icefaces/component/src/com/icesoft/faces/component/selectinputdate/SelectInputDateRenderer.java
                Mandeep Hayher made changes -
                Resolution Fixed [ 1 ]
                Status Resolved [ 5 ] Reopened [ 4 ]
                Security Private [ 10001 ]
                Hide
                Permalink
                Mark Collette added a comment -

                Fixed the

                { next month, prev month, next year, prev year }

                issue. It was fallout from changing some of the ids, necessary for making required work properly.

                TRUNK
                Subversion 17182
                ICEfaces 1.7 branch
                Subversion 17184
                ICEfaces 1.7.1 branch
                Subversion 17183
                icefaces\component\src\com\icesoft\faces\component\selectinputdate\SelectInputDateRenderer.java

                Show
                Mark Collette added a comment - Fixed the { next month, prev month, next year, prev year } issue. It was fallout from changing some of the ids, necessary for making required work properly. TRUNK Subversion 17182 ICEfaces 1.7 branch Subversion 17184 ICEfaces 1.7.1 branch Subversion 17183 icefaces\component\src\com\icesoft\faces\component\selectinputdate\SelectInputDateRenderer.java
                Mark Collette made changes -
                Status Reopened [ 4 ] Resolved [ 5 ]
                Resolution Fixed [ 1 ]
                Repository Revision Date User Message
                ICEsoft Public SVN Repository #17187 Wed Jul 16 17:27:40 MDT 2008 mark.collette ICE-2927 : selectInputDate "required" attribute not working
                Files Changed
                Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/selectinputdate/SelectInputDateRenderer.java
                Repository Revision Date User Message
                ICEsoft Public SVN Repository #17188 Wed Jul 16 17:29:54 MDT 2008 mark.collette ICE-2927 : selectInputDate "required" attribute not working
                Files Changed
                Commit graph MODIFY /icefaces/branches/icefaces-1.7/icefaces/component/src/com/icesoft/faces/component/selectinputdate/SelectInputDateRenderer.java
                Repository Revision Date User Message
                ICEsoft Public SVN Repository #17189 Wed Jul 16 17:30:26 MDT 2008 mark.collette ICE-2927 : selectInputDate "required" attribute not working
                Files Changed
                Commit graph MODIFY /icefaces/branches/icefaces-1.7.1/icefaces/component/src/com/icesoft/faces/component/selectinputdate/SelectInputDateRenderer.java
                Hide
                Permalink
                Mark Collette added a comment -

                Made required apply to the non-popup calendar. Since it doesn't have a text input field always being submitted, I gave it a hidden input field.

                TRUNK
                Subversion 17187
                ICEfaces 1.7 branch
                Subversion 17188
                ICEfaces 1.7.1 branch
                Subversion 17189
                icefaces\component\src\com\icesoft\faces\component\selectinputdate\SelectInputDateRenderer.java

                Show
                Mark Collette added a comment - Made required apply to the non-popup calendar. Since it doesn't have a text input field always being submitted, I gave it a hidden input field. TRUNK Subversion 17187 ICEfaces 1.7 branch Subversion 17188 ICEfaces 1.7.1 branch Subversion 17189 icefaces\component\src\com\icesoft\faces\component\selectinputdate\SelectInputDateRenderer.java
                Ken Fyten made changes -
                Security Private [ 10001 ]
                Ken Fyten made changes -
                Fix Version/s 1.7.2RC1 [ 10140 ]
                Fix Version/s 1.7.2 [ 10130 ]
                Ken Fyten made changes -
                Fix Version/s 1.7.2 [ 10130 ]
                Fix Version/s 1.7.2RC1 [ 10140 ]
                Ken Fyten made changes -
                Status Resolved [ 5 ] Closed [ 6 ]
                Assignee Priority P1
                Assignee Mark Collette [ mark.collette ]
                Mark Collette made changes -
                Link This issue is duplicated by ICE-3650 [ ICE-3650 ]
                Hide
                Permalink
                Stuart Campbell added a comment -

                required="true" isn't honoured when the popup is open. When a page is loaded, if the popup is opened, then a submit occurs, it will just submit null without complaint.

                Show
                Stuart Campbell added a comment - required="true" isn't honoured when the popup is open. When a page is loaded, if the popup is opened, then a submit occurs, it will just submit null without complaint.
                Hide
                Permalink
                Ken Fyten added a comment -

                Created new JIRA (ICE-4827) for this follow-on issue.

                Show
                Ken Fyten added a comment - Created new JIRA ( ICE-4827 ) for this follow-on issue.

                  People

                  • Assignee:
                    Unassigned
                    Reporter:
                    Ken Fyten
                  • Votes:
                    2 Vote for this issue
                    Watchers:
                    2 Start watching this issue

                    Dates

                    • Created:
                      Updated:
                      Resolved: