ICEfaces
  1. ICEfaces
  2. ICE-2864

iframe fix for selectInputText has extra slash in the iframe URL

          Details

          • Type: Bug Bug
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 1.6.2, 1.7Beta1
          • Fix Version/s: 1.6.3, 1.7RC1, 1.7
          • Component/s: ICE-Components
          • Labels:
            None
          • Environment:
            IE 6

            Description

            From Ryan Dawson:

            ICE-2065 had been marked as closed but the fix arrived at was not adequate. selectInputText is still causing the secure and nonsecure items warning in IE6. This is because it uses an iframe with a src attribute set to an invalid url (it contains a double forward-slash - '//').

            The fix is a small change to line 4931 of ice-extras.js.
            "src=\""+configuration.connection.context+"/xmlhttp/blank\"
            Should be:
            "src=\""+configuration.connection.context+"xmlhttp/blank\"

              Activity

              Ascending order - Click to sort in descending order
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #16036 Fri Mar 14 14:34:58 MDT 2008 yip.ng ICE-2864
              Removed extra slash in iframe URL.
              Files Changed
              Commit graph MODIFY /icefaces/branches/icefaces-1.6/icefaces/bridge/lib/extras/autocomplete_ext.js
              yip.ng created issue -
              yip.ng made changes -
              Field Original Value New Value
              Assignee Yip Ng [ yip.ng ]
              Hide
              Permalink
              yip.ng added a comment -

              Screenshot showing the fix.

              Show
              yip.ng added a comment - Screenshot showing the fix.
              yip.ng made changes -
              Attachment ScreenHunter_02.jpg [ 10871 ]
              Hide
              Permalink
              yip.ng added a comment -

              Only one instance in 1.6. Trunk version doesn't use configuration.connection.context and uses about:blank as the URL.

              Show
              yip.ng added a comment - Only one instance in 1.6. Trunk version doesn't use configuration.connection.context and uses about:blank as the URL.
              Hide
              Permalink
              yip.ng added a comment -

              about:blank doesn't seem to work, but the configuration.connection.context variable is gone from trunk version. Need to figure out how to get it back, or else figure out where in the renderer to resolve the URL on the server side and pass it to the client side.

              Show
              yip.ng added a comment - about:blank doesn't seem to work, but the configuration.connection.context variable is gone from trunk version. Need to figure out how to get it back, or else figure out where in the renderer to resolve the URL on the server side and pass it to the client side.
              yip.ng made changes -
              Description "ICE-2065 had been marked as closed but the fix arrived at was not adequate. selectInputText is still causing the secure and nonsecure items warning in IE6. This is because it uses an iframe with a src attribute set to an invalid url (it contains a double forward-slash - '//')." From Ryan Dawson:

              ICE-2065 had been marked as closed but the fix arrived at was not adequate. selectInputText is still causing the secure and nonsecure items warning in IE6. This is because it uses an iframe with a src attribute set to an invalid url (it contains a double forward-slash - '//').

              The fix is a small change to line 4931 of ice-extras.js.
              "src=\""+configuration.connection.context+"/xmlhttp/blank\"
              Should be:
              "src=\""+configuration.connection.context+"xmlhttp/blank\"
              Hide
              Permalink
              yip.ng added a comment -

              Screenshot showing the fix in the trunk version.

              Show
              yip.ng added a comment - Screenshot showing the fix in the trunk version.
              yip.ng made changes -
              Attachment screenshot-1.jpg [ 10872 ]
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #16051 Mon Mar 17 17:54:37 MDT 2008 yip.ng ICE-2864
              Changed to use /xmlhttp/blank instead of about:blank in IE 6 iframe fix.
              Files Changed
              Commit graph MODIFY /icefaces/trunk/icefaces/bridge/lib/extras/autocomplete_ext.js
              yip.ng made changes -
              Status Open [ 1 ] Resolved [ 5 ]
              Fix Version/s 1.7 [ 10080 ]
              Fix Version/s 1.6.3 [ 10120 ]
              Resolution Fixed [ 1 ]
              Ken Fyten made changes -
              Fix Version/s 1.7RC1 [ 10123 ]
              Fix Version/s 1.7 [ 10080 ]
              Ken Fyten made changes -
              Fix Version/s 1.7 [ 10080 ]
              Ken Fyten made changes -
              Status Resolved [ 5 ] Closed [ 6 ]
              Assignee Yip Ng [ yip.ng ]

                People

                • Assignee:
                  Unassigned
                  Reporter:
                  yip.ng
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  0 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: