Please review change to GroupRenderer.java. component-showcase should also be revised, but that can be a different JIRA.

Simplified code for component-showcase has been checked in; essentially:

addToPurchases(event.getTargetDragValue());

Changes looks good. closing this case.

Is there a reason in you switched the targetDragValue and targetDropValue on the DropEvent?

Feel free to substitute "why" for "in" in my previous question.

The values appear to be reversed, perhaps due to how the ids are encoded from the JavaScript bridge.

Do you see them reversed in your application code? If so, we should create an additional test case.

I have been testing my application with 1.7Beta1 to try out some of the new features and got some strange behavior out of the DropEvent. The value returned from event.getTargetDragValue() is now the dropValue from the dragged component and event.getTargetDropValue() returns the dragValue of the component it was dropped on.

I tried out 1.7DR#3 which works fine, so I thought it might have something to do with the changes to the GroupRenderer. After looking at the changes I believe the code to retrieve values for a DropEvent needs to be slightly different than that for a DragEvent:

targetDragValue = dndCache.getDragValue(targetID);
targetDropValue = dndCache.getDropValue(panel.getClientId(context));

The current code in the GroupRenderer works only to get values for a DragEvent.

The DropEvent instantiation also should to be changed back to:

DropEvent event = new DropEvent(component, type, targetID,
targetDragValue,
targetDropValue);

I've got a modified version GroupRenderer.java which seems to work for both DragEvents and DropEvents if you would like to see it.

It seems like that the fix might introduced a regression ICE-2753.

Harvey, please post your diff of the GroupRenderer so we can take it into consideration.

Harvey, can you also post a snippet of your page showing which listeners you are using?
(And whether inclusion in a dataTable, etc is necessary to reproduce the problem.)

revision: 15964

Hi Harvey,

Can you please, test your application with the latest change.

Thanks,

I'm attaching the patch from the GroupRenderer I am using.

And here's a snippet of my code. I'm using panelSeries, no dataTables.

<ice:panelSeries id="prototypes" value="#

" var="prototype">
<ice:panelGroup style="cursor:move;" draggable="true" dragOptions="dragGhost"
dragValue="#

">
...
</ice:panelGroup>
</ice:panelSeries>

<ice:panelSeries id="elements" value="#

" var="element">
<ice:panelGroup style="cursor:move;" draggable="true" dragOptions="dragGhost"
dragValue="#

" dropTarget="true"
dropListener="#

"
dropMask="hover_start" hoverclass="seriesHover">
...
</ice:panelGroup>
</ice:panelSeries>

I don't see a revision 15964 in subversion.

I've got that revision now and will test it Monday.

Sorry it took me so long to get back to you. I tested it and it still doesn't work. From my debugging, the only to values I see for dndType in GroupRenderer.decode are "dragdrop" and "DRAG".

If you take a look at the patch file I attached previously, I put the code to retrieve the dragValue and the dropValue inside the if statements that check for a dragListener or a dropListener. I believe this works because the method of retrieving the dragValue and dropValue depends on whether you are creating the event for a dragListener or dropListener. I can't think of all the possible test cases though, so I'm not sure whether this is the best way to do it.