ICEfaces
  1. ICEfaces
  2. ICE-2634

ExternalContext.getRequestHeaderMap and getRequestHeaderValuesMap not implemented

          Details

          • Type: Bug Bug
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 1.7DR#3
          • Fix Version/s: 1.7
          • Component/s: Framework
          • Labels:
            None
          • Environment:
            All ICEfaces; servlet and portlet environments

            Description

            In the code:

               //todo: implement!
                public Map getRequestHeaderMap() {
                    return Collections.EMPTY_MAP;
                }

                //todo: implement!
                public Map getRequestHeaderValuesMap() {
                    return Collections.EMPTY_MAP;
                }

            Unfortunately, an ESRI map renderer component tries to get the user-agent header value from the request and throws an NPE when it's not found. But anyone who is expecting values from empty collections will be disappointed.

              Activity

              Repository Revision Date User Message
              ICEsoft Public SVN Repository #15571 Tue Jan 15 13:32:04 MST 2008 greg.dick ICE-2634 Corrected the implementation of getRequestHeaderMap and getRequestHeaderValuesMap for portlets as per the 1.2 JSF API.
              Files Changed
              Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/webapp/http/portlet/PortletExternalContext.java
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #15570 Tue Jan 15 12:48:32 MST 2008 greg.dick ICE-2634 Corrected the implementation of getRequestHeaderValuesMap as per the 1.2 JSF API.
              Files Changed
              Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/webapp/http/servlet/ServletExternalContext.java
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #15569 Tue Jan 15 12:29:34 MST 2008 greg.dick ICE-2634 Support the requestHeaderValuesMap
              Files Changed
              Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/webapp/http/portlet/PortletExternalContext.java
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #15568 Tue Jan 15 12:29:13 MST 2008 greg.dick ICE-2634 Support the requestHeaderValuesMap
              Files Changed
              Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/webapp/http/servlet/ServletExternalContext.java
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #15567 Tue Jan 15 12:28:34 MST 2008 greg.dick ICE-2634 Added member variables to support the requestHeaderValuesMap
              Files Changed
              Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/context/BridgeExternalContext.java

                People

                • Assignee:
                  Unassigned
                  Reporter:
                  Greg Dick
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  0 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: