ICEfaces
  1. ICEfaces
  2. ICE-2551

JSP parser discards <f:view> attributes

          Details

          • Type: Improvement Improvement
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 1.7DR#3
          • Fix Version/s: 1.7Beta1, 1.7
          • Component/s: Framework
          • Labels:
            None
          • Environment:
            JSP (not Facelets)

            Description

            When using ICE-2419's test application, I found that com.icesoft.faces.webapp.parser.ComponentRuleSet.addRuleInstances(Digester) has a special case for <f:view>, where it doesn't actually save what was parsed into a TagWire. This is because com.icesoft.faces.webapp.parser.Parser.parse(Reader,FacesContext) just makes a new TagWire for the <f:view>, and forces it to be the root TagWire. This means that any attributes on the <f:view> tag are discarded, including the locale attribute.

            We have to add a rule to the Digester, to get it to save the attributes somewhere, where they can be put into the made root TagWire. Then, I believe that ViewTag will have its locale attribute, and be able to set it on the UIViewRoot.

              Issue Links

              blocks

              Bug - A problem which impairs or prevents the functions of the product. ICE-2667 Using *.jsp url mapping for navigate, lifecycle events init(), destroy() are not fired consistently; preprocess(), prerender() at all

              • Major - Major loss of function.
              • Closed

              Bug - A problem which impairs or prevents the functions of the product. ICE-836 Locale change not updated until page refresh

              • Minor - Minor loss of function, or other problem where easy workaround is present.
              • Closed

                Activity

                Ascending order - Click to sort in descending order
                Mark Collette created issue -
                Mark Collette made changes -
                Field Original Value New Value
                Fix Version/s 1.7 [ 10080 ]
                Assignee Priority P1
                Assignee Mark Collette [ mark.collette ]
                Ken Fyten made changes -
                Assignee Priority P1
                Assignee Mark Collette [ mark.collette ] Greg Dick [ greg.dick ]
                Michael Thiem made changes -
                Support Case References https://www.icesoft.ca:4443/supportilla/show_bug.cgi?id=4500
                Greg Dick made changes -
                Status Open [ 1 ] Resolved [ 5 ]
                Fix Version/s 1.7Beta1 [ 10121 ]
                Fix Version/s 1.7 [ 10080 ]
                Resolution Fixed [ 1 ]
                Ken Fyten made changes -
                Link This issue blocks ICE-836 [ ICE-836 ]
                Ken Fyten made changes -
                Summary Our JSP parser discards <f:view> attributes JSP parser discards <f:view> attributes
                Issue Type Bug [ 1 ] Improvement [ 4 ]
                Affects [Compatibility/Configuration]
                Ken Fyten made changes -
                Fix Version/s 1.7 [ 10080 ]
                Ken Fyten made changes -
                Status Resolved [ 5 ] Closed [ 6 ]
                Assignee Greg Dick [ greg.dick ]
                Frank Ye made changes -
                Link This issue blocks ICE-2667 [ ICE-2667 ]

                  People

                  • Assignee:
                    Unassigned
                    Reporter:
                    Mark Collette
                  • Votes:
                    0 Vote for this issue
                    Watchers:
                    0 Start watching this issue

                    Dates

                    • Created:
                      Updated:
                      Resolved: