Details
Description
Wouldn't it be possible to extract the getting viewId logic from MainPortlet.render method to separate protected method To be more precisely, this code:
// Get the inital view that is configured in the portlet.xml file
PortletMode portletMode = renderRequest.getPortletMode();
String viewId = null;
if (portletMode == PortletMode.VIEW) {
viewId = portletConfig.getInitParameter(Constants.VIEW_KEY);
if (viewId == null) {
if (log.isErrorEnabled()) {
log.error(Constants.VIEW_KEY + " is not properly configured");
}
throw new PortletException(Constants.VIEW_KEY + " is not properly configured");
}
} else if (portletMode == PortletMode.EDIT) {
viewId = portletConfig.getInitParameter(Constants.EDIT_KEY);
if (viewId == null) {
if (log.isErrorEnabled()) {
log.error(Constants.EDIT_KEY + " is not properly configured");
}
throw new PortletException(Constants.EDIT_KEY + " is not properly configured");
}
} else if (portletMode == PortletMode.HELP) {
viewId = portletConfig.getInitParameter(Constants.HELP_KEY);
if (viewId == null) {
if (log.isErrorEnabled()) {
log.error(Constants.HELP_KEY + " is not properly configured");
}
throw new PortletException(Constants.HELP_KEY + " is not properly configured");
}
}
It would be useful to have an ability to override this logic in the subclasses. Personally, I'd like to add an ability to show some view based on request parameters.
// Get the inital view that is configured in the portlet.xml file
PortletMode portletMode = renderRequest.getPortletMode();
String viewId = null;
if (portletMode == PortletMode.VIEW) {
viewId = portletConfig.getInitParameter(Constants.VIEW_KEY);
if (viewId == null) {
if (log.isErrorEnabled()) {
log.error(Constants.VIEW_KEY + " is not properly configured");
}
throw new PortletException(Constants.VIEW_KEY + " is not properly configured");
}
} else if (portletMode == PortletMode.EDIT) {
viewId = portletConfig.getInitParameter(Constants.EDIT_KEY);
if (viewId == null) {
if (log.isErrorEnabled()) {
log.error(Constants.EDIT_KEY + " is not properly configured");
}
throw new PortletException(Constants.EDIT_KEY + " is not properly configured");
}
} else if (portletMode == PortletMode.HELP) {
viewId = portletConfig.getInitParameter(Constants.HELP_KEY);
if (viewId == null) {
if (log.isErrorEnabled()) {
log.error(Constants.HELP_KEY + " is not properly configured");
}
throw new PortletException(Constants.HELP_KEY + " is not properly configured");
}
}
It would be useful to have an ability to override this logic in the subclasses. Personally, I'd like to add an ability to show some view based on request parameters.
Activity
- All
- Comments
- History
- Activity
- Remote Attachments
- Subversion
Ken Fyten
made changes -
Status | Resolved [ 5 ] | Closed [ 6 ] |
Assignee | Deryk Sinotte [ deryk.sinotte ] |
Ken Fyten
made changes -
Fix Version/s | 1.7 [ 10080 ] |
Ken Fyten
made changes -
Fix Version/s | 1.7Beta1 [ 10121 ] | |
Fix Version/s | 1.7 [ 10080 ] |
Deryk Sinotte
made changes -
Status | Open [ 1 ] | Resolved [ 5 ] |
Resolution | Fixed [ 1 ] |
Ken Fyten
made changes -
Field | Original Value | New Value |
---|---|---|
Fix Version/s | 1.7 [ 10080 ] | |
Fix Version/s | 1.7DR#3 [ 10112 ] | |
Affects Version/s | 1.7DR#3 [ 10112 ] | |
Affects Version/s | 1.7DR#2 [ 10110 ] |
Vadim Lotarev
created issue -