ICEfaces
  1. ICEfaces
  2. ICE-2541

ICEfaces AHS: further improve exception reporting for when icefaces-ahs.jar is unintentionally added to a deployment

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.7Beta1, 1.7
    • Component/s: None
    • Labels:
      None
    • Environment:
      ICEfaces Asynchronous HTTP Server

      Description

      More exceptions are thrown after the initial NameNotFoundException. We should further improve our exception reporting in these cases.

        Activity

        Ken Fyten made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Assignee Priority P2
        Assignee Jack van Ooststroom [ jack.van.ooststroom ]
        Ken Fyten made changes -
        Fix Version/s 1.7 [ 10080 ]
        Jack Van Ooststroom made changes -
        Status In Progress [ 3 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Jack Van Ooststroom added a comment -

        When an ICEfaces application with the icefaces-ahs.jar is deployed, the AsyncServerDetector automatically tries to instantiate the AsyncHttpServerAdaptingServlet. On instantiation of this servlet it tries to create an instance of the MessagingServiceClient to do its messaging. When this fails an exception is thrown, which avoids the instantiation, and is caught by the AsyncServerDetector. The informative message including any suggestions is logged and the AsyncServerDetector reverts back to not using the Asycnhronous HTTP Server. This avoids a lot of other exceptions being thrown before when it didn't revert back.

        Additionally, when the ContextEventRepeater tries to instantiate the MessagingContextEventPublisher and an exception occurs when the first event (ContextInitializedEvent) is being published using the MessageServiceClient, the ContextEventRepeater will not use the MessagingContextEventPublisher anymore. Again avoiding a lot of other exceptions being thrown before. An informative message including any suggestions is still logged into the server log.

        Marking this one as FIXED.

        Show
        Jack Van Ooststroom added a comment - When an ICEfaces application with the icefaces-ahs.jar is deployed, the AsyncServerDetector automatically tries to instantiate the AsyncHttpServerAdaptingServlet. On instantiation of this servlet it tries to create an instance of the MessagingServiceClient to do its messaging. When this fails an exception is thrown, which avoids the instantiation, and is caught by the AsyncServerDetector. The informative message including any suggestions is logged and the AsyncServerDetector reverts back to not using the Asycnhronous HTTP Server. This avoids a lot of other exceptions being thrown before when it didn't revert back. Additionally, when the ContextEventRepeater tries to instantiate the MessagingContextEventPublisher and an exception occurs when the first event (ContextInitializedEvent) is being published using the MessageServiceClient, the ContextEventRepeater will not use the MessagingContextEventPublisher anymore. Again avoiding a lot of other exceptions being thrown before. An informative message including any suggestions is still logged into the server log. Marking this one as FIXED.
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #15692 Wed Jan 30 16:21:47 MST 2008 jack.van.ooststroom Fixed JIRA ICE-2541 : ICEfaces AHS: further improve exception reporting for when icefaces-ahs.jar is unintentionally added to a deployment
        Files Changed
        Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/util/event/servlet/ContextEventPublisher.java
        Commit graph MODIFY /icefaces/trunk/icefaces/ahs/src/com/icesoft/faces/async/server/AsyncHttpServerAdaptingServlet.java
        Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/webapp/http/core/AsyncServerDetector.java
        Commit graph MODIFY /icefaces/trunk/icefaces/ahs/src/com/icesoft/faces/util/event/servlet/MessagingContextEventPublisher.java
        Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/util/event/servlet/ContextEventRepeater.java
        Jack Van Ooststroom made changes -
        Status Open [ 1 ] In Progress [ 3 ]
        Ken Fyten made changes -
        Fix Version/s 1.7Beta1 [ 10121 ]
        Fix Version/s 1.7 [ 10080 ]
        Ken Fyten made changes -
        Assignee Priority P2
        Jack Van Ooststroom made changes -
        Fix Version/s 1.7 [ 10080 ]
        Hide
        Jack Van Ooststroom added a comment -

        Changed Fix Version(s) to 1.7

        Show
        Jack Van Ooststroom added a comment - Changed Fix Version(s) to 1.7
        Hide
        Jack Van Ooststroom added a comment -

        This is a follow-up to ICE-2540

        Show
        Jack Van Ooststroom added a comment - This is a follow-up to ICE-2540
        Jack Van Ooststroom made changes -
        Field Original Value New Value
        Assignee Jack van Ooststroom [ jack.van.ooststroom ]
        Jack Van Ooststroom created issue -

          People

          • Assignee:
            Unassigned
            Reporter:
            Jack Van Ooststroom
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: