ICEfaces
  1. ICEfaces
  2. ICE-2492

selectInputDate's popup button is wrapping when used in a container with a shorter width

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.6.2
    • Fix Version/s: 1.7DR#3
    • Component/s: ICE-Components
    • Labels:
      None
    • Environment:
      n/a

      Description

      The calendar's popup button will wrap to the next line when the component is placed within a container whose width is less than the selectInputDate's text input + button width. We should set a min-width attribute on the container div to about 170px.
      1. screenshot-1.jpg
        140 kB
      2. screenshot-2.jpg
        140 kB
      3. screenshot-3.jpg
        165 kB
      4. screenshot-4.jpg
        210 kB

        Issue Links

          Activity

          Philip Breau made changes -
          Link This issue is duplicated by ICE-2455 [ ICE-2455 ]
          yip.ng made changes -
          Status Reopened [ 4 ] Closed [ 6 ]
          Resolution Fixed [ 1 ]
          Repository Revision Date User Message
          ICEsoft Public SVN Repository #15513 Tue Jan 08 10:03:35 MST 2008 yip.ng ICE-2492
          Set minimum width of input + button fields of popup calendar.
          Files Changed
          Commit graph MODIFY /icefaces/branches/icefaces-1.6/icefaces/core/src/com/icesoft/faces/resources/css/royale/royale.css
          Commit graph MODIFY /icefaces/branches/icefaces-1.6/icefaces/component/src/com/icesoft/faces/component/CSS_DEFAULT.java
          Commit graph MODIFY /icefaces/branches/icefaces-1.6/icefaces/core/src/com/icesoft/faces/resources/css/xp/xp-portlet.css
          Commit graph MODIFY /icefaces/branches/icefaces-1.6/icefaces/core/src/com/icesoft/faces/resources/css/xp/xp.css
          Commit graph MODIFY /icefaces/branches/icefaces-1.6/icefaces/component/src/com/icesoft/faces/component/selectinputdate/SelectInputDateRenderer.java
          yip.ng made changes -
          Resolution Fixed [ 1 ]
          Status Resolved [ 5 ] Reopened [ 4 ]
          Ken Fyten made changes -
          Issue Type Bug [ 1 ] Improvement [ 4 ]
          yip.ng made changes -
          Status Reopened [ 4 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Hide
          yip.ng added a comment -

          How to test:

          In component-showcase\web\inc\components\selectInputDate.jspx, change the width of the containing div of the popup calendar to below 170px:

          <ice:panelGroup styleClass="formBorderHighlight" style="float: left; width:169px;">

          See the attached screenshots for the test results before and after the fix.

          Show
          yip.ng added a comment - How to test: In component-showcase\web\inc\components\selectInputDate.jspx, change the width of the containing div of the popup calendar to below 170px: <ice:panelGroup styleClass="formBorderHighlight" style="float: left; width:169px;"> See the attached screenshots for the test results before and after the fix.
          yip.ng made changes -
          Attachment screenshot-4.jpg [ 10766 ]
          Hide
          yip.ng added a comment -

          Screenshot after fix.

          Show
          yip.ng added a comment - Screenshot after fix.
          yip.ng made changes -
          Attachment screenshot-3.jpg [ 10765 ]
          Hide
          yip.ng added a comment -

          Screenshot before fix.

          Show
          yip.ng added a comment - Screenshot before fix.
          Repository Revision Date User Message
          ICEsoft Public SVN Repository #15402 Mon Dec 17 16:29:49 MST 2007 yip.ng ICE-2492
          Set minimum width of input + button fields of popup calendar.
          Files Changed
          Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/resources/css/xp/xp-portlet.css
          Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/CSS_DEFAULT.java
          Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/resources/css/xp/xp.css
          Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/resources/css/royale/royale.css
          Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/selectinputdate/SelectInputDateRenderer.java
          yip.ng made changes -
          Resolution Fixed [ 1 ]
          Status Resolved [ 5 ] Reopened [ 4 ]
          Hide
          yip.ng added a comment -

          From Mark:

          I don't think that the change to SelectInputDateRenderer, where you set
          the style on the SelectInputDate, is what we should do. It breaks the
          ability to use ValueBindings to dynamically give different styles.

          Show
          yip.ng added a comment - From Mark: I don't think that the change to SelectInputDateRenderer, where you set the style on the SelectInputDate, is what we should do. It breaks the ability to use ValueBindings to dynamically give different styles.
          yip.ng made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Hide
          yip.ng added a comment -

          How to test:

          In component-showcase\web\css\showcase_style.css, change the width of .calBorderHighlight to below 170px. See the attached screenshots for test results before and after the fix.

          Show
          yip.ng added a comment - How to test: In component-showcase\web\css\showcase_style.css, change the width of .calBorderHighlight to below 170px. See the attached screenshots for test results before and after the fix.
          yip.ng made changes -
          Attachment screenshot-2.jpg [ 10762 ]
          Hide
          yip.ng added a comment -

          Screenshot of the fix.

          Show
          yip.ng added a comment - Screenshot of the fix.
          yip.ng made changes -
          Attachment screenshot-1.jpg [ 10761 ]
          Hide
          yip.ng added a comment -

          Screenshot showing the problem.

          Show
          yip.ng added a comment - Screenshot showing the problem.
          Ken Fyten made changes -
          Fix Version/s 1.7DR#3 [ 10112 ]
          Assignee Yip Ng [ yip.ng ]
          Philip Breau made changes -
          Field Original Value New Value
          Support Case References https://www.icesoft.ca:4443/supportilla/show_bug.cgi?id=4487
          Philip Breau created issue -

            People

            • Assignee:
              yip.ng
              Reporter:
              Philip Breau
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: