ICEfaces
  1. ICEfaces
  2. ICE-2410

occasional NullPointerException with WebMC on GlassFish

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.7DR#2
    • Fix Version/s: 1.7.2
    • Component/s: None
    • Labels:
      None
    • Environment:
      ICEfaces, glassfish-v2-ur1-b08
    • Workaround Exists:
      Yes
    • Workaround Description:
      Hide
      + uri = URI.create("http://" + req.getServerName() + ":"
      + + req.getServerPort() + req.getRequestURI());

      Show
      + uri = URI.create("http://" + req.getServerName() + ":" + + req.getServerPort() + req.getRequestURI());

      Description


      GlassFish/Grizzly integration is now working well with the auctionMonitor, however occasional NullPointerExeptions were seen with WebMC. The following workaround and debugging code was applied for this. The NullPointerException is due to the getScheme() returning null on the request. A current version of GlassFish must be tested with WebMC to verify this.



      +++ src/com/icesoft/faces/webapp/http/servlet/ServletRequestResponse.java (working copy)
      @@ -45,7 +45,18 @@
                   public void servlet(Object request, Object response) {
                       HttpServletRequest req = (HttpServletRequest) request;
                       String query = req.getQueryString();
      - URI uri = URI.create(req.getRequestURL().toString());
      + URI uri = null;
      + try {
      + uri = URI.create(req.getRequestURL().toString());
      + } catch (Exception e) {
      + System.out.println("building our own URI " + e);
      + uri = URI.create("http://" + req.getServerName() + ":"
      + + req.getServerPort() + req.getRequestURI());
      + System.out.println("Constructing URI " + uri + " scheme " + req.getScheme());
      + }
      + }
                       requestURI = (query == null ? uri : URI.create(uri + "?" + query));
                   }

        Activity

        Repository Revision Date User Message
        ICEsoft Public SVN Repository #17203 Tue Jul 22 10:36:35 MDT 2008 ted.goddard reduced null protocol scheme error to debug level logging (ICE-2410)
        Files Changed
        Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/webapp/http/servlet/ServletRequestResponse.java
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #17202 Tue Jul 22 10:36:27 MDT 2008 ted.goddard reduced null protocol scheme error to debug level logging (ICE-2410)
        Files Changed
        Commit graph MODIFY /icefaces/branches/icefaces-1.7/icefaces/core/src/com/icesoft/faces/webapp/http/servlet/ServletRequestResponse.java
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #15309 Thu Dec 06 14:33:41 MST 2007 ted.goddard workaround for null getScheme on glassfish (ICE-2410
        Files Changed
        Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/webapp/http/servlet/ServletEnvironmentRequest.java
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #15245 Mon Nov 26 14:45:53 MST 2007 ted.goddard workaround for null getScheme on GlassFish (ICE-2410)
        Files Changed
        Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/webapp/http/servlet/ServletRequestResponse.java

          People

          • Assignee:
            Unassigned
            Reporter:
            Ted Goddard
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: