ICEfaces
  1. ICEfaces
  2. ICE-2393

XHTML: standard JSF components, <img> should be self-closed

          Details

          • Type: Improvement Improvement
          • Status: Closed
          • Priority: Minor Minor
          • Resolution: Fixed
          • Affects Version/s: 1.6.2
          • Fix Version/s: 1.7Beta1, 1.7
          • Component/s: Framework
          • Labels:
            None
          • Environment:
            All

            Description

            The <ice:graphicImage> component and the <ice:dataTable> component using the scrollable="true" attribute-value pair render <img> elements that have separate </img> closing tags, but the DTD defines <img> as an empty element. So, it is more appropriate to render these components with self-closed <input /> elements.

              Issue Links

              blocks

              Bug - A problem which impairs or prevents the functions of the product. ICE-1114 Accessiblity: Components must support XHTML v1.0 Transitional markup

              • Major - Major loss of function.
              • Closed

              Improvement - An improvement or enhancement to an existing feature or task. ICE-2530 Add better xml support (VALID xml support) to icefaces

              • Major - Major loss of function.
              • Closed

                Activity

                Descending order - Click to sort in ascending order
                Ken Fyten made changes -
                Status Resolved [ 5 ] Closed [ 6 ]
                Ken Fyten made changes -
                Fix Version/s 1.7 [ 10080 ]
                Ken Fyten made changes -
                Fix Version/s 1.7Beta1 [ 10121 ]
                Fix Version/s 1.7 [ 10080 ]
                Assignee Greg Dick [ greg.dick ]
                Ken Fyten made changes -
                Priority Major [ 3 ] Minor [ 4 ]
                Greg Dick made changes -
                Status Open [ 1 ] Resolved [ 5 ]
                Resolution Fixed [ 1 ]
                Hide
                Permalink
                Greg Dick added a comment -

                I checked the code with 2530, it seems correct, and addresses a number of problems in the existing code. I checked the xhtml documentation and found these tags that seem candidates for short form tags.

                "img, input, br, hr, meta, base, link, frame, col, area"

                The patch allows for attributes of <br> to be encoded properly.

                Show
                Greg Dick added a comment - I checked the code with 2530, it seems correct, and addresses a number of problems in the existing code. I checked the xhtml documentation and found these tags that seem candidates for short form tags. "img, input, br, hr, meta, base, link, frame, col, area" The patch allows for attributes of <br> to be encoded properly.
                Repository Revision Date User Message
                ICEsoft Public SVN Repository #15587 Thu Jan 17 12:49:00 MST 2008 greg.dick ICE-2393 Allow short termination of certain HTML tags
                Files Changed
                Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/util/DOMUtils.java
                Hide
                Permalink
                Mark Collette added a comment -

                ICE-2530 has a code patch to accomplish this.

                Show
                Mark Collette added a comment - ICE-2530 has a code patch to accomplish this.
                Ken Fyten made changes -
                Assignee Ted Goddard [ ted.goddard ] Greg Dick [ greg.dick ]
                Ken Fyten made changes -
                Link This issue blocks ICE-2530 [ ICE-2530 ]
                Ken Fyten made changes -
                Component/s Framework [ 10013 ]
                Component/s Components [ 10012 ]
                Ken Fyten made changes -
                Assignee Adnan Durrani [ adnan.durrani ] Ted Goddard [ ted.goddard ]
                Ken Fyten made changes -
                Fix Version/s 1.7 [ 10080 ]
                Assignee Arturo Zambrano [ artzambrano ] Adnan Durrani [ adnan.durrani ]
                Ken Fyten made changes -
                Link This issue blocks ICE-1114 [ ICE-1114 ]
                Arturo Zambrano made changes -
                Field Original Value New Value
                Assignee Arturo Zambrano [ artzambrano ]
                Arturo Zambrano created issue -

                  People

                  • Assignee:
                    Unassigned
                    Reporter:
                    Arturo Zambrano
                  • Votes:
                    0 Vote for this issue
                    Watchers:
                    0 Start watching this issue

                    Dates

                    • Created:
                      Updated:
                      Resolved: