ICEfaces
  1. ICEfaces
  2. ICE-2367

Allow panelTabSet to change tabs without validation

          Details

          • Type: Improvement Improvement
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 1.7DR#2
          • Fix Version/s: 1.7.1
          • Component/s: ICE-Components
          • Labels:
            None
          • Environment:
            All

            Description

            First off, I'm not saying that panelTabSet should always switch tabs without validation, just that it should have an attribute that can determine if it does or not. Something like "immediate" should suffice.

              Issue Links

              blocks

              Bug - A problem which impairs or prevents the functions of the product. ICE-2353 unable to switch between tabs when if panelTabSet is embedded in panelCollapsible

              • Major - Major loss of function.
              • Closed

                Activity

                Ascending order - Click to sort in descending order
                Mark Collette created issue -
                Mark Collette made changes -
                Field Original Value New Value
                Link This issue blocks ICE-2353 [ ICE-2353 ]
                Hide
                Permalink
                Michael Thiem added a comment -

                default behaviour until 1.6.1 was that validation errors prevented a tab change. since 1.6.2 it is just the other way round and validation errors do allow tab changes. seems there's a regression since 1.6.2. However an additional attribute would solve the issue for both cases.

                Show
                Michael Thiem added a comment - default behaviour until 1.6.1 was that validation errors prevented a tab change. since 1.6.2 it is just the other way round and validation errors do allow tab changes. seems there's a regression since 1.6.2. However an additional attribute would solve the issue for both cases.
                Ken Fyten made changes -
                Fix Version/s 1.7.1 [ 10122 ]
                Assignee Priority P2
                Assignee Adnan Durrani [ adnan.durrani ]
                Michael Thiem made changes -
                Support Case References https://www.icesoft.ca:4443/supportilla/show_bug.cgi?id=4815
                Adnan Durrani made changes -
                Status Open [ 1 ] In Progress [ 3 ]
                Hide
                Permalink
                Ken Fyten added a comment -

                After some consideration it seems that the expected behavior in this case would be that the tab would not switch if a component on the form was in an invalid state. This would be consistent with any other component that could fire an action event (button).

                However, in order to provide more flexibility to component users it would also be a good idea to add support for both the 'immediate' and 'partialSubmit' attributes to the panelTabSet component.

                Developers could override the default behavior via 'immediate=true' if desired, thus having the panels switch regardless of the state of the components within them.

                Setting 'partialSubmit=false' would allow the panelTabSet to enforce the 'required=true' attributes on any input components on the visible tab (or in the form, for that matter).

                Does this seem reasonable?

                Show
                Ken Fyten added a comment - After some consideration it seems that the expected behavior in this case would be that the tab would not switch if a component on the form was in an invalid state. This would be consistent with any other component that could fire an action event (button). However, in order to provide more flexibility to component users it would also be a good idea to add support for both the 'immediate' and 'partialSubmit' attributes to the panelTabSet component. Developers could override the default behavior via 'immediate=true' if desired, thus having the panels switch regardless of the state of the components within them. Setting 'partialSubmit=false' would allow the panelTabSet to enforce the 'required=true' attributes on any input components on the visible tab (or in the form, for that matter). Does this seem reasonable?
                Repository Revision Date User Message
                ICEsoft Public SVN Repository #16651 Fri May 16 10:17:33 MDT 2008 adnan.durrani Fix for ICE-2367 (Allow panelTabSet to change tabs without validation)
                Files Changed
                Commit graph MODIFY /icefaces/trunk/icefaces/component-metadata/src/main/resources/conf/ice_cust_properties/cust-paneltabset-props.xml
                Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/paneltabset/PanelTabSetRenderer.java
                Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/paneltabset/PanelTabSet.java
                Hide
                Permalink
                Adnan Durrani added a comment -

                trunk: revision 16651

                Following two attributes added to the panelTabSet:

                • partialSubmit (default value true)
                • immediate

                To stop the validation on tabchange the immediate attribute can be set to true.
                Tabchange uses partialSubmit by default, to use the full submit set the partialSubmit to false.

                Show
                Adnan Durrani added a comment - trunk: revision 16651 Following two attributes added to the panelTabSet: partialSubmit (default value true) immediate To stop the validation on tabchange the immediate attribute can be set to true. Tabchange uses partialSubmit by default, to use the full submit set the partialSubmit to false.
                Adnan Durrani made changes -
                Status In Progress [ 3 ] Resolved [ 5 ]
                Resolution Fixed [ 1 ]
                Hide
                Permalink
                Ken Fyten added a comment -

                Need this applied to the icefaces-1.7 branch for 1.7.1 also.

                Show
                Ken Fyten added a comment - Need this applied to the icefaces-1.7 branch for 1.7.1 also.
                Ken Fyten made changes -
                Resolution Fixed [ 1 ]
                Status Resolved [ 5 ] Reopened [ 4 ]
                Assignee Priority P2 P1
                Repository Revision Date User Message
                ICEsoft Public SVN Repository #16680 Fri May 23 10:41:28 MDT 2008 adnan.durrani Fix for ICE-2367 (Allow panelTabSet to change tabs without validation)
                Files Changed
                Commit graph MODIFY /icefaces/branches/icefaces-1.7/icefaces/component/src/com/icesoft/faces/component/paneltabset/PanelTabSetRenderer.java
                Commit graph MODIFY /icefaces/branches/icefaces-1.7/icefaces/component/src/com/icesoft/faces/component/paneltabset/PanelTabSet.java
                Commit graph MODIFY /icefaces/branches/icefaces-1.7/icefaces/component-metadata/src/main/resources/conf/ice_cust_properties/cust-paneltabset-props.xml
                Hide
                Permalink
                Adnan Durrani added a comment -

                branch 1.7 revision 16680

                Show
                Adnan Durrani added a comment - branch 1.7 revision 16680
                Adnan Durrani made changes -
                Status Reopened [ 4 ] Resolved [ 5 ]
                Resolution Fixed [ 1 ]
                Ken Fyten made changes -
                Issue Type New Feature [ 2 ] Improvement [ 4 ]
                Ken Fyten made changes -
                Status Resolved [ 5 ] Closed [ 6 ]
                Assignee Priority P1
                Assignee Adnan Durrani [ adnan.durrani ]
                Repository Revision Date User Message
                ICEsoft Public SVN Repository #18887 Fri May 15 18:00:28 MDT 2009 mark.collette ICE-2367 : Allow panelTabSet to change tabs without validation REGRESSION
                Files Changed
                Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/paneltabset/PanelTabSet.java
                Hide
                Permalink
                Mark Collette added a comment -

                Reverted a change I'd made, back to Adnan's commit, to fix a regression.

                Subversion 18887
                icefaces\component\src\com\icesoft\faces\component\paneltabset\PanelTabSet.java

                Show
                Mark Collette added a comment - Reverted a change I'd made, back to Adnan's commit, to fix a regression. Subversion 18887 icefaces\component\src\com\icesoft\faces\component\paneltabset\PanelTabSet.java
                Repository Revision Date User Message
                ICEsoft Public SVN Repository #19900 Wed Dec 09 10:26:15 MST 2009 adnan.durrani 1.8.2EE panelTabset changes moved to Compat panelTabset towards ICE-4481. The changes include the fix of following JIRAs: ICE-2367, ICE-4623, ICE-4638, ICE-4642, ICE-4645, ICE-4649, ICE-4656, ICE-4737, ICE-4746, ICE-5050
                Files Changed
                Commit graph MODIFY /icefaces/scratchpads/glimmer/compat/components/src/main/java/com/icesoft/faces/component/paneltabset/PanelTab.java
                Commit graph MODIFY /icefaces/scratchpads/glimmer/compat/samples/component-showcase/web/WEB-INF/includes/examples/panel/panelTabSet-dynamic.xhtml
                Commit graph MODIFY /icefaces/scratchpads/glimmer/compat/core/src/main/resources/css/com/icesoft/faces/resources/css/xp/xp.css
                Commit graph MODIFY /icefaces/scratchpads/glimmer/compat/core/src/main/resources/css/com/icesoft/faces/resources/css/rime/rime.css
                Commit graph MODIFY /icefaces/scratchpads/glimmer/compat/core/src/main/resources/META-INF/resources/ice-extras.js
                Commit graph MODIFY /icefaces/scratchpads/glimmer/compat/component-metadata/src/main/resources/conf/ice_cust_properties/cust-paneltabset-props.xml
                Commit graph MODIFY /icefaces/scratchpads/glimmer/compat/core/src/main/resources/css/com/icesoft/faces/resources/css/royale/royale.css
                Commit graph MODIFY /icefaces/scratchpads/glimmer/compat/core/src/main/resources/css/com/icesoft/faces/resources/css/xp/xp-portlet.css
                Commit graph MODIFY /icefaces/scratchpads/glimmer/compat/samples/component-showcase/src/org/icefaces/application/showcase/view/bean/examples/layoutPanel/panelTabset/DynamicTabSetBean.java
                Commit graph MODIFY /icefaces/scratchpads/glimmer/compat/component-metadata/src/main/resources/conf/custom/paneltab-renderer.xml
                Commit graph MODIFY /icefaces/scratchpads/glimmer/compat/components/src/main/java/com/icesoft/faces/component/paneltabset/PanelTabSet.java
                Commit graph MODIFY /icefaces/scratchpads/glimmer/compat/components/src/main/java/com/icesoft/faces/component/paneltabset/PanelTabSetRenderer.java
                Commit graph MODIFY /icefaces/scratchpads/glimmer/compat/core/src/main/resources/css/com/icesoft/faces/resources/css/rime/rime-portlet.css

                  People

                  • Assignee:
                    Unassigned
                    Reporter:
                    Mark Collette
                  • Votes:
                    7 Vote for this issue
                    Watchers:
                    2 Start watching this issue

                    Dates

                    • Created:
                      Updated:
                      Resolved: