Details
New Feature
Description
What would be preferable is if we programmatically overrode these relationships, maintaining the defaults, so that depending on the context of the request, we could return either the stock renderers or the ICEfaces D2D renderers, all within the same application.
Technically, all of the encode and decode methods make use of UIComponentBase.getRenderer(FacesContext) to find the Renderer. It gets the RenderKit from the FacesContext, and asks it for the Renderer. We could employ several approaches:
A) Have our BridgeFacesContext return a different RenderKit, that would return the ICEfaces Renderers, leaving the regular FacesContext to return the regular RenderKit with the stock Renderers
B) Capture the stock renderers, and wrap them into proxy renderers, which will use the stock of ICEfaces ones appropriately
Care should be taken to make this work with our
Issue Links
- blocks
-
ICE-3738
DesignTime does override default Renderer
-
- Closed
-
Activity
| Field | Original Value | New Value |
|---|---|---|
| Fix Version/s | 1.8DR#1 [ 10141 ] | |
| Assignee | Mark Collette [ mark.collette ] |
| Affects | [Documentation (User Guide, Ref. Guide, etc.), Sample App./Tutorial, Compatibility/Configuration] |
| Fix Version/s | 1.8DR#2 [ 10142 ] | |
| Fix Version/s | 1.8DR#1 [ 10141 ] |
We need to make sure that we're handling the renderKitId as we should. There are methods in the JSF 1.2 code, in ViewHandlerImpl and FacesContextImpl that deal with renderKitId, defaultRenderKitId, and RenderKit, that we should make sure our D2DViewHandler and BridgeFacesContext do equivalently. Those have to be tested with state saving turned off, and turned on.
One this is in place, then we can remove the default-renderkit-id entry from icefaces.jar's faces-config.xml. This will have the side-effect of simplifying the design-time scenario, which will go back to using the HTML_BASIC RenderKit, that doesn't include our h: D2D Renderers.
| Fix Version/s | 1.8DR#3 [ 10143 ] | |
| Fix Version/s | 1.8DR#2 [ 10142 ] |
| Fix Version/s | 1.8DR#3 [ 10143 ] | |
| Assignee | Mark Collette [ mark.collette ] |
ICEfaces 2 doesn't override the default renderers, and we can control on a page by page basis if ICEfaces is being used.
| Status | Open [ 1 ] | Resolved [ 5 ] |
| Fix Version/s | 2.0.0 [ 10230 ] | |
| Resolution | Fixed [ 1 ] |
| Status | Resolved [ 5 ] | Closed [ 6 ] |
Given the functionality in ICE-3543, we should be able to just flip between RenderKits, when we're on different types of pages, using the ICEfacesRenderKit one for ICEfaces pages, and the HTML_BASIC for non-ICEfaces pages.
It might be as simple as modifying how we set the UIViewRoot's renderKitId, potentially by overriding ViewHandler.calculateRenderKitId(FacesContext).