ICEfaces
  1. ICEfaces
  2. ICE-2233

<ice:panelTab/> label property doesn't render properly under XP theme in IE within Liferay

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.7DR#3, 1.7
    • Component/s: None
    • Labels:
      None
    • Environment:
      Tomcat 6.0.13 / Liferay 4.3.3

      Description

      This only happens under IE, and not under FF.

      It has to do with this setting in xp-portlet.css:

      .icePnlTbOn .MidMid a {
          display: block;
      }

      Because when I change it to "inline" the problem goes away, but then the padding isn't right.

      In order to reproduce, download the sample-icefaces-sun-portlet from the Liferay website, and edit the JobApplication.jspx file, so that there are two panelTabs instead of only one.

      Then, when you place the portlet on a Liferay portal page, and then click back and forth between tabs, you will see the labels of the tabs shifted way to the right, and getting clipped along the right hand side.
      1. screenshot-1.jpg
        13 kB
      2. screenshot-2.jpg
        111 kB
      3. screenshot-3.jpg
        96 kB

        Activity

        Neil Griffin created issue -
        Hide
        Neil Griffin added a comment -

        screenshot indicates how the labels are messed up

        Show
        Neil Griffin added a comment - screenshot indicates how the labels are messed up
        Neil Griffin made changes -
        Field Original Value New Value
        Attachment screenshot-1.jpg [ 10702 ]
        Ken Fyten made changes -
        Fix Version/s 1.7 [ 10080 ]
        Assignee Yip Ng [ yip.ng ]
        Hide
        yip.ng added a comment -

        I can't reproduce the problem. I have installed the Liferay 4.3.3/Tomcat 6 bundle and the sample app. and clicked on the tabs many times, as described. See the attached screenshot.

        Show
        yip.ng added a comment - I can't reproduce the problem. I have installed the Liferay 4.3.3/Tomcat 6 bundle and the sample app. and clicked on the tabs many times, as described. See the attached screenshot.
        yip.ng made changes -
        Attachment screenshot-2.jpg [ 10716 ]
        Hide
        Neil Griffin added a comment -

        Did you try it with IE? I know some of you are Safari types.

        Show
        Neil Griffin added a comment - Did you try it with IE? I know some of you are Safari types.
        Hide
        Deryk Sinotte added a comment -

        Yip's screenshot shows that it's being run in IE. What version of IE is everyone trying this on?

        Show
        Deryk Sinotte added a comment - Yip's screenshot shows that it's being run in IE. What version of IE is everyone trying this on?
        Hide
        yip.ng added a comment -

        I just checked my IE version. It's IE6.

        Show
        yip.ng added a comment - I just checked my IE version. It's IE6.
        Hide
        Deryk Sinotte added a comment -

        And while we're at it, which version of ICEfaces?

        Show
        Deryk Sinotte added a comment - And while we're at it, which version of ICEfaces?
        Hide
        Neil Griffin added a comment -

        Oops, sorry about that.

        I'm running IE7. Also, please clear your browser cache just in case.

        Thanks,

        Neil

        Show
        Neil Griffin added a comment - Oops, sorry about that. I'm running IE7. Also, please clear your browser cache just in case. Thanks, Neil
        Hide
        Neil Griffin added a comment -

        If it can't be reproduced with ICEfaces 1.6 (bundled with the sample portlet), then please replace the ICEFaces JARs in WEB-INF/lib with the ones in the trunk.

        I'm working primary with the trunk right now on a real-world application, trying to put it to the test.

        Show
        Neil Griffin added a comment - If it can't be reproduced with ICEfaces 1.6 (bundled with the sample portlet), then please replace the ICEFaces JARs in WEB-INF/lib with the ones in the trunk. I'm working primary with the trunk right now on a real-world application, trying to put it to the test.
        Hide
        yip.ng added a comment -

        OK. I have installed IE7 and can reproduce the bug now with the downloaded sample app.

        Show
        yip.ng added a comment - OK. I have installed IE7 and can reproduce the bug now with the downloaded sample app.
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #15062 Wed Oct 31 14:44:07 MDT 2007 yip.ng ICE-2233
        Changed the IE CSS hack (Holly Hack?) for panel tabs to use height instead of width.
        Files Changed
        Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/resources/css/xp/xp-portlet.css
        Hide
        yip.ng added a comment -

        Testing the fix. Both tabs have been clicked on many times.

        Show
        yip.ng added a comment - Testing the fix. Both tabs have been clicked on many times.
        yip.ng made changes -
        Attachment screenshot-3.jpg [ 10717 ]
        yip.ng made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Neil Griffin added a comment -

        Tested and confirmed fixed. Recommend closing it out.

        Show
        Neil Griffin added a comment - Tested and confirmed fixed. Recommend closing it out.
        Ken Fyten made changes -
        Fix Version/s 1.7DR#3 [ 10112 ]
        Fix Version/s 1.7 [ 10080 ]
        Ken Fyten made changes -
        Fix Version/s 1.7 [ 10080 ]
        Ken Fyten made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Assignee Yip Ng [ yip.ng ]

          People

          • Assignee:
            Unassigned
            Reporter:
            Neil Griffin
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: