ICEfaces
  1. ICEfaces
  2. ICE-2231

Allow <ice:menuItems> tag inside <ice:menuItem>

          Details

          • Type: Improvement Improvement
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 1.6.1
          • Fix Version/s: 1.7DR#3, 1.7
          • Component/s: ICE-Components
          • Labels:
            None
          • Environment:
            Windows XP SP2,
            Weblogic 9.2

            Description

            Now <ice:menuItems> have to be only inside <ice:menuBar>.
            But <ice:menuItem> can contain other <ice:menuItem>.
            So analogically <ice:menuItems> should be allowed to be inside <ice:menuItem>.

              Activity

              Ascending order - Click to sort in descending order
              Marcin Dabrowski created issue -
              Ken Fyten made changes -
              Field Original Value New Value
              Summary Allow <ice:menuItems> tag isnide <ice:menuItem> Allow <ice:menuItems> tag inside <ice:menuItem>
              Fix Version/s 1.7 [ 10080 ]
              Ken Fyten made changes -
              Assignee Mark Collette [ mark.collette ]
              Ken Fyten made changes -
              Fix Version/s 1.7DR#3 [ 10112 ]
              Fix Version/s 1.7 [ 10080 ]
              Affects [Documentation (User Guide, Ref. Guide, etc.)]
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #15225 Wed Nov 21 18:47:07 MST 2007 mark.collette ICE-2231 : Allow <ice:menuItems> tag inside <ice:menuItem>
              Files Changed
              Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/menubar/MenuItemsRenderer.java
              Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/menubar/MenuItemRenderer.java
              Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/menubar/MenuItem.java
              Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/menubar/MenuItemBase.java
              Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/menubar/MenuItems.java
              Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/menubar/MenuBar.java
              Hide
              Permalink
              Mark Collette added a comment -

              I made it allow ice:menuItems inside of ice:menuItem, and I also fixed some duplicate recursion on decode, which made several ActionEvents get broadcast if you had an actionListener.

              Subversion 15225
              icefaces\component\src\com\icesoft\faces\component\menubar\MenuBar.java
              icefaces\component\src\com\icesoft\faces\component\menubar\MenuItem.java
              icefaces\component\src\com\icesoft\faces\component\menubar\MenuItemBase.java
              icefaces\component\src\com\icesoft\faces\component\menubar\MenuItemRenderer.java
              icefaces\component\src\com\icesoft\faces\component\menubar\MenuItems.java
              icefaces\component\src\com\icesoft\faces\component\menubar\MenuItemsRenderer.java

              Show
              Mark Collette added a comment - I made it allow ice:menuItems inside of ice:menuItem, and I also fixed some duplicate recursion on decode, which made several ActionEvents get broadcast if you had an actionListener. Subversion 15225 icefaces\component\src\com\icesoft\faces\component\menubar\MenuBar.java icefaces\component\src\com\icesoft\faces\component\menubar\MenuItem.java icefaces\component\src\com\icesoft\faces\component\menubar\MenuItemBase.java icefaces\component\src\com\icesoft\faces\component\menubar\MenuItemRenderer.java icefaces\component\src\com\icesoft\faces\component\menubar\MenuItems.java icefaces\component\src\com\icesoft\faces\component\menubar\MenuItemsRenderer.java
              Mark Collette made changes -
              Status Open [ 1 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Hide
              Permalink
              Mark Collette added a comment -

              To test this feature, add the following snippets into the component-showcase:

              icefaces\samples\component-showcase\src\com\icesoft\icefaces\samples\showcase\components\menuBar\MenuBarBean.java

              private List menuModel;

              public MenuBarBean()

              { menuModel = buildMenuModel(); }

              private List buildMenuModel() {
              List list = new ArrayList();
              for(int i = 0; i < 3; i++) {
              MenuItem mi = new MenuItem();
              mi.setIcon("xmlhttp/css/xp/css-images/tree_folder_close.gif");
              mi.setValue("Dynamic " + i);
              list.add( mi );
              for(int j = 0; j < 3; j++)

              { MenuItem sub = new MenuItem(); sub.setIcon("xmlhttp/css/xp/css-images/tree_document.gif"); sub.setValue("sub_"+i+"_"+j); mi.getChildren().add( sub ); }

              }
              return list;
              }

              public List getMenuModel()

              { return menuModel; }

              icefaces\samples\component-showcase\web\inc\components\menuBar.jspx
              [Anywhere inside an ice:menuItem tag. Plus, it should also work right inside the ice:menuBar or ice:menuPopup tags]

              <ice:menuItems value="#

              {menuBar.menuModel}

              " actionListener="#

              {menuBar.primaryListener}

              "/>

              Show
              Mark Collette added a comment - To test this feature, add the following snippets into the component-showcase: icefaces\samples\component-showcase\src\com\icesoft\icefaces\samples\showcase\components\menuBar\MenuBarBean.java private List menuModel; public MenuBarBean() { menuModel = buildMenuModel(); } private List buildMenuModel() { List list = new ArrayList(); for(int i = 0; i < 3; i++) { MenuItem mi = new MenuItem(); mi.setIcon("xmlhttp/css/xp/css-images/tree_folder_close.gif"); mi.setValue("Dynamic " + i); list.add( mi ); for(int j = 0; j < 3; j++) { MenuItem sub = new MenuItem(); sub.setIcon("xmlhttp/css/xp/css-images/tree_document.gif"); sub.setValue("sub_"+i+"_"+j); mi.getChildren().add( sub ); } } return list; } public List getMenuModel() { return menuModel; } icefaces\samples\component-showcase\web\inc\components\menuBar.jspx [Anywhere inside an ice:menuItem tag. Plus, it should also work right inside the ice:menuBar or ice:menuPopup tags] <ice:menuItems value="# {menuBar.menuModel} " actionListener="# {menuBar.primaryListener} "/>
              Ken Fyten made changes -
              Fix Version/s 1.7 [ 10080 ]
              Ken Fyten made changes -
              Status Resolved [ 5 ] Closed [ 6 ]
              Assignee Mark Collette [ mark.collette ]
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #18059 Mon Dec 15 17:59:49 MST 2008 yip.ng ICE-2231
              Changed to relink the child menu items to their (new) parents to work when state saving is on.
              Files Changed
              Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/menubar/MenuItems.java

                People

                • Assignee:
                  Unassigned
                  Reporter:
                  Marcin Dabrowski
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  1 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: