ICEfaces
  1. ICEfaces
  2. ICE-2213

Portlet menu styling

          Details

          • Type: Bug Bug
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 1.7DR#1
          • Fix Version/s: 1.7DR#3, 1.7
          • Component/s: ICE-Components
          • Labels:
            None
          • Environment:
            All

            Description

            I don't think that our portlet menu CSS style classes are used properly. We differentiate between classes for top level menus, and submenus, whereas they differentiate between menuitems that are leafs versus menuitems that lead to submenus.

            http://www.ja-sig.org/wiki/display/UPC/JSR-168+PLT.C+CSS+Style+Definitions+section


            public class com.icesoft.faces.component.PORTLET_CSS_DEFAULT {
                                  //PLT.C.6 Menus
              public static final String PORTLET_MENU = "portlet-menu"; // (menuBar)
              public static final String PORTLET_MENU_ITEM = "portlet-menu-item"; // (root level menuItem)
              public static final String PORTLET_MENU_ITEM_HOVER = "portlet-menu-item-hover"; // (root level menuItem:hover)
              public static final String PORTLET_MENU_CASCADE_ITEM = "portlet-menu-cascade-item"; // (submenu menuItem)
            }

              Activity

              Ascending order - Click to sort in descending order
              Mark Collette created issue -
              Ken Fyten made changes -
              Field Original Value New Value
              Fix Version/s 1.7DR#2 [ 10110 ]
              Assignee Priority P2
              Assignee Mark Collette [ mark.collette ]
              Ken Fyten made changes -
              Assignee Mark Collette [ mark.collette ] Yip Ng [ yip.ng ]
              Ken Fyten made changes -
              Fix Version/s 1.7DR#3 [ 10112 ]
              Fix Version/s 1.7DR#2 [ 10110 ]
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #15005 Mon Oct 22 17:46:33 MDT 2007 yip.ng ICE-2213
              Set portlet menu style classes according to the specification.
              Files Changed
              Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/menubar/MenuItemRenderer.java
              Commit graph MODIFY /icefaces/trunk/icefaces/bridge/component/menu.js
              Hide
              Permalink
              yip.ng added a comment -

              Screenshot of test results.

              Show
              yip.ng added a comment - Screenshot of test results.
              yip.ng made changes -
              Attachment screenshot-1.jpg [ 10707 ]
              Hide
              Permalink
              yip.ng added a comment -

              How to test:

              In core\src\com\icesoft\faces\util\CoreUtils.java

              in the method addPortletStyleClassToQualifiedClass(String qualifiedStyleClass, String defaultClass, String portletClass, boolean disabled)

              change the if condition to be always true:
              // if (isPortletEnvironment() && isRenderPortletStyleClass()) {
              if (true) {

              In component showcase, go to the menu bar example. Use Firebug to inspect the style classes as you select or hover over a menu item. (See the attached screenshot.)

              Show
              yip.ng added a comment - How to test: In core\src\com\icesoft\faces\util\CoreUtils.java in the method addPortletStyleClassToQualifiedClass(String qualifiedStyleClass, String defaultClass, String portletClass, boolean disabled) change the if condition to be always true: // if (isPortletEnvironment() && isRenderPortletStyleClass()) { if (true) { In component showcase, go to the menu bar example. Use Firebug to inspect the style classes as you select or hover over a menu item. (See the attached screenshot.)
              yip.ng made changes -
              Status Open [ 1 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Ken Fyten made changes -
              Fix Version/s 1.7 [ 10080 ]
              Ken Fyten made changes -
              Status Resolved [ 5 ] Closed [ 6 ]
              Assignee Priority P2
              Assignee Yip Ng [ yip.ng ]

                People

                • Assignee:
                  Unassigned
                  Reporter:
                  Mark Collette
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  1 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: