ICEfaces
  1. ICEfaces
  2. ICE-2202

Clean up abandoned views more aggressively and reliably

          Details

          • Type: Improvement Improvement
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 1.6.1
          • Fix Version/s: 1.6.2, 1.7DR#2, 1.7
          • Component/s: Framework
          • Labels:
            None
          • Environment:
            server

            Description

            See forum link.

              Activity

              Ascending order - Click to sort in descending order
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #14916 Tue Oct 09 18:13:32 MDT 2007 mircea.toma Dispose FacesContext and ExternalContext before replacing them with new instances -- ICE-2202
              Files Changed
              Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/context/View.java
              Mircea Toma created issue -
              Mircea Toma made changes -
              Field Original Value New Value
              Assignee Mircea Toma [ mircea.toma ]
              Mircea Toma made changes -
              Status Open [ 1 ] In Progress [ 3 ]
              Hide
              Permalink
              Mircea Toma added a comment -

              Dispose FacesContext and ExternalContext before replacing them with new instances.

              Show
              Mircea Toma added a comment - Dispose FacesContext and ExternalContext before replacing them with new instances.
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #14936 Thu Oct 11 15:07:39 MDT 2007 mircea.toma Send 'dispose-view' message more reliably -- ICE-2202
              Files Changed
              Commit graph MODIFY /icefaces/trunk/icefaces/bridge/src/connection.async.js
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #14947 Fri Oct 12 11:27:49 MDT 2007 mircea.toma Dispose FacesContext and ExternalContext before replacing them with new instances -- ICE-2202
              Files Changed
              Commit graph MODIFY /icefaces/branches/icefaces-1.6/icefaces/core/src/com/icesoft/faces/context/View.java
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #14948 Fri Oct 12 11:28:51 MDT 2007 mircea.toma Send 'dispose-view' message more reliably -- ICE-2202
              Files Changed
              Commit graph MODIFY /icefaces/branches/icefaces-1.6/icefaces/bridge/src/connection.js
              Commit graph MODIFY /icefaces/branches/icefaces-1.6/icefaces/bridge/src/connection.async.js
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #14949 Fri Oct 12 11:31:58 MDT 2007 mircea.toma Send 'dispose-view' message more reliably -- ICE-2202
              Files Changed
              Commit graph MODIFY /icefaces/trunk/icefaces/bridge/src/connection.js
              Mircea Toma made changes -
              Fix Version/s 1.6.2 [ 10111 ]
              Fix Version/s 1.7DR#2 [ 10110 ]
              Mircea Toma made changes -
              Status In Progress [ 3 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Hide
              Permalink
              Ken Fyten added a comment -

              Also modified the bridge JS to Send 'dispose-view' message more reliably from certain browsers.

              Show
              Ken Fyten added a comment - Also modified the bridge JS to Send 'dispose-view' message more reliably from certain browsers.
              Ken Fyten made changes -
              Summary Memory leak in core framework Clean up abandoned views more aggressively and reliabiy
              Issue Type Bug [ 1 ] Improvement [ 4 ]
              Component/s Framework [ 10013 ]
              Assignee Mircea Toma [ mircea.toma ]
              Ken Fyten made changes -
              Summary Clean up abandoned views more aggressively and reliabiy Clean up abandoned views more aggressively and reliably
              Hide
              Permalink
              Mircea Toma added a comment -

              There is an edge case that should be handled by a fix for ICE-1627. It happens when a redirect navigation rule is executed and then the window is closed.
              When the redirect is executed ICEfaces appends the 'rvn' parameter to the redirected URL so that the view instance is reused for the next page. Since the view instance is supposed to be reused, the bridge will cancel the 'dispose-views' message that it usually sends once the window's document is unloaded otherwise the view instance needed by the next page would be disposed.

              Show
              Mircea Toma added a comment - There is an edge case that should be handled by a fix for ICE-1627 . It happens when a redirect navigation rule is executed and then the window is closed. When the redirect is executed ICEfaces appends the 'rvn' parameter to the redirected URL so that the view instance is reused for the next page. Since the view instance is supposed to be reused, the bridge will cancel the 'dispose-views' message that it usually sends once the window's document is unloaded otherwise the view instance needed by the next page would be disposed.
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #15063 Wed Oct 31 15:43:55 MDT 2007 mircea.toma Send 'dispose-view' message more reliably -- ICE-2202
              Files Changed
              Commit graph MODIFY /icefaces/branches/icefaces-1.6/icefaces/bridge/src/connection.js
              Commit graph MODIFY /icefaces/trunk/icefaces/samples/address-demo/web/WEB-INF/faces-config.xml
              Commit graph MODIFY /icefaces/trunk/icefaces/samples/address-demo/web/response.jspx
              Commit graph MODIFY /icefaces/trunk/icefaces/bridge/src/connection.js
              Commit graph MODIFY /icefaces/branches/icefaces-1.6/icefaces/bridge/src/connection.async.js
              Ken Fyten made changes -
              Fix Version/s 1.7 [ 10080 ]
              Ken Fyten made changes -
              Status Resolved [ 5 ] Closed [ 6 ]

                People

                • Assignee:
                  Unassigned
                  Reporter:
                  Mircea Toma
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  0 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: