ICEfaces
  1. ICEfaces
  2. ICE-2150

selectInputDate inputText and calendar are inconsistent

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.6.1
    • Fix Version/s: 1.6.2, 1.7DR#1, 1.7
    • Component/s: ICE-Components
    • Labels:
      None
    • Environment:
      All
    • Affects:
      Sample App./Tutorial

      Description

      I noticed that the selectInputDate's inputText and the popup calendar used different timezones. This was because the SimpleDateFormat used for the inputText, and the Calendar used for the calendar had different rules for their default timezone. This led me to realise that we didn't have a mechanism for specifying a timezone that both could adhere to.

      Also, it appeared that the Converter wasn't being consistently employed, since some logic was dependent on the popupDateFormat, and some used the Converter.

      So, the decision was made to route everything through the javax.faces.convert.DateTimeConverter, which could specify both the timezone and the pattern for the inputText representation of the Date. The popupDateFormat attribute is no longer necessary, but for backwards compatiblity, if specified, it will override the DateTimeConverter's pattern.

        Activity

        Mark Collette created issue -
        Mark Collette made changes -
        Field Original Value New Value
        Fix Version/s 1.7DR#1 [ 10100 ]
        Assignee Priority P1
        Assignee Mark Collette [ mark.collette ]
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #14867 Wed Sep 26 12:45:49 MDT 2007 mark.collette ICE-2150 : selectInputDate inputText and calendar are inconsistent
        Files Changed
        Commit graph MODIFY /icefaces/trunk/icefaces/samples/component-showcase/web/inc/components/selectInputDate.jspx
        Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/selectinputdate/SelectInputDate.java
        Commit graph MODIFY /icefaces/trunk/icefaces/component-metadata/src/main/resources/conf/ice_cust_properties/cust-selectInputDate-props.xml
        Commit graph MODIFY /icefaces/trunk/icefaces/samples/component-showcase/src/com/icesoft/icefaces/samples/showcase/components/calendar/SelectInputDateBean.java
        Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/util/CustomComponentUtils.java
        Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/selectinputdate/SelectInputDateRenderer.java
        Hide
        Mark Collette added a comment -

        Subversion 14867
        icefaces\component-metadata\src\main\resources\conf\ice_cust_properties\cust-selectInputDate-props.xml
        icefaces\component\src\com\icesoft\faces\component\selectinputdate\SelectInputDate.java
        icefaces\component\src\com\icesoft\faces\component\selectinputdate\SelectInputDateRenderer.java
        icefaces\component\src\com\icesoft\faces\component\util\CustomComponentUtils.java
        icefaces\samples\component-showcase\src\com\icesoft\icefaces\samples\showcase\components\calendar\SelectInputDateBean.java
        icefaces\samples\component-showcase\web\inc\components\selectInputDate.jspx

        Show
        Mark Collette added a comment - Subversion 14867 icefaces\component-metadata\src\main\resources\conf\ice_cust_properties\cust-selectInputDate-props.xml icefaces\component\src\com\icesoft\faces\component\selectinputdate\SelectInputDate.java icefaces\component\src\com\icesoft\faces\component\selectinputdate\SelectInputDateRenderer.java icefaces\component\src\com\icesoft\faces\component\util\CustomComponentUtils.java icefaces\samples\component-showcase\src\com\icesoft\icefaces\samples\showcase\components\calendar\SelectInputDateBean.java icefaces\samples\component-showcase\web\inc\components\selectInputDate.jspx
        Mark Collette made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Ken Fyten added a comment -

        Needs to be backported to the 1.6 branch.

        Show
        Ken Fyten added a comment - Needs to be backported to the 1.6 branch.
        Ken Fyten made changes -
        Resolution Fixed [ 1 ]
        Status Resolved [ 5 ] Reopened [ 4 ]
        Affects [Sample App./Tutorial]
        Assignee Priority P1 P2
        Ken Fyten made changes -
        Fix Version/s 1.6.2 [ 10111 ]
        Fix Version/s 1.7DR#1 [ 10100 ]
        Ken Fyten made changes -
        Fix Version/s 1.7DR#1 [ 10100 ]
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #14993 Fri Oct 19 17:41:31 MDT 2007 mark.collette Backport to 1.6.2 : ICE-1865, ICE-2082, ICE-2095, ICE-2150, ICE-2127
        Files Changed
        Commit graph MODIFY /icefaces/branches/icefaces-1.6/icefaces/samples/component-showcase/src/com/icesoft/icefaces/samples/showcase/components/calendar/SelectInputDateBean.java
        Commit graph MODIFY /icefaces/branches/icefaces-1.6/icefaces/core/src/com/icesoft/faces/resources/css/royale/royale.css
        Commit graph MODIFY /icefaces/branches/icefaces-1.6/icefaces/component/src/com/icesoft/faces/component/CSS_DEFAULT.java
        Commit graph MODIFY /icefaces/branches/icefaces-1.6/icefaces/samples/component-showcase/web/inc/components/selectInputDate.jspx
        Commit graph MODIFY /icefaces/branches/icefaces-1.6/icefaces/core/src/com/icesoft/faces/resources/css/xp/xp-portlet.css
        Commit graph MODIFY /icefaces/branches/icefaces-1.6/icefaces/component/src/com/icesoft/faces/component/selectinputdate/SelectInputDate.java
        Commit graph MODIFY /icefaces/branches/icefaces-1.6/icefaces/component-metadata/src/main/resources/conf/ice_cust_properties/cust-selectInputDate-props.xml
        Commit graph MODIFY /icefaces/branches/icefaces-1.6/icefaces/core/src/com/icesoft/faces/resources/css/xp/xp.css
        Commit graph MODIFY /icefaces/branches/icefaces-1.6/icefaces/component/src/com/icesoft/faces/component/util/CustomComponentUtils.java
        Commit graph MODIFY /icefaces/branches/icefaces-1.6/icefaces/component/src/com/icesoft/faces/component/selectinputdate/SelectInputDateRenderer.java
        Hide
        Mark Collette added a comment -

        This is an amalgamation of the following Jira cases (and their subversion commits), backported to ICEfaces 1.6.2, which were brought in because they overlapped with ICE-2150.

        ICE-1865 (14801), ICE-2082 (14804), ICE-2095 (14821), ICE-2150 (14867), ICE-2127 (14884,14907,14985)

        Subversion 14993
        Backport to 1.6.2 : ICE-1865, ICE-2082, ICE-2095, ICE-2150, ICE-2127

        icefaces16\component-metadata\src\main\resources\conf\ice_cust_properties\cust-selectInputDate-props.xml
        icefaces16\component\src\com\icesoft\faces\component\CSS_DEFAULT.java
        icefaces16\component\src\com\icesoft\faces\component\selectinputdate\SelectInputDate.java
        icefaces16\component\src\com\icesoft\faces\component\selectinputdate\SelectInputDateRenderer.java
        icefaces16\component\src\com\icesoft\faces\component\util\CustomComponentUtils.java
        icefaces16\core\src\com\icesoft\faces\resources\css\royale\royale.css
        icefaces16\core\src\com\icesoft\faces\resources\css\xp\xp-portlet.css
        icefaces16\core\src\com\icesoft\faces\resources\css\xp\xp.css
        icefaces16\samples\component-showcase\src\com\icesoft\icefaces\samples\showcase\components\calendar\SelectInputDateBean.java
        icefaces16\samples\component-showcase\web\inc\components\selectInputDate.jspx

        Show
        Mark Collette added a comment - This is an amalgamation of the following Jira cases (and their subversion commits), backported to ICEfaces 1.6.2, which were brought in because they overlapped with ICE-2150 . ICE-1865 (14801), ICE-2082 (14804), ICE-2095 (14821), ICE-2150 (14867), ICE-2127 (14884,14907,14985) Subversion 14993 Backport to 1.6.2 : ICE-1865 , ICE-2082 , ICE-2095 , ICE-2150 , ICE-2127 icefaces16\component-metadata\src\main\resources\conf\ice_cust_properties\cust-selectInputDate-props.xml icefaces16\component\src\com\icesoft\faces\component\CSS_DEFAULT.java icefaces16\component\src\com\icesoft\faces\component\selectinputdate\SelectInputDate.java icefaces16\component\src\com\icesoft\faces\component\selectinputdate\SelectInputDateRenderer.java icefaces16\component\src\com\icesoft\faces\component\util\CustomComponentUtils.java icefaces16\core\src\com\icesoft\faces\resources\css\royale\royale.css icefaces16\core\src\com\icesoft\faces\resources\css\xp\xp-portlet.css icefaces16\core\src\com\icesoft\faces\resources\css\xp\xp.css icefaces16\samples\component-showcase\src\com\icesoft\icefaces\samples\showcase\components\calendar\SelectInputDateBean.java icefaces16\samples\component-showcase\web\inc\components\selectInputDate.jspx
        Mark Collette made changes -
        Status Reopened [ 4 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Ken Fyten made changes -
        Priority Major [ 3 ] Minor [ 4 ]
        Ken Fyten made changes -
        Fix Version/s 1.7 [ 10080 ]
        Ken Fyten made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Assignee Priority P2
        Assignee Mark Collette [ mark.collette ]

          People

          • Assignee:
            Unassigned
            Reporter:
            Mark Collette
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: