suggested fix: stop the modal overlay if it's running before any submit

Index: D:/Documents and Settings/pbreau/workspace/ICEfaces/bridge/lib/extras/style.js
===================================================================
— D:/Documents and Settings/pbreau/workspace/ICEfaces/bridge/lib/extras/style.js (revision 14846)
+++ D:/Documents and Settings/pbreau/workspace/ICEfaces/bridge/lib/extras/style.js (working copy)
@@ -193,7 +193,13 @@
return Ice.modal.containedInId(parent, id);
}
return false;

• }
  + },
  +
  + reset:function()
  Unknown macro: {+ if( Ice.modal.running ){ + Ice.modal.stop( Ice.modal.id ); + }+ }

};
Index: D:/Documents and Settings/pbreau/workspace/ICEfaces/bridge/src/submit.js
===================================================================
— D:/Documents and Settings/pbreau/workspace/ICEfaces/bridge/src/submit.js (revision 14846)
+++ D:/Documents and Settings/pbreau/workspace/ICEfaces/bridge/src/submit.js (working copy)
@@ -49,6 +49,7 @@
}
}).send();
resetHiddenFieldsFor(form);
+ Ice.modal.reset();
}

function iceSubmit(aForm, aComponent, anEvent)

resetHiddenFieldsFor(aForm);
+ Ice.modal.reset();
}

Test case (Eclipse WTP web project)

Test Case (Eclipse WTP proj) showing suggested workaround failing

steps to reproduce:
1. Select "show modal popup" checkbox
2. In modal popup select the 2nd tab, "Sessions"
3. Select a date for "From" date.
4. Click on the "To" date popup button

The popup should then become covered by the modal overlay. It seems that this is associated with a dom update for the entire form.

actually, this seems not only to be an issue when a selectInput component is used inside
a modal popup. trying to set the modal panel popup's style dynamically via an actionListener
causes the exact same problem.

Screenshot showing the problem

Screenshot after the fix.

The suggested fix doesn't really work. It only appeared to work initially, by chance. If you click more times, the problem will reappear.

The real root cause is the bugs in Ice.modal.start().

To test:

In component-showcase\web\inc\layoutPanels\panelPopup.jspx, in the modal popup element, replace the <ice:outputText/> with the following:

<ice:selectInputDate id="dateFrom" renderAsPopup="true"/>
<ice:selectInputDate id="dateTo" renderAsPopup="true"/>

Changes applied to 1.6 branch.