ICEfaces
  1. ICEfaces
  2. ICE-2124

PanelTabSet doesn't sync bound selectedIndex on tabChange events

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.6.1
    • Fix Version/s: 1.6.2, 1.7DR#3, 1.7
    • Component/s: ICE-Components
    • Labels:
      None
    • Environment:
      win xp

      Description

      The PanelTabSet doesn't synchronize tabChange events with the selectedIndex valueBinding if there is one.

      suggested fix:

      Index: D:/Documents and Settings/pbreau/workspace/ICEfaces/component/src/com/icesoft/faces/component/paneltabset/PanelTabSet.java
      ===================================================================
      --- D:/Documents and Settings/pbreau/workspace/ICEfaces/component/src/com/icesoft/faces/component/paneltabset/PanelTabSet.java (revision 14824)
      +++ D:/Documents and Settings/pbreau/workspace/ICEfaces/component/src/com/icesoft/faces/component/paneltabset/PanelTabSet.java (working copy)
      @@ -279,6 +279,10 @@
                   TabChangeEvent tabChangeEvent = (TabChangeEvent) event;
                   if (tabChangeEvent.getComponent() == this) {
                       setSelectedIndex(tabChangeEvent.getNewTabIndex());
      + if( getValueBinding("selectedIndex") != null ){
      + getValueBinding("selectedIndex").setValue(this.getFacesContext(), Integer.valueOf(tabChangeEvent.getNewTabIndex()));
      + }
      +
                       //getFacesContext().renderResponse();
                   }
               }

        Issue Links

          Activity

          Repository Revision Date User Message
          ICEsoft Public SVN Repository #15045 Mon Oct 29 19:39:12 MDT 2007 mark.collette ICE-2124 : PanelTabSet doesn't sync bound selectedIndex on tabChange events
          Files Changed
          Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/paneltabset/PanelTabSetRenderer.java
          Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/resources/messages.properties
          Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/resources/messages_fr.properties
          Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/paneltabset/PanelTabSet.java
          Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/utils/MessageUtils.java
          Commit graph ADD /icefaces/trunk/icefaces/component/src/com/icesoft/faces/utils/UpdatableProperty.java
          Repository Revision Date User Message
          ICEsoft Public SVN Repository #15046 Mon Oct 29 19:52:07 MDT 2007 mark.collette ICE-2124 : PanelTabSet doesn't sync bound selectedIndex on tabChange events (update component-showcase)
          Files Changed
          Commit graph MODIFY /icefaces/trunk/icefaces/samples/component-showcase/web/inc/layoutPanels/panelTabSet.jspx
          Commit graph MODIFY /icefaces/trunk/icefaces/samples/component-showcase/src/com/icesoft/icefaces/samples/showcase/layoutPanels/tabSetPanel/StaticTabSetBean.java
          Commit graph MODIFY /icefaces/trunk/icefaces/samples/component-showcase/src/com/icesoft/icefaces/samples/showcase/layoutPanels/tabSetPanel/DynamicTabSetBean.java
          Repository Revision Date User Message
          ICEsoft Public SVN Repository #15047 Mon Oct 29 20:08:25 MDT 2007 mark.collette Backport to 1.6.2 : ICE-2124
          Files Changed
          Commit graph MODIFY /icefaces/branches/icefaces-1.6/icefaces/component/src/com/icesoft/faces/component/paneltabset/PanelTabSetRenderer.java
          Commit graph ADD /icefaces/branches/icefaces-1.6/icefaces/component/src/com/icesoft/faces/utils/UpdatableProperty.java
          Commit graph MODIFY /icefaces/branches/icefaces-1.6/icefaces/component/src/com/icesoft/faces/utils/MessageUtils.java
          Commit graph MODIFY /icefaces/branches/icefaces-1.6/icefaces/component/src/com/icesoft/faces/resources/messages.properties
          Commit graph MODIFY /icefaces/branches/icefaces-1.6/icefaces/component/src/com/icesoft/faces/resources/messages_fr.properties
          Commit graph MODIFY /icefaces/branches/icefaces-1.6/icefaces/component/src/com/icesoft/faces/component/paneltabset/PanelTabSet.java
          Repository Revision Date User Message
          ICEsoft Public SVN Repository #15085 Fri Nov 02 11:51:47 MDT 2007 mark.collette ICE-2124 : PanelTabSet doesn't sync bound selectedIndex on tabChange events
          Files Changed
          Commit graph MODIFY /icefaces/branches/icefaces-1.6/icefaces/component/src/com/icesoft/faces/component/paneltabset/PanelTabSetRenderer.java
          Commit graph REPLACE /icefaces/branches/icefaces-1.6/icefaces/component/src/com/icesoft/faces/utils/UpdatableProperty.java
          Commit graph MODIFY /icefaces/branches/icefaces-1.6/icefaces/component/src/com/icesoft/faces/component/paneltabset/PanelTabSet.java
          Repository Revision Date User Message
          ICEsoft Public SVN Repository #15090 Fri Nov 02 17:41:20 MDT 2007 mark.collette ICE-2124 : PanelTabSet doesn't sync bound selectedIndex on tabChange events
          Files Changed
          Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/paneltabset/PanelTabSetRenderer.java
          Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/paneltabset/PanelTabSet.java
          Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/utils/UpdatableProperty.java

            People

            • Assignee:
              Unassigned
              Reporter:
              Philip Breau
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: