ICEfaces
  1. ICEfaces
  2. ICE-1985

In some cases entire form being sent as DOM update

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.7.1
    • Component/s: Framework
    • Labels:
      None
    • Environment:
      DOMUpdate

      Description

      Its been observed that in some cases entire form being sent as DOM update.
      1. 1985-fix.diff
        117 kB
        Philip Breau
      2. ICE-1985.txt
        3 kB
        Adnan Durrani
      3. selectInputDateFix.diff
        112 kB
        Philip Breau

        Issue Links

          Activity

          Hide
          Adnan Durrani added a comment -

          I have created an app, which using all ICEFaces components, to see what components are sending the form element as DOMUpdate.

          Show
          Adnan Durrani added a comment - I have created an app, which using all ICEFaces components, to see what components are sending the form element as DOMUpdate.
          Hide
          Adnan Durrani added a comment -

          The application has been designed so by default the component will not be rendered. To render the component the "render" check box need to be clicked, and the ICEFaces debug console should only show the element level update not the form level.

          Show
          Adnan Durrani added a comment - The application has been designed so by default the component will not be rendered. To render the component the "render" check box need to be clicked, and the ICEFaces debug console should only show the element level update not the form level.
          Hide
          Adnan Durrani added a comment -

          commandButton sends form level update

          Show
          Adnan Durrani added a comment - commandButton sends form level update
          Hide
          Adnan Durrani added a comment -

          commandLink sends form level update

          Show
          Adnan Durrani added a comment - commandLink sends form level update
          Hide
          Adnan Durrani added a comment -
          • dataPaginator sends form level update on render
          • Sends element level update on navigation
          Show
          Adnan Durrani added a comment - dataPaginator sends form level update on render Sends element level update on navigation
          Hide
          Adnan Durrani added a comment -

          menuBar component sends form level update if using actionListener

          Show
          Adnan Durrani added a comment - menuBar component sends form level update if using actionListener
          Hide
          Adnan Durrani added a comment -

          outputChart component sends form level update

          Show
          Adnan Durrani added a comment - outputChart component sends form level update
          Hide
          Adnan Durrani added a comment -

          panelCollapsible sends form level update

          Show
          Adnan Durrani added a comment - panelCollapsible sends form level update
          Hide
          Adnan Durrani added a comment -

          panelTabSet sends form level update

          Show
          Adnan Durrani added a comment - panelTabSet sends form level update
          Hide
          Adnan Durrani added a comment -
          • selectInputDate sends form level update on render
          • sends element level update on navigation
          Show
          Adnan Durrani added a comment - selectInputDate sends form level update on render sends element level update on navigation
          Hide
          Ted Goddard added a comment -

          This bug is causing unacceptable performance in an application Neil Griffin is developing for a customer.

          It is likely caused by the way that commandLink uses hidden fields (a different hidden field for each command link?). Since only one commandLink can be submitted at a time, one hidden field could be shared by multiple commandLinks. A single hidden field would not be added/removed due to changes in the page.

          Show
          Ted Goddard added a comment - This bug is causing unacceptable performance in an application Neil Griffin is developing for a customer. It is likely caused by the way that commandLink uses hidden fields (a different hidden field for each command link?). Since only one commandLink can be submitted at a time, one hidden field could be shared by multiple commandLinks. A single hidden field would not be added/removed due to changes in the page.
          Hide
          Philip Breau added a comment -

          candidate fix for the selectInputDate:

          • selectInputDate hidden fields placed inside root div for component
          • FormRender.addHiddenField() checks for existence of hidden input before adding another hidden field to avoid duplicate commandLink hidden fields
          Show
          Philip Breau added a comment - candidate fix for the selectInputDate: selectInputDate hidden fields placed inside root div for component FormRender.addHiddenField() checks for existence of hidden input before adding another hidden field to avoid duplicate commandLink hidden fields
          Hide
          Philip Breau added a comment -

          I'm not seeing any form-level updates for the dataPaginator or the panelTabSet

          Show
          Philip Breau added a comment - I'm not seeing any form-level updates for the dataPaginator or the panelTabSet
          Hide
          Adnan Durrani added a comment -

          Review attached

          Show
          Adnan Durrani added a comment - Review attached
          Hide
          Adnan Durrani added a comment -

          Branch 1.7 : revision 16470

          Trunk : revision 16471

          Changes made to the all renderes listed in the attached document. So none of the hidden field directly going to add to the "form" element anymore. That will prevent the form level update.

          Show
          Adnan Durrani added a comment - Branch 1.7 : revision 16470 Trunk : revision 16471 Changes made to the all renderes listed in the attached document. So none of the hidden field directly going to add to the "form" element anymore. That will prevent the form level update.
          Hide
          Mandeep Hayher added a comment -

          Verified successfully on revision# 16468

          Show
          Mandeep Hayher added a comment - Verified successfully on revision# 16468
          Hide
          Krashan Brahmanjara added a comment -

          You forget about RowSelector.

          Just add rowSelecotr to any table and you see that after selector click server response is very big and contain a whole form with table.
          This is probably to main bug of icefaces - tested and exist on revision 17500

          Show
          Krashan Brahmanjara added a comment - You forget about RowSelector. Just add rowSelecotr to any table and you see that after selector click server response is very big and contain a whole form with table. This is probably to main bug of icefaces - tested and exist on revision 17500
          Hide
          Krashan Brahmanjara added a comment -

          From the other hand in above RowSelector case after user select new row then should'nt be any server-client communication
          until client not define in xhtml code selectionListener or partialSubmit="true"!

          Create new JIRA for this bug?

          Show
          Krashan Brahmanjara added a comment - From the other hand in above RowSelector case after user select new row then should'nt be any server-client communication until client not define in xhtml code selectionListener or partialSubmit="true"! Create new JIRA for this bug?

            People

            • Assignee:
              Unassigned
              Reporter:
              Adnan Durrani
            • Votes:
              3 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: