ICEfaces
  1. ICEfaces
  2. ICE-1985

In some cases entire form being sent as DOM update

          Details

          • Type: Improvement Improvement
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: None
          • Fix Version/s: 1.7.1
          • Component/s: Framework
          • Labels:
            None
          • Environment:
            DOMUpdate

            Description

            Its been observed that in some cases entire form being sent as DOM update.
            1. File
              1985-fix.diff
              117 kB
              Philip Breau
            2. Text File
              ICE-1985.txt
              3 kB
              Adnan Durrani
            3. File
              selectInputDateFix.diff
              112 kB
              Philip Breau

              Issue Links

              blocks

              Bug - A problem which impairs or prevents the functions of the product. ICE-1912 whole form gets updated when single component in table is modified

              • Major - Major loss of function.
              • Closed

                Activity

                Ascending order - Click to sort in descending order
                Adnan Durrani created issue -
                Adnan Durrani made changes -
                Field Original Value New Value
                Assignee Adnan Durrani [ adnan.durrani ]
                Adnan Durrani made changes -
                Status Open [ 1 ] In Progress [ 3 ]
                Hide
                Permalink
                Adnan Durrani added a comment -

                I have created an app, which using all ICEFaces components, to see what components are sending the form element as DOMUpdate.

                Show
                Adnan Durrani added a comment - I have created an app, which using all ICEFaces components, to see what components are sending the form element as DOMUpdate.
                Hide
                Permalink
                Adnan Durrani added a comment -

                The application has been designed so by default the component will not be rendered. To render the component the "render" check box need to be clicked, and the ICEFaces debug console should only show the element level update not the form level.

                Show
                Adnan Durrani added a comment - The application has been designed so by default the component will not be rendered. To render the component the "render" check box need to be clicked, and the ICEFaces debug console should only show the element level update not the form level.
                Hide
                Permalink
                Adnan Durrani added a comment -

                commandButton sends form level update

                Show
                Adnan Durrani added a comment - commandButton sends form level update
                Hide
                Permalink
                Adnan Durrani added a comment -

                commandLink sends form level update

                Show
                Adnan Durrani added a comment - commandLink sends form level update
                Hide
                Permalink
                Adnan Durrani added a comment -
                • dataPaginator sends form level update on render
                • Sends element level update on navigation
                Show
                Adnan Durrani added a comment - dataPaginator sends form level update on render Sends element level update on navigation
                Hide
                Permalink
                Adnan Durrani added a comment -

                menuBar component sends form level update if using actionListener

                Show
                Adnan Durrani added a comment - menuBar component sends form level update if using actionListener
                Hide
                Permalink
                Adnan Durrani added a comment -

                outputChart component sends form level update

                Show
                Adnan Durrani added a comment - outputChart component sends form level update
                Hide
                Permalink
                Adnan Durrani added a comment -

                panelCollapsible sends form level update

                Show
                Adnan Durrani added a comment - panelCollapsible sends form level update
                Hide
                Permalink
                Adnan Durrani added a comment -

                panelTabSet sends form level update

                Show
                Adnan Durrani added a comment - panelTabSet sends form level update
                Hide
                Permalink
                Adnan Durrani added a comment -
                • selectInputDate sends form level update on render
                • sends element level update on navigation
                Show
                Adnan Durrani added a comment - selectInputDate sends form level update on render sends element level update on navigation
                Adnan Durrani made changes -
                Link This issue blocks ICE-1912 [ ICE-1912 ]
                Ken Fyten made changes -
                Link This issue blocks ICE-2284 [ ICE-2284 ]
                Ken Fyten made changes -
                Issue Type Bug [ 1 ] Improvement [ 4 ]
                Fix Version/s 2.0 [ 10032 ]
                Assignee Adnan Durrani [ adnan.durrani ]
                Hide
                Permalink
                Ted Goddard added a comment -

                This bug is causing unacceptable performance in an application Neil Griffin is developing for a customer.

                It is likely caused by the way that commandLink uses hidden fields (a different hidden field for each command link?). Since only one commandLink can be submitted at a time, one hidden field could be shared by multiple commandLinks. A single hidden field would not be added/removed due to changes in the page.

                Show
                Ted Goddard added a comment - This bug is causing unacceptable performance in an application Neil Griffin is developing for a customer. It is likely caused by the way that commandLink uses hidden fields (a different hidden field for each command link?). Since only one commandLink can be submitted at a time, one hidden field could be shared by multiple commandLinks. A single hidden field would not be added/removed due to changes in the page.
                Ken Fyten made changes -
                Fix Version/s 1.7.1 [ 10122 ]
                Fix Version/s 2.0 [ 10032 ]
                Tyler Johnson made changes -
                Support Case References https://www.icesoft.ca:4443/supportilla/show_bug.cgi?id=4699
                Tyler Johnson made changes -
                Assignee Adnan Durrani [ adnan.durrani ]
                Tyler Johnson made changes -
                Priority Major [ 3 ] Critical [ 2 ]
                Hide
                Permalink
                Philip Breau added a comment -

                candidate fix for the selectInputDate:

                • selectInputDate hidden fields placed inside root div for component
                • FormRender.addHiddenField() checks for existence of hidden input before adding another hidden field to avoid duplicate commandLink hidden fields
                Show
                Philip Breau added a comment - candidate fix for the selectInputDate: selectInputDate hidden fields placed inside root div for component FormRender.addHiddenField() checks for existence of hidden input before adding another hidden field to avoid duplicate commandLink hidden fields
                Philip Breau made changes -
                Attachment selectInputDateFix.diff [ 10910 ]
                Hide
                Permalink
                Philip Breau added a comment -

                I'm not seeing any form-level updates for the dataPaginator or the panelTabSet

                Show
                Philip Breau added a comment - I'm not seeing any form-level updates for the dataPaginator or the panelTabSet
                Ken Fyten made changes -
                Assignee Priority P1
                Hide
                Permalink
                Adnan Durrani added a comment -

                Review attached

                Show
                Adnan Durrani added a comment - Review attached
                Adnan Durrani made changes -
                Attachment ICE-1985.txt [ 10913 ]
                Philip Breau made changes -
                Attachment 1985-fix.diff [ 10914 ]
                Repository Revision Date User Message
                ICEsoft Public SVN Repository #16462 Thu Apr 17 07:26:12 MDT 2008 adnan.durrani Hidden field localized to the component. Related to ICE-1985 (in some cases entire form being sent as DOM update)
                Files Changed
                Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/panelcollapsible/PanelCollapsibleRenderer.java
                Repository Revision Date User Message
                ICEsoft Public SVN Repository #16470 Mon Apr 21 06:33:03 MDT 2008 adnan.durrani Fix for ICE-1985 (In some cases entire form being sent as DOM update)
                Files Changed
                Commit graph MODIFY /icefaces/branches/icefaces-1.7/icefaces/component/src/com/icesoft/faces/component/paneltabset/PanelTabSetRenderer.java
                Commit graph MODIFY /icefaces/branches/icefaces-1.7/icefaces/component/src/com/icesoft/faces/component/panelcollapsible/PanelCollapsibleRenderer.java
                Commit graph MODIFY /icefaces/branches/icefaces-1.7/icefaces/core/src/com/icesoft/faces/renderkit/dom_html_basic/FormRenderer.java
                Commit graph MODIFY /icefaces/branches/icefaces-1.7/icefaces/component/src/com/icesoft/faces/component/outputchart/OutputChartRenderer.java
                Commit graph MODIFY /icefaces/branches/icefaces-1.7/icefaces/component/src/com/icesoft/faces/component/tree/TreeRenderer.java
                Repository Revision Date User Message
                ICEsoft Public SVN Repository #16471 Mon Apr 21 06:38:50 MDT 2008 adnan.durrani Fix for ICE-1985 (In some cases entire form being sent as DOM update)
                Files Changed
                Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/outputchart/OutputChartRenderer.java
                Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/paneltabset/PanelTabSetRenderer.java
                Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/renderkit/dom_html_basic/FormRenderer.java
                Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/tree/TreeRenderer.java
                Hide
                Permalink
                Adnan Durrani added a comment -

                Branch 1.7 : revision 16470

                Trunk : revision 16471

                Changes made to the all renderes listed in the attached document. So none of the hidden field directly going to add to the "form" element anymore. That will prevent the form level update.

                Show
                Adnan Durrani added a comment - Branch 1.7 : revision 16470 Trunk : revision 16471 Changes made to the all renderes listed in the attached document. So none of the hidden field directly going to add to the "form" element anymore. That will prevent the form level update.
                Adnan Durrani made changes -
                Status In Progress [ 3 ] Resolved [ 5 ]
                Fix Version/s 1.7 [ 10080 ]
                Resolution Fixed [ 1 ]
                Hide
                Permalink
                Mandeep Hayher added a comment -

                Verified successfully on revision# 16468

                Show
                Mandeep Hayher added a comment - Verified successfully on revision# 16468
                Ken Fyten made changes -
                Fix Version/s 1.7 [ 10080 ]
                Ken Fyten made changes -
                Priority Critical [ 2 ] Major [ 3 ]
                Ken Fyten made changes -
                Status Resolved [ 5 ] Closed [ 6 ]
                Assignee Priority P1
                Assignee Adnan Durrani [ adnan.durrani ]
                Hide
                Permalink
                Krashan Brahmanjara added a comment -

                You forget about RowSelector.

                Just add rowSelecotr to any table and you see that after selector click server response is very big and contain a whole form with table.
                This is probably to main bug of icefaces - tested and exist on revision 17500

                Show
                Krashan Brahmanjara added a comment - You forget about RowSelector. Just add rowSelecotr to any table and you see that after selector click server response is very big and contain a whole form with table. This is probably to main bug of icefaces - tested and exist on revision 17500
                Hide
                Permalink
                Krashan Brahmanjara added a comment -

                From the other hand in above RowSelector case after user select new row then should'nt be any server-client communication
                until client not define in xhtml code selectionListener or partialSubmit="true"!

                Create new JIRA for this bug?

                Show
                Krashan Brahmanjara added a comment - From the other hand in above RowSelector case after user select new row then should'nt be any server-client communication until client not define in xhtml code selectionListener or partialSubmit="true"! Create new JIRA for this bug?

                  People

                  • Assignee:
                    Unassigned
                    Reporter:
                    Adnan Durrani
                  • Votes:
                    3 Vote for this issue
                    Watchers:
                    4 Start watching this issue

                    Dates

                    • Created:
                      Updated:
                      Resolved: