ICEfaces
  1. ICEfaces
  2. ICE-1956

Immediate attribute not working on MenuItem

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.6
    • Fix Version/s: 1.6.1
    • Component/s: ICE-Components
    • Labels:
      None
    • Environment:
      win xp

      Description

      The immediate attribute on the MenuItem should function like other UICommand components and cause any actions or actionListeners to be run in the Apply request values phase. This is not happening.

        Activity

        Philip Breau created issue -
        Hide
        Philip Breau added a comment -

        test case

        Show
        Philip Breau added a comment - test case
        Philip Breau made changes -
        Field Original Value New Value
        Attachment Test_MenuItemImmediateTrue.zip [ 10580 ]
        Philip Breau made changes -
        Support Case References https://www.icesoft.ca:4443/supportilla/show_bug.cgi?id=4205
        Support Customer Ref. #s 739
        Ken Fyten made changes -
        Fix Version/s 1.6.1 [ 10070 ]
        Assignee Priority P2
        Assignee Mark Collette [ mark.collette ]
        Hide
        Mark Collette added a comment -

        I found an issue with the implementation of UICommand that causes this issue:
        https://javaserverfaces.dev.java.net/issues/show_bug.cgi?id=622

        It looks like this is a problem with any UICommand subclass that's a container for other components that fire off ActionEvents. In our code that would include MenuBar, MenuItem, PanelCollapsible, Tree, and kind of InputFile.

        Show
        Mark Collette added a comment - I found an issue with the implementation of UICommand that causes this issue: https://javaserverfaces.dev.java.net/issues/show_bug.cgi?id=622 It looks like this is a problem with any UICommand subclass that's a container for other components that fire off ActionEvents. In our code that would include MenuBar, MenuItem, PanelCollapsible, Tree, and kind of InputFile.
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #14707 Thu Aug 23 11:45:24 MDT 2007 mark.collette ICE-1956 : Immediate attribute not working on MenuItem
        Files Changed
        Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/menubar/MenuItem.java
        Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/tree/Tree.java
        Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/panelcollapsible/PanelCollapsible.java
        Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/menubar/MenuBar.java
        Hide
        Mark Collette added a comment -

        Made it so that the UICommand subclasses would override queueEvent(FacesEvent), and when there's an ActionEvent that filters up to them from a child component, would pass it directly on to the current component's parent, instead of calling super.queueEvent(FacesEvent), effectively doing what UIComponentBase.queueEvent(FacesEvent) does, bypassing UICommand.queueEvent(FacesEvent).

        Subversion 14707
        icefaces\component\src\com\icesoft\faces\component\menubar\MenuBar.java
        icefaces\component\src\com\icesoft\faces\component\menubar\MenuItem.java
        icefaces\component\src\com\icesoft\faces\component\panelcollapsible\PanelCollapsible.java
        icefaces\component\src\com\icesoft\faces\component\tree\Tree.java

        Show
        Mark Collette added a comment - Made it so that the UICommand subclasses would override queueEvent(FacesEvent), and when there's an ActionEvent that filters up to them from a child component, would pass it directly on to the current component's parent, instead of calling super.queueEvent(FacesEvent), effectively doing what UIComponentBase.queueEvent(FacesEvent) does, bypassing UICommand.queueEvent(FacesEvent). Subversion 14707 icefaces\component\src\com\icesoft\faces\component\menubar\MenuBar.java icefaces\component\src\com\icesoft\faces\component\menubar\MenuItem.java icefaces\component\src\com\icesoft\faces\component\panelcollapsible\PanelCollapsible.java icefaces\component\src\com\icesoft\faces\component\tree\Tree.java
        Mark Collette made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Ken Fyten made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Assignee Priority P2
        Assignee Mark Collette [ mark.collette ]

          People

          • Assignee:
            Unassigned
            Reporter:
            Philip Breau
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: