ICEfaces
  1. ICEfaces
  2. ICE-1909

Handle HttpSession.invalidate() calls gracefully

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.6
    • Fix Version/s: 1.7Beta1, 1.7
    • Component/s: Framework
    • Labels:
      None
    • Environment:
      server

      Description

      Intercept HttpSession.invalidate() calls to shutdown framework+applications gracefully.

        Issue Links

          Activity

          Mircea Toma created issue -
          Mircea Toma made changes -
          Field Original Value New Value
          Assignee Mircea Toma [ mircea.toma ]
          Repository Revision Date User Message
          ICEsoft Public SVN Repository #14543 Tue Jul 24 11:20:44 MDT 2007 mircea.toma Intercept *Session.invalidate calls -- ICE-1909
          Files Changed
          Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/webapp/http/servlet/ServletExternalContext.java
          Commit graph ADD /icefaces/trunk/icefaces/core/src/com/icesoft/faces/webapp/http/portlet/ProxyPortletSession.java
          Commit graph ADD /icefaces/trunk/icefaces/core/src/com/icesoft/faces/webapp/http/servlet/ProxyHttpSession.java
          Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/webapp/http/core/SingleViewServer.java
          Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/webapp/http/servlet/SessionDispatcher.java
          Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/webapp/http/core/MultiViewServer.java
          Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/context/View.java
          Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/webapp/http/portlet/PortletExternalContext.java
          Hide
          Mircea Toma added a comment -

          Intercepted HttpSession.invalidate and PortletSEssion.invalidate calls.

          Show
          Mircea Toma added a comment - Intercepted HttpSession.invalidate and PortletSEssion.invalidate calls.
          Hide
          Michael Thiem added a comment -

          As this is an often discussed issue in the forum, we should provide some
          best practices or a short tutorial on how to handle login/logout functionality
          in an ICEfaces / JSF environment

          Show
          Michael Thiem added a comment - As this is an often discussed issue in the forum, we should provide some best practices or a short tutorial on how to handle login/logout functionality in an ICEfaces / JSF environment
          Hide
          Mircea Toma added a comment -

          Intercept *Session.invalidate calls, shutdown framework gracefully, and then invalidate session.

          Show
          Mircea Toma added a comment - Intercept *Session.invalidate calls, shutdown framework gracefully, and then invalidate session.
          Mircea Toma made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Mircea Toma made changes -
          Fix Version/s 1.6.1 [ 10070 ]
          Ken Fyten made changes -
          Issue Type Bug [ 1 ] Improvement [ 4 ]
          Ken Fyten made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Assignee Mircea Toma [ mircea.toma ]
          Sam Xiao made changes -
          Resolution Fixed [ 1 ]
          Status Closed [ 6 ] Reopened [ 4 ]
          Security Private [ 10001 ]
          Sam Xiao made changes -
          Attachment ICE-1909.war [ 10760 ]
          Hide
          Ken Fyten added a comment -

          Looks like we have regressed in 1.7 DR#3 on this issue.

          Show
          Ken Fyten added a comment - Looks like we have regressed in 1.7 DR#3 on this issue.
          Ken Fyten made changes -
          Assignee Mircea Toma [ mircea.toma ]
          Ken Fyten made changes -
          Fix Version/s 1.7 [ 10080 ]
          Fix Version/s 1.6.1 [ 10070 ]
          Repository Revision Date User Message
          ICEsoft Public SVN Repository #15532 Thu Jan 10 12:56:55 MST 2008 mircea.toma Delay the release of FacesContext as well.
          ICE-1909
          Files Changed
          Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/webapp/http/servlet/MainSessionBoundServlet.java
          Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/webapp/http/servlet/SessionDispatcher.java
          Hide
          Mircea Toma added a comment -

          Delay the release of FacesContext.

          Show
          Mircea Toma added a comment - Delay the release of FacesContext.
          Mircea Toma made changes -
          Status Reopened [ 4 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Ken Fyten made changes -
          Fix Version/s 1.7Beta1 [ 10121 ]
          Fix Version/s 1.7 [ 10080 ]
          Repository Revision Date User Message
          ICEsoft Public SVN Repository #15709 Fri Feb 01 16:45:08 MST 2008 mircea.toma Avoid the use of threads when shutting down.
          ICE-1909
          Files Changed
          Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/webapp/http/servlet/MainSessionBoundServlet.java
          Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/context/BridgeExternalContext.java
          Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/context/BridgeFacesContext.java
          Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/context/View.java
          Hide
          Mircea Toma added a comment -

          The delay introduced another problem on app restart:

          java.lang.IllegalStateException
          at org.apache.catalina.loader.WebappClassLoader.loadClass(WebappClassLoader.java:1244)
          at org.apache.catalina.loader.WebappClassLoader.loadClass(WebappClassLoader.java:1204)
          at java.lang.ClassLoader.loadClassInternal(ClassLoader.java:374)
          at com.icesoft.faces.util.event.servlet.ContextEventRepeater.iceFacesIdDisposed(ContextEventRepeater.java:207)
          at com.icesoft.faces.webapp.http.servlet.MainSessionBoundServlet$3.run(MainSessionBoundServlet.java:123)

          Show
          Mircea Toma added a comment - The delay introduced another problem on app restart: java.lang.IllegalStateException at org.apache.catalina.loader.WebappClassLoader.loadClass(WebappClassLoader.java:1244) at org.apache.catalina.loader.WebappClassLoader.loadClass(WebappClassLoader.java:1204) at java.lang.ClassLoader.loadClassInternal(ClassLoader.java:374) at com.icesoft.faces.util.event.servlet.ContextEventRepeater.iceFacesIdDisposed(ContextEventRepeater.java:207) at com.icesoft.faces.webapp.http.servlet.MainSessionBoundServlet$3.run(MainSessionBoundServlet.java:123)
          Mircea Toma made changes -
          Resolution Fixed [ 1 ]
          Status Resolved [ 5 ] Reopened [ 4 ]
          Hide
          Mircea Toma added a comment -

          Avoid the use of threads when shutting down.

          Show
          Mircea Toma added a comment - Avoid the use of threads when shutting down.
          Mircea Toma made changes -
          Status Reopened [ 4 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Ken Fyten made changes -
          Security Private [ 10001 ]
          Ken Fyten made changes -
          Priority Major [ 3 ] Minor [ 4 ]
          Mircea Toma made changes -
          Link This issue blocks ICE-2748 [ ICE-2748 ]
          Ken Fyten made changes -
          Fix Version/s 1.7 [ 10080 ]
          Ken Fyten made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Assignee Mircea Toma [ mircea.toma ]

            People

            • Assignee:
              Unassigned
              Reporter:
              Mircea Toma
            • Votes:
              3 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: