ICEfaces
  1. ICEfaces
  2. ICE-1883

Partial submit disables previous validation messages

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.6
    • Fix Version/s: 1.7DR#3, 1.7
    • Component/s: Framework
    • Labels:
      None
    • Environment:
      All

      Description

      When using standard JSF validation on various required fields, the form is submitted and validation functions correctly. The required fields are flagged with ICEfaces messages and the form is not submitted. When partial submit is enabled, a user will enter data/click out of an input field and the form is partially submitted. The problem is that ICEfaces disables all required statuses in order to submit the page and when the partial submit returns, it does not retain the original validation messages for required inputs.

        Activity

        Hide
        Philip Breau added a comment -

        This is a large usability more than a bug itself. We may want to have a default retainAfterPartialSubmit attribute on the ice:message and messages components, where they retain previous messages until a full submit.

        Show
        Philip Breau added a comment - This is a large usability more than a bug itself. We may want to have a default retainAfterPartialSubmit attribute on the ice:message and messages components, where they retain previous messages until a full submit.
        Hide
        Ted Goddard added a comment -

        A special message component variant is an interesting idea. Are we losing all validation error messages or just the "required" error messages?

        Another option may be to create a custom validator that returns an error until it is cleared – the validator would not test for an empty value until the component was "required", but once "required" would continue to test for an empty value.

        Show
        Ted Goddard added a comment - A special message component variant is an interesting idea. Are we losing all validation error messages or just the "required" error messages? Another option may be to create a custom validator that returns an error until it is cleared – the validator would not test for an empty value until the component was "required", but once "required" would continue to test for an empty value.
        Hide
        Ted Goddard added a comment -

        Assigning to Philip to comment on which messages specifically are being lost (with input from Tyler from his observations).

        Show
        Ted Goddard added a comment - Assigning to Philip to comment on which messages specifically are being lost (with input from Tyler from his observations).
        Hide
        Philip Breau added a comment -

        This involves any validation message, whether arising from a conversion error, validation error, or missing required error. The proposed new behaviour would be quite simple. A new attribute, such as 'retainOnPartialSubmit' would cause the lifespan of a message to span partialSubmits and only be cleared on a full submit or a partialSubmit originating from the corresponding component of the message itself. This is the desired behaviour requested from both clients.

        Show
        Philip Breau added a comment - This involves any validation message, whether arising from a conversion error, validation error, or missing required error. The proposed new behaviour would be quite simple. A new attribute, such as 'retainOnPartialSubmit' would cause the lifespan of a message to span partialSubmits and only be cleared on a full submit or a partialSubmit originating from the corresponding component of the message itself. This is the desired behaviour requested from both clients.
        Hide
        Adnan Durrani added a comment -

        Revision 15209

        Show
        Adnan Durrani added a comment - Revision 15209
        Hide
        Adnan Durrani added a comment -

        revision 15220

        Show
        Adnan Durrani added a comment - revision 15220
        Hide
        Adnan Durrani added a comment -

        revision 15238

        Show
        Adnan Durrani added a comment - revision 15238
        Hide
        Adnan Durrani added a comment -

        revision: 15289

        Show
        Adnan Durrani added a comment - revision: 15289
        Hide
        Ken Fyten added a comment -

        The implemented enhancement is to retain the display of error messages for any components that:

        • Were in an invalid state prior to the partialSubmit
        • Are not the component that is the subject of the partialSubmit

        This supports the use-cases where user's are entering data in a partial-submit form, enter an invalid value in field 1, see the error msg., then move to field2 and enter a value there. Prior to this change the original error msg. from their invalid entry into field1 would disappear when field2 was partialSubmitted. Now error msgs for all invalid state components will continue to be displayed until they are in a valid state.

        Show
        Ken Fyten added a comment - The implemented enhancement is to retain the display of error messages for any components that: Were in an invalid state prior to the partialSubmit Are not the component that is the subject of the partialSubmit This supports the use-cases where user's are entering data in a partial-submit form, enter an invalid value in field 1, see the error msg., then move to field2 and enter a value there. Prior to this change the original error msg. from their invalid entry into field1 would disappear when field2 was partialSubmitted. Now error msgs for all invalid state components will continue to be displayed until they are in a valid state.

          People

          • Assignee:
            Unassigned
            Reporter:
            Tyler Johnson
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: